fix: Use fs-extra instead of rimraf #883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For reference, in case this would still fail in the future, |
rubensworks
approved these changes
Aug 2, 2021
Well one of the tests just failed on this PR so I'm going to give that one a shot instead. |
joachimvh
force-pushed
the
fix/async-rimraf
branch
from
e66988b
to
8ad10a3
Compare
|
fs-extra didn't fail so it got lucky and is now the chosen library for this |
joachimvh
changed the title
| export function removeFolder(folder: string): void { | ||
| rimraf.sync(folder, { glob: false }); | ||
| export async function removeFolder(folder: string): Promise<void> { | ||
| await remove(folder); |
There was a problem hiding this comment.
Or you could have re-exported that function 😄
There was a problem hiding this comment.
Kept it like this just in case there is another issue only 1 place needs to change. 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have noticed an increase in CI tests failing since the amount of jobs double (due to testing both on push and on pull request). One error I have seen multiple times in such cases is rimraf failing to delete a folder after tests on Windows: https://github.com/solid/community-server/runs/3204484785?check_suite_focus=true#step:7:18
This PR changes rimraf to use the async call which might help, and even if it doesn't it's not a bad idea to use the async version.