Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add describes, fix link relation, fix typo in ACL Ontology #80

Merged
merged 6 commits into from
Nov 2, 2022

Conversation

csarven
Copy link
Member

@csarven csarven commented Sep 16, 2022

  • Add statement about the WAC spec describing ACL.
  • Fix comment about using the acl Link Relation - registered at IANA - as alternative to acl:accessControl property.
  • Fix typo in acl:owner comment.

@csarven csarven requested a review from timbl September 16, 2022 10:33
@csarven csarven changed the title Add describes, fix link relation, fix typo Add describes, fix link relation, fix typo in ACL Ontology Sep 16, 2022
acl.n3 Outdated Show resolved Hide resolved
acl.n3 Outdated Show resolved Hide resolved
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Copy link
Member

@kjetilk kjetilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong namespace?

acl.n3 Outdated
@@ -14,7 +14,7 @@

<https://www.w3.org/wiki/WebAccessControl> dc:describes <>.
<https://github.com/solid/web-access-control-spec> dc:describes <>.

<https://solidproject.org/TR/wac> dc:describes <>.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't seem that this property is defined there: https://www.dublincore.org/specifications/dublin-core/dcmi-terms/#section-3

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I suspect that dc:description was intended in the previous lines and I followed without thinking.

While we are looking at this, would it be appropriate to change the namespace from /elements/1.1/ to /terms/ since "DCMI gently encourages use of the /terms/ namespace"? The ACL Ontology currently only uses :title and :describes (and we are about to change the latter to :description unless another property is preferred.)

I think we can remove statement with https://github.com/solid/web-access-control-spec and keep only https://www.w3.org/wiki/WebAccessControl and https://solidproject.org/TR/wac .

What say you all?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree we should us a term which exists. Agree we shoiuld use DCT not DC. I Like having a pointer to the spec from the ontolgy

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in f2eaf6a

Copy link
Contributor

@timbl timbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me aftrer the changes Sarven and I just discussed.

@kjetilk
Copy link
Member

kjetilk commented Sep 20, 2022

Good change! /elements/1.1/ was ancientarchaic at this point.

However, I'm not sure what we are trying to say by dct:description... First, that is usually an annotation property, whereas it seems we are looking for an object property, so something tells me there's something wrong.

Are we really looking for an inverse of rdfs:isDefinedBy?

@csarven
Copy link
Member Author

csarven commented Sep 20, 2022

Not quite definition but more along the lines of describes, discusses, uses. Certainly ACL Ontology predates the mentioned documents.

dct:description seemed fine to me/TimBL if that matters, but come to think of it, I've only used/seen dct:description with a literal value. It (dc-terms, -elements) doesn't seem to formally define it as an object property as far as I can tell.

In this PR, acl link relation type (registered at IANA https://www.iana.org/assignments/link-relations/link-relations.xhtml ) is mentioned as a comment of acl:accessControl, and the term is defined in the WAC spec. I've added/proposing ( 6e4e2fc ) acl:accessControl to have a seeAlso to https://solidproject.org/TR/wac#acl-link-relation .

Copy link
Member

@kjetilk kjetilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. As long as it doesn't break anything, we can go with it.

I'm thinking it probably won't be very useful either, since people tend to expect a literal object with dct:description, but if you think it covers what you want to say, OK.

@csarven csarven self-assigned this Oct 18, 2022
@csarven
Copy link
Member Author

csarven commented Nov 1, 2022

Would foaf:topic be an adequate replacement for dct:description .. and so we can move on until a more suitable probably takes is place?

Copy link
Member

@kjetilk kjetilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's better, I think.

@csarven csarven merged commit 089da4c into main Nov 2, 2022
@csarven csarven deleted the fix/acl-wac-rel-typo branch November 2, 2022 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants