-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add describes, fix link relation, fix typo in ACL Ontology #80
Conversation
csarven
commented
Sep 16, 2022
- Add statement about the WAC spec describing ACL.
- Fix comment about using the acl Link Relation - registered at IANA - as alternative to acl:accessControl property.
- Fix typo in acl:owner comment.
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrong namespace?
acl.n3
Outdated
@@ -14,7 +14,7 @@ | |||
|
|||
<https://www.w3.org/wiki/WebAccessControl> dc:describes <>. | |||
<https://github.com/solid/web-access-control-spec> dc:describes <>. | |||
|
|||
<https://solidproject.org/TR/wac> dc:describes <>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't seem that this property is defined there: https://www.dublincore.org/specifications/dublin-core/dcmi-terms/#section-3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! I suspect that dc:description
was intended in the previous lines and I followed without thinking.
While we are looking at this, would it be appropriate to change the namespace from /elements/1.1/
to /terms/
since "DCMI gently encourages use of the /terms/
namespace"? The ACL Ontology currently only uses :title
and :describes
(and we are about to change the latter to :description
unless another property is preferred.)
I think we can remove statement with https://github.com/solid/web-access-control-spec and keep only https://www.w3.org/wiki/WebAccessControl and https://solidproject.org/TR/wac .
What say you all?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree we should us a term which exists. Agree we shoiuld use DCT not DC. I Like having a pointer to the spec from the ontolgy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated in f2eaf6a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me aftrer the changes Sarven and I just discussed.
Good change! However, I'm not sure what we are trying to say by Are we really looking for an inverse of |
Not quite definition but more along the lines of describes, discusses, uses. Certainly ACL Ontology predates the mentioned documents.
In this PR, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. As long as it doesn't break anything, we can go with it.
I'm thinking it probably won't be very useful either, since people tend to expect a literal object with dct:description
, but if you think it covers what you want to say, OK.
Would |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that's better, I think.