Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@solid-primitives/storage] error: Cannot resolve "@tauri-apps/plugin-store" from "node_modules/@solid-primitives/storage/dist/index.js" and externals are not allowed! #617

Closed
FlatMapIO opened this issue Apr 23, 2024 · 6 comments
Assignees

Comments

@FlatMapIO
Copy link

Describe the bug

After updating to the latest @solid-primitives/storage, a build error occurred in solid-start.

Minimal Reproduction Link

NO

@FlatMapIO FlatMapIO changed the title [@solid-primitives/storage] rror: Cannot resolve "@tauri-apps/plugin-store" from "node_modules/@solid-primitives/storage/dist/index.js" and externals are not allowed! [@solid-primitives/storage] error: Cannot resolve "@tauri-apps/plugin-store" from "node_modules/@solid-primitives/storage/dist/index.js" and externals are not allowed! Apr 23, 2024
@atk
Copy link
Member

atk commented Apr 23, 2024

Thanks for the information. I'll have a look.

@atk
Copy link
Member

atk commented Apr 23, 2024

I cannot reproduce this, unfortunately. Are you using solid-start inside a tauri-v2 app? In that case, you need to install @tauri-apps/plugin-store. Otherwise, there should be no issue.

@FlatMapIO
Copy link
Author

I created a reproduction app, and I found that problems only occur when the vinxin preset is set to cloudflare-module.

@atk
Copy link
Member

atk commented Apr 23, 2024

Ah, it could be that the cloudflare present attempts to package even potential dependencies like this one. Not sure how to address this. @davedbase, @thetarnav any ideas? If not, we could move the tauri-related primitives to a storage/tauri subfolder so the main module can be included without referencing it, but I would like to not need this slightly inconvenient solution if possible.

@thetarnav
Copy link
Member

I’m not a fan of any external dependencies too be honest, but if they are necessary a submodule sounds good, they need to be separated.

@atk
Copy link
Member

atk commented Apr 26, 2024

Here we go: #621

@atk atk closed this as completed Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants