Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<html lang="en"> support #6

Open
millette opened this issue Jan 6, 2022 · 3 comments
Open

<html lang="en"> support #6

millette opened this issue Jan 6, 2022 · 3 comments

Comments

@millette
Copy link
Contributor

millette commented Jan 6, 2022

I'd like to specify the page language (SSR or not) but it looks like <html lang...> can only be hardcoded in index.html.

I had a look at https://github.com/solidjs/solid-site/ and I don't see support for that feature either.

Support would be greatly appreciated but perhaps it should reside in another package, I'm not sure...
@BierDav
Copy link

BierDav commented Mar 19, 2024

We definitely need support for a way to change the lang of the html reactively

@jguddas
Copy link

jguddas commented Mar 19, 2024

You can do this, but it's not the most ergonomic.
https://github.com/solidjs/solid-site/pull/292/files

@BierDav
Copy link

BierDav commented Mar 19, 2024 •
edited
Loading

No that's not exactly what i need, because it doesn't support ssr. On page load the current lang will be fixed to a specific value

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@millette @jguddas @BierDav