Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript compilation errors and linting warning in Etch-A-Sketch example #513

Open
cjnix35 opened this issue Jan 21, 2024 · 0 comments
Open

Comments

@cjnix35
Copy link

cjnix35 commented Jan 21, 2024

I've encountered some issues with the Typescript compilation and a linting warning in the Etch-A-Sketch SolidJS example code. Here are the details:

  1. Typescript error: The type definition for the style attribute seems incorrect. The error message is:

    • Type '{ display: string; "grid-template-rows": string; "grid-template-columns": string; }' is not assignable to type 'string | CSSProperties | undefined'.
  2. Typescript error: The render function is receiving a null type argument which is not compatible with its expected parameter type. The error message is:

    • Argument of type 'HTMLElement | null' is not assignable to parameter of type 'MountableElement'.
  3. ESLint warning: The code has an empty div component which is not self-closing, raising a lint warning:

    • Empty components are self-closing.
    • This is a minor issue but could be improved for better code quality.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant