JSX types for SVG elements (SVGElementTags) wrongly use runtime DOM element types instead of attributes

[ymeine]

Describe the bug

As part of an SVG element I was building with solid, I wanted to use an <feDropShadow> element like this:

<feDropShadow in='SourceGraphic' dx='0.2' dy='0.4' stdDeviation='0.2' />

only to find out that TypeScript was complaining about dx and dy having wrong types, expecting an object of the shape SVGAnimatedNumber.

And that's because feDropShadow is defined as Partial<SVGFEDropShadowElement> in interface SVGElementTags, in file solid-js/types/jsx.d.ts

The issue here is that SVGFEDropShadowElement, defined in typescript/lib/lib.dom.d.ts, represents the runtime instance of the created element, not the input attributes type, which should define the inputs dx/dy I mentioned as numbers/strings (for an example, here's how it's defined in React: @types/react/index.d.ts).

Your Example Website or App

https://stackblitz.com/edit/solidjs-templates-xd2mqb?file=src%2FApp.tsx

Steps to Reproduce the Bug or Issue

Just write a solid component with JSX in TypeScript and try defining dx or dy with numbers or strings on a <feDropShadow> element: the tooling (IDE, compiler, etc.) will report an error.

Expected behavior

The type definition should accept numbers/strings and not an SVGAnimatedNumber object. But more importantly, all JSX SVG element types should be defined according to their input attributes, not to their corresponding runtime instance objects.

Screenshots or Videos

Platform

• solid version: 1.7.12

Additional context

No response

[ymeine]

That was so fast ❤️

By checking how this was resolved, I actually noticed two things:

• I hadn't even paid attention to the fact that the other elements were properly typed, and that I had just stumbled upon one of the rare occurrences not yet completed - I feel a bit sorry for "explaining" how the typing should be done instead
• I know now that the typings (and more) are developed in a separate package and repository

Sincere thanks for all the excellent work

[ryansolid]

Yeah no problem. The separate repo trips people up all the time and I was honestly surprised that slipped by, probably part of a PR I didn't check closely enough.