Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide transaction_id and source in try_void #4859

Merged
merged 1 commit into from
Jan 19, 2023

Conversation

kennyadsl
Copy link
Member

Summary

Ref #4843

The previous implementation was missing these fields, which might be useless for some implementations but there's no reason no to pass them along.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

  • I have written a thorough PR description.
  • I have kept my commits small and atomic.
  • I have used clear, explanatory commit messages.

The following are not always needed (cross them out if they are not):

  • I have added automated tests to cover my changes.
  • I have attached screenshots to demo visual changes.
  • I have opened a PR to update the guides.
  • I have updated the README to account for my changes.

@kennyadsl kennyadsl requested a review from a team as a code owner January 17, 2023 16:52
@kennyadsl kennyadsl self-assigned this Jan 17, 2023
@github-actions github-actions bot added the changelog:solidus_core Changes to the solidus_core gem label Jan 17, 2023
@codecov
Copy link

codecov bot commented Jan 17, 2023

Codecov Report

Merging #4859 (57625a5) into master (cdb4efc) will increase coverage by 0.84%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4859      +/-   ##
==========================================
+ Coverage   85.38%   86.22%   +0.84%     
==========================================
  Files         531      578      +47     
  Lines       13172    14674    +1502     
==========================================
+ Hits        11247    12653    +1406     
- Misses       1925     2021      +96     
Impacted Files Coverage Δ
core/app/models/spree/payment_method.rb 94.20% <100.00%> (ø)
.../controllers/spree/api/option_values_controller.rb 100.00% <0.00%> (ø)
api/lib/spree/api/testing_support/setup.rb 100.00% <0.00%> (ø)
...pp/controllers/spree/api/stock_items_controller.rb 96.15% <0.00%> (ø)
...p/controllers/spree/api/coupon_codes_controller.rb 100.00% <0.00%> (ø)
...ollers/spree/api/store_credit_events_controller.rb 80.00% <0.00%> (ø)
api/lib/spree/api/responders.rb 100.00% <0.00%> (ø)
api/lib/spree/api_configuration.rb 100.00% <0.00%> (ø)
...app/controllers/spree/api/properties_controller.rb 92.30% <0.00%> (ø)
api/app/controllers/spree/api/states_controller.rb 100.00% <0.00%> (ø)
... and 38 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kennyadsl kennyadsl added the type:enhancement Proposed or newly added feature label Jan 18, 2023
The previous implementation was missing these fields,
which might be useless for some implementations but there's
no reason no to pass them along.
@kennyadsl kennyadsl force-pushed the elia+kennyadsl/try-void-source branch from 2037cbf to 57625a5 Compare January 18, 2023 17:26
@kennyadsl kennyadsl merged commit 95d890e into master Jan 19, 2023
@kennyadsl kennyadsl deleted the elia+kennyadsl/try-void-source branch January 19, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:solidus_core Changes to the solidus_core gem type:enhancement Proposed or newly added feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants