Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should Spree::User inherit from Spree::Base #18

Closed
magnusvk opened this issue Aug 19, 2015 · 2 comments
Closed

Should Spree::User inherit from Spree::Base #18

magnusvk opened this issue Aug 19, 2015 · 2 comments

Comments

@magnusvk
Copy link
Contributor

Currently, it inherits directly from ActiveRecord::Base and thus doesn't get things like RansackableAttributes. Should it inherit from Spree::Base instead?
@magnusvk magnusvk changed the title Should Spree::User inherit from Spree::Base Should Spree::User inherit from Spree::Base Aug 19, 2015
@athal7
Copy link

athal7 commented Aug 20, 2015

I think that makes a lot of sense

@gmacdougall
Copy link
Member

Agreed

@magnusvk magnusvk mentioned this issue Aug 24, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@athal7 @magnusvk @gmacdougall