Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working with Kismet 2020 #1

Open
Geofferey opened this issue Sep 16, 2020 · 6 comments
Open

Not working with Kismet 2020 #1

Geofferey opened this issue Sep 16, 2020 · 6 comments

Comments

@Geofferey
Copy link

Seems to be broken again on the 2020 version of Kismet. Wish they'd stop breaking it.

@soliforte
Copy link
Owner

Dragorn is doing a lot of great work that makes kismet better overall, it's really on me for not keeping up with him, as I haven't updated this in over a year. I'll revisit soon.

@cybercdh
Copy link

Pretty simple fix in kestrel.js....need to update a couple of lines

in getDevs()

lat = devs[x]['kismet.device.base.location']['kismet.common.location.avg_loc']['kismet.common.location.geopoint'][0];
lon = devs[x]['kismet.device.base.location']['kismet.common.location.avg_loc']['kismet.common.location.geopoint'][1];

The index are wrong, should be:

lat = devs[x]['kismet.device.base.location']['kismet.common.location.avg_loc']['kismet.common.location.geopoint'][1];
lon = devs[x]['kismet.device.base.location']['kismet.common.location.avg_loc']['kismet.common.location.geopoint'][0];

and also in getOldDevs() change

lat = devs[x]['kismet.device.base.location']['kismet.common.location.avg_loc']['kismet.common.location.lat'];
lon = devs[x]['kismet.device.base.location']['kismet.common.location.avg_loc']['kismet.common.location.lon'];

to

lat = devs[x]['kismet.device.base.location']['kismet.common.location.avg_loc']['kismet.common.location.geopoint'][1];
lon = devs[x]['kismet.device.base.location']['kismet.common.location.avg_loc']['kismet.common.location.geopoint'][0];

@Geofferey
Copy link
Author

Geofferey commented Oct 22, 2020

@soliforte yeah that may have come off as rude, didn't mean to sound that way. Pretty sure the guy is responsible for the new web UI I love so much and all the fixes... I just really like your plugin as it is a perfect compliment to kismet.

@cybercdh
Awesome! Glad to see this. I might check out that edit soon. Wonder if it would be same for last 2019-12 version?

@soliforte
Copy link
Owner

@cybercdh Thanks for the update. I rolled those changes in. Also, dig your youtube content!

@Geofferey Should work now. I'll try and revisit this plugin soon and give it some much needed TLC.

@soliforte soliforte reopened this Oct 22, 2020
@soliforte
Copy link
Owner

Just meant to comment. Let me know if it works, then I'll close.

@cybercdh
Copy link

@soliforte cool, fix looks good to me nice one for resolving. I noticed you may want to also make the same updates in getCurrentLocation() just in case a user does in fact use that element (I notice it's not enabled by default).

Nice work on the plugin, impressive stuff. Glad you like the YT content 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants