New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trading one global for another #2

Open

edward-ellis opened this issue Mar 29, 2020 · 0 comments

edward-ellis commented Mar 29, 2020

In the Rails >> Setup documentation for ROM you say:

Accessing the global container directly is considered as a bad practice. The recommended way is to use a DI mechanism to inject specific ROM components as dependencies into your objects. See rom-rails-skeleton for an example of such setup.

However, it appears that you are only substituting the global singleton MyApp.instance for Rom.env. How is this not just another global container?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment