Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(DelegatedHttpGateway): allow top-level config setting/sharing #6414

Merged
merged 3 commits into from
May 5, 2022

Conversation

gunnar-solo
Copy link
Contributor

@gunnar-solo gunnar-solo commented May 5, 2022

Description

This PR expands on the functionality of DelegatedHttpGateway and MatchableHttpGateway. It allows for anscestry-level setting of TLS and HCM configuration. Phrased differently: configuration can now be set for a single DelegatedHttpGateway that will be propagated to all MatchableHttpGateways. Setting the preventChildOverrides flag specifies that parent config is to be prioritized over child. For example:

  • preventChildOverrides=false | {"parent":{"foo":"bar"}, "child":{"foo":"baz"}} --> {"foo":"baz"}
  • preventChildOverrides=true | {"parent":{"foo":"bar"}, "child":{"foo":"baz"}} --> {"foo":"bar"}

Context

This feature is intended to be useful to a multi-team gloo management environment. Picture a top-level, well-informed team managing a single DelegatedHttpGateway with a bunch of useful defaults. Then, individual teams/microservices manage their own MatchableHttpGateway(s)

Checklist:

  • I included a concise, user-facing changelog (for details, see https://github.com/solo-io/go-utils/tree/master/changelogutils) which references the issue that is resolved.
  • If I updated APIs (our protos) or helm values, I ran make -B install-go-tools generated-code to ensure there will be no code diff
  • I followed guidelines laid out in the Gloo Edge contribution guide
  • I opened a draft PR or added the work in progress label if my PR is not ready for review
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@gunnar-solo gunnar-solo requested a review from a team as a code owner May 5, 2022 12:20
@github-actions github-actions bot added the keep pr updated signals bulldozer to keep pr up to date with base branch label May 5, 2022
@gunnar-solo
Copy link
Contributor Author

/skip-changelog

re: backported feature

@soloio-bulldozer soloio-bulldozer bot merged commit 7c18dfa into v1.11.x May 5, 2022
@soloio-bulldozer soloio-bulldozer bot deleted the backport/11/gateway-config-lift branch May 5, 2022 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keep pr updated signals bulldozer to keep pr up to date with base branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants