feat(DelegatedHttpGateway): allow top-level config setting/sharing #6414
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR expands on the functionality of
DelegatedHttpGateway
andMatchableHttpGateway
. It allows for anscestry-level setting of TLS and HCM configuration. Phrased differently: configuration can now be set for a singleDelegatedHttpGateway
that will be propagated to allMatchableHttpGateway
s. Setting thepreventChildOverrides
flag specifies that parent config is to be prioritized over child. For example:preventChildOverrides=false | {"parent":{"foo":"bar"}, "child":{"foo":"baz"}} --> {"foo":"baz"}
preventChildOverrides=true | {"parent":{"foo":"bar"}, "child":{"foo":"baz"}} --> {"foo":"bar"}
Context
This feature is intended to be useful to a multi-team gloo management environment. Picture a top-level, well-informed team managing a single
DelegatedHttpGateway
with a bunch of useful defaults. Then, individual teams/microservices manage their ownMatchableHttpGateway
(s)Checklist:
make -B install-go-tools generated-code
to ensure there will be no code diff