fix(hcm): made all fields/subfields nullable #7041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
keep pr updated
gunnar-solo
force-pushed
the
hcm-0-value-overrides
branch
from
5d2c7d9
to
6809556
Compare
gunnar-solo
removed
the
keep pr updated
gunnar-solo
force-pushed
the
hcm-0-value-overrides
branch
from
6809556
to
808ad31
Compare
gunnar-solo
force-pushed
the
hcm-0-value-overrides
branch
4 times, most recently
from
b18144c
to
0fa6b39
Compare
gunnar-solo
added
the
keep pr updated
gunnar-solo
force-pushed
the
hcm-0-value-overrides
branch
from
65fccc8
to
9115808
Compare
|
Issues linked to changelog: |
|
Visit the preview URL for this PR (updated for commit 3d42e13): https://gloo-edge--pr7041-hcm-0-value-override-drn4jxxd.web.app (expires Tue, 06 Sep 2022 14:46:33 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
gunnar-solo
force-pushed
the
hcm-0-value-overrides
branch
from
9115808
to
bcaeb1b
Compare
gunnar-solo
changed the title
gunnar-solo
added a commit
that referenced
this pull request
Sep 2, 2022
Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com>
soloio-bulldozer bot
added a commit
that referenced
this pull request
Sep 2, 2022
* fix(hcm): made all fields/subfields nullable (#7041) Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com> * fix(hcm): 2nd passthrough of subfields to make nullable special care taken with `Duration` and `ResourceRef` object types. Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Users utilizing the previously-released #6414, users were able to provide hcm configuration to a DelegatedHttpGateway and have it be inherited by any number of matchable http gateways. This "mostly worked", but had a pretty noticeable bug: non-nullable fields could not be overridden with a zero value.
For example:
This PR resolves said issue by recursively tracking down and eliminating non-nullable fields across hcm.proto. It also then goes about resolving the misc. type changes necessary for code to compile/tests to pass.
Checklist:
make -B install-go-tools generated-codeto ensure there will be no code diff