We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
in validator_test.go we have:
validator_test.go
FDescribeTable("label workflow cases", labelWorkflow, Entry("initial rc", "v0.20.5", "v1.0.0-rc1", validBreakingChangelog, noValidationSettingsExist), Entry("initial rc relaxed", "v0.20.5", "v1.0.0-rc1", validBreakingChangelog, relaxedValidationSettingsExists), Entry("incrementing rc", "v1.0.0-rc1", "v1.0.0-rc2", validBreakingChangelog, noValidationSettingsExist), Entry("incrementing rc relaxed", "v1.0.0-rc1", "v1.0.0-rc2", validBreakingChangelog, relaxedValidationSettingsExists), Entry("stable release after rc for 1.0", "v1.0.0-rc2", "v1.0.0", validStableReleaseChangelog, noValidationSettingsExist), Entry("stable release after rc for 1.0 relaxed", "v1.0.0-rc2", "v1.0.0", validStableReleaseChangelog, relaxedValidationSettingsExists), Entry("stable release after rc for 1.1", "v1.1.0-rc2", "v1.1.0", validStableReleaseChangelog, noValidationSettingsExist), Entry("stable release after rc for 1.1 relaxed", "v1.1.0-rc2", "v1.1.0", validStableReleaseChangelog, relaxedValidationSettingsExists), Entry("initial rc after for 1.1", "v1.0.0", "v1.1.0-rc1", validNewFeatureChangelog, noValidationSettingsExist), Entry("initial rc after for 1.1 relaxed", "v1.0.0", "v1.1.0-rc1", validNewFeatureChangelog, relaxedValidationSettingsExists), Entry("foo3 to bar1", "v1.0.0-foo3", "v1.0.0-bar1", validNewFeatureChangelog, noValidationSettingsExist), Entry("foo3 to bar1 relaxed", "v1.0.0-foo3", "v1.0.0-bar1", validNewFeatureChangelog, relaxedValidationSettingsExists), Entry("foo1 to bar1", "v1.0.0-foo1", "v1.0.0-bar1", validNewFeatureChangelog, noValidationSettingsExist), Entry("foo1 to bar1 relaxed", "v1.0.0-foo1", "v1.0.0-bar1", validNewFeatureChangelog, relaxedValidationSettingsExists), Entry("foo1 to bar3", "v1.0.0-foo1", "v1.0.0-bar3", validNewFeatureChangelog, noValidationSettingsExist), Entry("foo1 to bar3 relaxed", "v1.0.0-foo1", "v1.0.0-bar3", validNewFeatureChangelog, relaxedValidationSettingsExists), Entry("foo1 to next minor", "v1.1.0-foo1", "v1.1.0", validNewFeatureChangelog, noValidationSettingsExist), Entry("foo1 to next minor relaxed", "v1.1.0-foo1", "v1.1.0", validNewFeatureChangelog, relaxedValidationSettingsExists)) })
which should pass, and does not, because 1.1.0-beta1 -> 1.1.0 is marked as an invalid changelog change.
this should pass.
in the immediate term, we unblocked the release by relaxing semver validation to switch the version and then adding it back after relase.
cc @marcogschmidt
The text was updated successfully, but these errors were encountered:
kdorosh
Successfully merging a pull request may close this issue.
in
validator_test.go
we have:which should pass, and does not, because 1.1.0-beta1 -> 1.1.0 is marked as an invalid changelog change.
this should pass.
in the immediate term, we unblocked the release by relaxing semver validation to switch the version and then adding it back after relase.
cc @marcogschmidt
The text was updated successfully, but these errors were encountered: