Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing show-action for in-place editing #54

Closed
jumhh opened this issue Mar 4, 2015 · 1 comment
Closed

Missing show-action for in-place editing #54

jumhh opened this issue Mar 4, 2015 · 1 comment
Assignees
@ljachymczyk

Comments

@jumhh
Copy link

jumhh commented Mar 4, 2015

I tried to add a show-action that works in-place, but I just saw, that there are several places, where I have to dig into your code:

  • a new show.js.erb
  • additions in smart_listing.coffee.erb
  • adding :showto smart_listing_item in helpers/smart_listing/helper.rb
  • etc...
    I would appreciate just having it in your next release. Should be really simple for you :-)

The functional need is simple: I have got a lot of more fields in a data entity than I will show as table columns.
ljachymczyk added a commit that referenced this issue Oct 9, 2015
@ljachymczyk
Update readme to include info about 'show' item action. #54
83db588
@ljachymczyk ljachymczyk self-assigned this Oct 9, 2015
@ljachymczyk
Copy link
Member

I'm not sure if I understand correctly, but there's already a built-in show action. But you are right, it wasn't mentioned in the README. I've added it there already.

vvondra added a commit to vvondra/smart_listing that referenced this issue Mar 22, 2018
@vvondra
Merge commit 'e499361'
586e5d9 
* commit 'e499361':
  Rails 5 support and Kaminari update
  Fix some rspecs bugs.
  Fix handling of nested controls params.
  Fix smart_listing helper method 'render_list'
  Update readme to include info about 'show' item action. Sology#54
  Add ability to pass locals to list view. Closes Sology#70
  New trigger event.
  Better handling of nested controls params
  Fix controls form not fading out the list. Sology#51
  Handle different modes of new item insertion
  Config now includes element templates.
  Version bump.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ljachymczyk ljachymczyk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ljachymczyk @jumhh