Ensure compatibility with python-fido2 0.8 (fixes #49) #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is the new blessed way, yes? |
|
As I wrote in #49, Python is not my primary programming language. However, I tried to make the same adjustments as the authors of the library in the respective commit (Yubico/python-fido2@4c48977). Please accept one of the pull requests and create a new release. Right now this package is broken for distributions shipping the new fido2 library, like Arch. |
|
Had some minor nits:
I did add these and published an update on PyPI. Thanks for your contribution! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Timeout has been removed from python-fido2 in version 0.8.