More refactoring to image import controller #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@soltysh i did some more cleanup in the code to make this controller more readable for humans... |
|
Not needed, this is entirely re-written in openshift#13835. |
|
@soltysh i based it on top of that PR (saving time making comments ;-) |
|
OMG, I'm blind, now I've noticed it's against my branch. Sorry ;) |
soltysh
pushed a commit
that referenced
this pull request
Jun 16, 2017
Refactor controller initialization (round #3)
soltysh
pushed a commit
that referenced
this pull request
Jun 29, 2017
Automatic merge from submit-queue (batch tested with PRs 3, 4) more work for prow
soltysh
pushed a commit
that referenced
this pull request
Oct 18, 2017
Suppress Strict-Transport-Security header for http requests It is only emitted for https. bug 1501133 https://bugzilla.redhat.com/show_bug.cgi?id=1501133 see comment #3
soltysh
pushed a commit
that referenced
this pull request
Oct 18, 2017
Automatic merge from submit-queue (batch tested with PRs 16888, 16911, 16913, 16904). Router - hsts for "edge" or "reencrypt" only Suppress Strict-Transport-Security header for http requests It is only emitted for https. bug 1501133 https://bugzilla.redhat.com/show_bug.cgi?id=1501133 see comment #3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.