Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SolveError to include more error messages #333

Closed
jsh2134 opened this issue Apr 24, 2020 · 0 comments · Fixed by #335
Closed

Update SolveError to include more error messages #333

jsh2134 opened this issue Apr 24, 2020 · 0 comments · Fixed by #335

Comments

@jsh2134
Copy link
Contributor

jsh2134 commented Apr 24, 2020

Errors can sometimes not show useful information

See https://github.com/solvebio/solvebio-python/blob/master/solvebio/errors.py#L62

There are other keys that exist in some errors that are not detail or non_field_errors. For instance 'manifest' is a key thrown in a manifest error. If uploading using a manifest with invalid file format, it includes a very useful error message that gets lost. Is there harm in just handling any error key here? (handle keys with list values and those without)

@jsh2134 jsh2134 closed this as completed Apr 24, 2020
@jsh2134 jsh2134 added this to the Release v2.12.0 milestone Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant