Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is lockbox still looking for maintainers? I'd like to volunteer as a collaborator. #26

Closed
greatwolf opened this issue Feb 25, 2020 · 5 comments

Comments

@greatwolf
Copy link
Collaborator

greatwolf commented Feb 25, 2020

There's some refactors, improvements and optimizations I'd like to contribute to upstream. Also looking to implement sha2_384 and sha2_512 to complement lockbox as well as fixing up and merging in tst's Salsa20 implementation.

@tst2005
Copy link
Collaborator

tst2005 commented Feb 25, 2020

The salsa20 code is not my work. I just found it. It is the code and repository for mrogaski.

I also found some lockbox-like project :

I dreams of an universal unified crypto lib...

@greatwolf
Copy link
Collaborator Author

kewl, yea I came across those 2 libraries too. plc looks quite promising and I like the way the code looks.

lua-hashings I also looked at, really didn't like the design of it. Two major issues with it:

  • use of metatables to emulate 64-bit bit operations and manipulation
  • uses strings to remove input already processed.

The first one means on every single bitwise operation, it is going to trigger a meta event. The second one means a lot of string copying around after every hash round iteration since Lua strings are interned and immutable.

Both of these things taken together means lua-hashing's performance is quadratic-like dog slow especially as input gets larger. I am not being obtuse when I say lua-hashing is 50-100x slower than alternative lua implementations -- it's that bad. Certainly not something I would use in production.

@somesocks
Copy link
Owner

somesocks commented Feb 28, 2020

Hi @greatwolf @tst2005, I've sent you both an invitation to become collaborators =)

I haven't forgotten about this package, I'm afraid its just been a busy few years for me. Let me know if you'd like to publish a new rocks version as well, and I'll help out there

@greatwolf
Copy link
Collaborator Author

Will do. Thank you 👍

@greatwolf
Copy link
Collaborator Author

While you're still here, can you enable travis-ci for lua-lockbox under your account? It shouldn't take more than a couple of clicks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants