-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Movie Support #298
Comments
Comment from anon1265 on Trello: Can you please make it work like moviegrabber http://sourceforge.net/projects/moviegrabber |
Comment from simonk83 on Trello: CouchPotato allows that as well. So maybe implement that option, but don't make it work solely like that as it'd be useless for a lot of people. I like to be picky in what I watch. |
Comment from robinroy on Trello: A great idea would be to download movies based on an IMDB watchlist. CouchPotato sort of does this, but it never worked very well for me... sometimes downloading the wrong movie because of a similar name. This should be simple if the match is done with the IMDB id instead of movie title. |
Comment from toby9999 on Trello: This definitely needs to be done :-) While CP is pretty ok, I struggle with a bunch of annoying little bugs almost every day (I have to rename files and manually hack the database). On the other hand, NZBDrone just works (ie I _NEVER_ have to fix anything!!). So for me, just having the same solid reliable coding as already exists for TV would be totally awesome. And of course, as others have said, having one app to do both TV and Movies would be brilliant. So that's a huge +1 from me, and thanks very much to Markus101 for everything so far :-) |
Comment from simonk83 on Trello: Just out of interest, what bugs do you see? It's very very solid for me, I just have issues with it searching for movies that it thinks are too early, but that's tricky to solve. |
Comment from robinroy on Trello: For me the most annoying thing with CP is this:
This happens a lot with sequels or movies that aren't out yet, but which have a title similar to another movie that came out a year or two before. For example, it would download "The Amazing Spider-Man" when the movie in my watch list was "The Amazing Spider-Man 2". Because of this, I am now using Movie Grabber. The only thing I don't like about MG is that I can't add an imdb watchlist. |
Comment from simonk83 on Trello: Interesting. I've honestly never had that happen once since I started using it (years). I'm going to say it's most likely your config, and possibly just crappy indexers... Anyway this isn't the place to discuss it, but start a thread on the CP forums and it should get worked out. |
Comment from staalvreter on Trello: @simon I have the same "issues" discribed below. The work thats beeing done here is quite impressive :). Much updates. Keep it up!! |
Comment from mvds74 on Trello: I don't recognize the issues being described here at all. But we are not discussing CP here, but NzbDrone ;) And movie support would be awesome! And importing from imdb, rottentomatoes, trakt, moviemeter, kinepolis and possibly other sites would be very (VERY!) handy indeed! |
Comment from simonk83 on Trello: markus, when you guys decide to get back to this, maybe have a think about a way to deal with movies that are "out" sooner than expected. CP has issues with this in that (I believe) it checks a list of expected DVD release dates from somewhere, and based on that info it won't search for movies prior to that date. This is good in that it greatly reduces API hits to indexers (and also fakes), but it's just not reliable enough. Often movies are "out" earlier than expected, so they're not searched for and grabbed. I don't really have a better solution in mind just yet, but it's something I've been thinking about for a while. A reliable solution here would be super handy. |
Comment from bcsteeve on Trello: @simonk83 what you're describing is an option already in CP... but they caution that it results in a LOT of false hits. And it does, because frankly there are a ton of [losers] who "release" a movie early to look cool but its a bogus release. You really want to be downloading all that junk in the hopes of getting the ~0% that are legit early releases? I really don't know what makes NZB so reliable with TV vs. CP which is so hit and miss. One thing we have to consider is that it really is less about the organization software and perhaps more about the sources. Maybe TV sources are just more reliable? Early on I really was gung-ho about adding movie support to NZB... but as I've gotten more experienced with it I start to wonder "why?" Unlike TV, where there are multiple seasons with multiple episodes, and therefore something to actually organize... movies are 1 for 1. That is, 1 movie has 1 download (ideally, if garbage didn't exist). So it starts to be "what's the point"? Its easier (way easier) to just manually search for the movie of interest in your indexer and manually download it. Granted, CP has some cool features but, to me, they aren't even remotely worth the hassled generated by the garbage downloads. If it is just a crappy algorithm and if nzb can do it better, then GREAT! But if its more about the sources, then I say stick to manual downloading. |
Comment from simonk83 on Trello: @bcsteeve, I know there's an option to turn it off and search for everything, but that's not what I'm after, because that doesn't work properly either (you just end up with fakes, and hundreds of API hits every day) ;) We need a solution that's a mix of the two, so it reliably grabs new releases around the time they're supposed to be out, without having to search for everything every time. CP's solution works 80% of the time. What we need is a new solution that works closer to 100% of the time. As the movie support hasn't really been started yet, now's the time to start thinking of solutions so it can be built that way from the ground up. |
Comment from simonk83 on Trello: Thinking about it some more, and considering the integration with Trakt already. When a movie is "out" it will inevitably start popping up on Trakt as more and more people grab and watch it. I wonder if we could check trakt (rather than indexers) before a movies release date and if it's showing on there (like more than 1 person has watched it or whatever), start to search for it in Drone? Still not ideal as with the rate of takedowns nowadays, the file could be gone before we even get to it, but something to think about. |
Comment from joelkaberg on Trello: @simonk83 Better check preDB's instead, http://predb.me/ Check if an release exist on any of the above, if it does: it's the real deal |
Comment from simonk83 on Trello: OH of course, that makes a lot more sense. I wonder why CP doesn't just do that... |
Comment from joelkaberg on Trello: @simonk83 it does... |
Comment from simonk83 on Trello: Interesting. It doesn't work in that case ;) I quite often get the "too early to search for this title" message in the logs and have to grab things manually. This wouldn't happen if it was checking with a predb. |
Comment from jay150 on Trello: MUST HAVE THIS! But seriously, I've been itching for movie support ever since I discovered the beauty of NzbDrone. The interface and usability is unmatched. Is there any chance some impatient members could get an early look at the "in development" version and help test? :) |
Comment from derekhighet on Trello: @Jay150 cards in the "In Progress" or "In Develop" tier are features that are currently being developed. Movie Support isn't yet, mainly just being discussed. |
Comment from guidojurriens on Trello: @Jay150 There is an option to test out development builds. They can be unstable though so be warned about that. The instructions for the development build are in the forums. |
Comment from taloth on Trello: No, there is no movie support whatsoever. (not on a branch either) |
Comment from jay150 on Trello: @Taloth Haha, fair enough, fair enough. I'm just impatient. As a developer, I know these things take time. If your current work is any indication, I know you guys will do good work with it in time. Really appreciate all the effort you guys put into this! |
Comment from chrisschnobb on Trello: Im supper stoked for this. I hate using CouchPotato and NzbDrone has really shown me a new meaning to Usenet and automation. I really hope movie support comes soon! |
Comment from markus101 on Trello: I realize this is the most voted feature (by a large margin), but in terms of time and effort (we don't have the time to dedicate to it), we're not doing anyone a favour by keeping it as high priority. I'm moving it back down. |
Comment from joepayton2 on Trello: I would love to see a all in one Internet PVR and this looks like it could really be it. Add torrent and nzb clients built in and it would be one stop shop. But movies would be plenty. |
Comment from tymixon on Trello: @joepayton2 I think having the dwnload clients be sep is a better solution. One app to find it, another to handle downloads & repair/decompression. That way you can use what you like. :) |
Comment from joepayton2 on Trello: To be totaly honest I agree. There are better/different options for different systems. Still. It would be nice to have an all on one. |
Comment from karmapolice1 on Trello: This idea is actively in development over at CouchPotato (adding TV to CP which already does movies)... I might be wrong, but my suspicion is that the first of the big 3 (SickBeard, CouchPotato, Sonarr) to handle TV and Movie functionality will be a HUGE winner and could well destroy whomever is in 3rd place in terms of user-base (which would be Sonarr currently)... The only reason I could see this not happening is that CP is so poor at what they do implement it might be just horrible enough to keep people from switching... That said... might be worth a re-eval on priority for this one in light of CP going down this road currently (they have a fork setup in git with very frequent committing going on). |
Comment from markus101 on Trello: @karmapolice1 CP started TV support last year and ended up not finalizing it, looks like they restarted development on it again. Its been almost 2 years since we started v2 and there is still tons that we could do in the realm of TV alone, this stuff can't be thrown together over night. We realize this is the number one voted feature and has been since it will added, but we feel there is more we can do in the world of do one thing well before we take on movies. |
Comment from karmapolice1 on Trello: @markus101 sounds good, just wanted to check in on it considering the revived interest over at CP in this. |
If there's a groundswell for this I can take a small piece of the puzzle, unfortunately I don't have the time I did when I first offered. @fedoranimus I would highly recommend not worrying about the UI, atm. IF this takes off it will spend a long time segregated in a branch. It would be best not to worry about merging the aesthetics of what could be a moving target. Let me know if there's movement and a need for a few hours a week. |
@rcketscientist Understood. It would be prudent, however, to plan how we want things to work before sinking too much time. (Other than things like RSS parsing) @geogolem I'm not sure if the Profile section can be used as is. Movies have slightly different qualities than Series do. |
i did a little investigation into this - but didnt make a lot of progress in trying to figure out how sonarr does things. Instead I forked couchpotato and started playing aroudn with it. Its really not that bad.. The only thing lacking is the GUI.. and its been so long since they cut a release. I added some code for things like. displaying ETA's of movies (release dates etc). displaying whether the movie is currently available in netflix. and giving the user the option to have it skip searching/downloading movies that are available in netflix.. only search for titles available in netflix (and user could manually download them). or just treat titles available in netflix just like any other title.. Perhaps out efforts would be better applied at improving the GUI and featureset of couchpotato. Its functionality really doesn't seem to be that bad... since i have been messing around with it recently (i.e. searching and downloading etc).. Sonarr by far has the best GUI and seems to be the most robust out of sickrage, couchpotato, headphones etc. Sonarr is also built in C# -- couchpotato is python.. so IMO couchpotato is alot easier to jump into.. but thats just me.. Maybe people could take alook over at the couchpotato repo and see if we might be able to spruce it up instead? |
Fully disagree. CP's GUI is fine (maybe you don't have latest?). It is the flawed logic. CP caused so many headaches for me. Sonarr just works. Now, maybe it isn't the client's fault... maybe it is the releases themselves? Maybe for some reason TV show releases are just better? SO many times, CP would grab the wrong language, the wrong subs... even the wrong movie. It was ONLY good for managing my library (but Plex is better) and for manually d/l titles (but I can do that on any indexer). To me, the whole point of something like CP is that I can hear about XYZ coming to theaters and I can add it.. .and one day it would magically appear in Plex. That happens for TV. That just doesn't happen for movies. I'd get #*(@ cam despite specifications. I'd get some random movie instead of what I asked for. Whatever, it just didn't work. I was MUCH better off ditching it and using Indexer (grab) + Filebot (rename) + Plex (organize). |
I concur with @bcsteeve. I've had nothing but problems in CP, but Sonarr is a very solid piece of software. I also believe the longevity of Sonarr depends not only on staying extremely functional for TV Series, but also adding support for Movies as well. The UI for CP is confusing; Sonarr's is pretty good on the other hand. It could do with a redesign, but let's not get ahead of ourselves. ;-) Sonarr's UI is very understandable as it stands. |
One thing I'd like to add: whenever I complain about CP doing weird things, CP supporters scoff and tell me its because my settings aren't tweaked right (or whatever). Sonarr's settings are just as confusing. The difference? Out of the box, Sonarr works. CP needs to be "tweaked" - apparently beyond my tweaking abilities. I've had very few issues with Sonarr and a quick question on the forum gets me the settings I need to adjust. With CP it is lots of issues with obscure resolutions. So it goes beyond UI. It speaks to the fundamentals. |
I'm a software developer, I do this for a living, and I know Python (CP) and C#(Sonarr). I've looked at both codebases and the Sonarr codebase looks very professional. It's by no means perfect (I'm certainly not a big fan of C#) but the CP codebase is a mess. Though it's C# based (that comes with some disadvantages), Sonarr has a very solid foundation for adding a lot more functionality - CP doesn't. |
C# always did seem like a strange choice (in my opinion) for what essentially boils down to a web service. But good code is good code. |
Many web services are written in C#, and many standalone client/server applications. .Net is a very powerful technology stack and the Sonarr code is quite elegant (if not a big confusing to jump into at first). We're getting off topic however. Let's bring it back to what needs to be done in the short and long term to start supporting movies in Sonarr. |
@bcsteeve : I had the same opinion and experience with CP as you until recently I set my global filters this is in the "settings--> categories" you can set several comma separated strings of words: preferred: Words that give the releases a higher score. I have my preferred field set; proper, repack, 2HD, AAF, ADIT, ALLiANCE, AMIABLE, AN0NYM0US, ASAP, BAJSKORV, basp, BATV. BLOW, BIRD, BRMP, BS, C4TV, CBGB, CHD, CINEFILE, Crimejoep, CRiMSON, CRiSC, CtrlHD, Cyphanix, CyTSuNee, DAA, DERIDDER, DiFFRENT, DIMENSION, DON, ECI, EbP, EZTV, FANDANGO, FELONY, FoV, FQM, FTV. GECKOS, GRYM, hannes3, HAiDEAF, HDEX, hdmanicas, IFH, IGUANA, IMMERSE, JAPHSON, KILLERS, KINGS, KRAVE, LEGiON, LOL, METIS, MiLLENiUM, MOOVEE, NODLABS, NoTV NTb, PSYCHD, PublicHD, QoQ, Q.o.Q., QRUS, QUSTOM, RARBG, RARTV, REFINED, REMARKABLE, RightSiZE, ROVERS, SbR, SECTOR7, SimplyReleases, Simply & Releases & Toppers, SHiTSoNy, SINNERS, SONIDO, SNOW, SPARKS, SRT, SRT & *, STRATOS, TayTO, TheKnight, TRIPS, VEDETT, VETO, VietHD, WiKi, W4F, XOR, yestv, YFN required: mkv, x264, 720, 720p, 1080, 1080p, AC3, DTS, ignored:german, dutch, french, truefrench, danish, swedish, spanish, italian, korean, dubbed, swesub, korsub, dksubs, vain, CAM, CAMRIP, BDSCR, DDC, DVDSCR, DVDSCREENER, HDCAM, HDTS, PDVD, SCR, SCREENER, TC, TELECINE, TELESYNC, .TS., -TS-, TS, WEBCAP, WEB&Cap, WEB & CAP, WEB-Cap, WEBRIP, WEB&Rip, WEB & Rip, WEB-Rip, WORKPRINT, WP, XviD, exe, VLC, danish, dksubs, dubbed, french, FRENCH, german, GERMAN, ita, italian, ITALIAN, korean, korsub, spanish, SPANISH, SPANiSH, swedish, swesub, truefrench, turkish, 2HB, -AFG, aMMo, AVIGUY, ChameE, COMPULSION, COOL, core2hd, -DDLV, [G2G], GiuseppeTnT, hdchina, HebSubs, hebsubs, Mandarin, Micromkv, -mSD, -msd, MrLss, NOHATE, reenc, -REenCO, -RP, VOSTFR, vostfr, vain, www.Speed.cd, YIFY, ZER0COOL, [AHSH], [Deadfish], [DHn], [DsunS], [FuniRip], [M-L] I think that handles the majority of garbage... Anyway - i dont want to take this too far off subject.. Sonarr is amazing.. and I still would love for movieSupport to be added - and I dont mind helping out if I can. I also am a software dev - I just personally havent had much experience with c# and .net. so I can still contribute - just not as easy to get started as say CP which is written in python... for me at least. |
While I very much appreciate you sharing your settings... it is exceedingly ridiculous that the end user would need to input all that to get a release. |
@bcsteeve : I agree with you - however, there are added benefits of having the user be able to specify those things - since then the user can decide what they prefer, want to ignore or require. perhaps the way couchpotato does it with allowing such a set of user specified strings is actually a good thing, but the issue is that couchpotato has no default/initial or reccomended settings for those fields. Anyway, I am not disputing the desire to have sonarr or a fork of sonarr handle movies in a fashion similar to how well it beautifully and elegantly handles tv shows. I was just delighted to find out couchpotato wasn't quite as bad as I had previously thought. It comes down to development effort - I would rather people work on/polish couch potato to improve its GUI etc. than to have it remain the same and a sonarr like movie functionality never come to fruition. I think discussing couchpotato is useful in this discussion since couchpotato is the best existing example of the desired use-case. The issue is we want something like couchpotato but without all its shortcomings and with the robustness/elegance of sonarr. |
Just wanted to throw in my /2c on the CP vs S debate. Have looked into refining/improving CP a few times over the years, and the code seems all over the place, somewhat hacky, and overall too hard to logically reason what making a change might impact on. I haven't looked at the S code base, but I feel like it's probably stronger. I feel like if you're going to compare dev effort required, I would be comparing a full CP rewrite against adding movies to S. |
Folks are off topic on this thread. Please keep it to posts about furthering a development process in Sonarr with regard to movies. Comparisons and how to fix CP are of little value in organizing the manpower or getting the ball rolling. I stayed on this thread since I anticipate helping at some point and I'd rather not unsubscribe due to 8 daily posts that don't further the goals. There's plenty of places to take a CP chat. |
@rcketscientist : I totally disagree with you - discussing couchpotato is directly related to implementing movie support in sonarr. I dont think discussing couchpotato, its shortcomings or potential is off topic at all, when discussing movie support in sonarr. As a matter of fact - it is directly related to the topic. In any case - im not interested in forcing a discussion on couchpotato where it is not wanted - i just dont think that comments about couchpotato is totally unrelated to sonarr movie support. I'll try to avoid bringing up couchpotato in this thread from now on. Its kind of like a "feasibility analysis" or something .. and just taking note of what else is out there. |
FWIW I originally posted here because of my dissapointment with the CP experience in general and how much different it was compared to my experience with Sonarr. Snatching wrong copies/resolutions - labelling movies as TV shows and not downloading them - unable to post process correctly as well as a mountain of other minor bugs was just some of the reasons for revisiting the possibility with Sonarr. Now from the experts out there it sounds like Sonarr's code in C# is strong. There is nothing particularly wrong with CP's GUI it's more the fact that it doesn't do what it's supposed to whereas Sonarr does. This to me (a layman) sounds like Sonarr is built better, for example if you look at a Camaro is it really a Camaro if it doesn't have a ZL1 Chev under the hood? To me CP is a Camaro with a Kia Rio engine under the bonnet, it looks nice but it's missing 7 cylinders.. I feel like if people wanted to ressurect CP they would be posting requests in droves over on the CP forums - but they aren't - those forums are dead with zero dev support. Maybe we need to start a thread on the Sonarr forums to discuss this further. I'll do that soon and start by making a list of people that have discussed their willingness to participate and what code they have skill in. Then we can allow the people that know how to design and build an engine (so-to-speak) decide on the best option? Once that is decided then they can move onto the next stage. How does that sound to everyone? There is no doubt we all agree on one thing and that is, that something needs to happen on this subject and discussing it further here is not progressing the idea ahead.. |
@adz7 I fully support this and offer my skills & time. Edit: Please submit the forum thread link here when it's created. |
@adz7 I can help as well. |
Hey guys, let's consolidate the discussion a bit. I'm fine with discussing general ideas with regard to movie support, but lets not drift too far to comparisons. First off, let me emphasis why the Sonarr team hasn't involved themselves in movie support. Our primary concern is our inability to maintain and support it. Believe it or not, but support takes up the bulk of our time. I've always said that movies is a totally different animal compared to tv. There's much less standardization in the release names, and far more tags to interpret. What is the primary usecase for automating movies? It's certainly different than tv, basically one-offs. To get back to usecase. I don't want it to download automatically. I just want it to filter the releases, notify me if a movie with acceptable quality comes out and then ask me what to get. And if I don't respond it time, download the best release and put it in escrow instead of blindly importing & renaming it. Anyway, please make sure you got an idea about what you want to automate, what features the user really needs/wants. You might find that users don't want it automated to the extend that we do for tv, and that could be the way to 'do it right'. PS: Yes, starting a thread on the forum might be a good idea. |
What they do wrong: by default, hide (or at least pre-fill) all the crazy settings that "just makes it work". Incorrect grabs is the #1 thing it screws up on. I mean... really, more than anything, I just want to not have to remember movies I intend to d/l at some unknown point in the future and to happen to check it close to (but not before) release. I realize there may be services out there that keep track of that sort of thing, but I'd like it all done in one place. Whether it auto-downloads or asks me first... I suppose I don't care. Auto would be my preference if I had some comfort that it would get it right! |
For tv shows Sonarr is very strict on the names. So if a group releases a show under a different name (year suffix, country suffic, stuff like that) it needs a naming exception so Sonarr knows how to identify the release. See https://forums.sonarr.tv/t/scene-naming-tvdb-naming-conflicts/137. I'd love to hear what the others say. |
Not sure if any of you have seen this. Just found it https://radarr.video/ someone has done an entire fork of Sonarr for movies. |
This is awesome, I've been AWOL over the holidays but to come back and see my original comment snowball and generate something like this is amazing. Great work everyone - and I'm so happy they took the name Radarr and ran with it!! Fkn awesome! :D PS. @fedoranimus thanks for creating the forum discussion I know I said I would but have been crazy busy with December/Jan - I'm back now and it's very satisfying to see a team forming and you guys getting the support you need to build Radarr, great stuff. |
@bassrock @adz7 Yeah, Radarr is us. Come join the Discord server! |
Closed since Radarr has been in development long enough and has been considered by many as an great solution. |
We would all like some kind of Movie support, however it is a very complicated matter to properly implement it in Sonarr. We rather not have it at all, than have it hacked in and barely working.
This feature will need to be designed with its own architecture, hundreds if not thousands of unit/integration tests, with hundreds of man hours involved.
We would need at least 2 additional developers to even consider this feature.
Sadly this means that, despite the number of votes, this feature is pretty much the last item on our todo-list.
The text was updated successfully, but these errors were encountered: