BlockHelper::includeJavascripts $media argument

[dbu]

what is the $media argument on BlockHelper::includeJavascripts for?
https://github.com/sonata-project/SonataBlockBundle/blob/master/Templating/Helper/BlockHelper.php#L106

i guess it was added by accident but now can't be removed anymore as it would be a BC break. would be good to document those arguments to make things more understandable.

[rande]

@dbu you are right ... yesterday I add some documentation 9cf0804

Not sure it is enough ...

[dbu]

funny you where working on this yesterday. stumbled on it while cleaning out some very old backlog items on the cmf documentation repo :-)

i was thinking of a phpdoc that explains what the $media parameter does (resp. explains its only a BC legacy). i guess as it was a required parameter, removing it and then adding the $basePath would be a very bad idea as suddenly everybody would set their base path to screen or dummy or other previous $media names.