BlockHelper::includeStylesheets $media argument

[dbu]

I know this is not something that will be easy to fix, but what is the point of the $media argument on the stylesheets call? would it not be the job of the block service to know what stylesheet is for which media? how would the template including the css know? and how would it handle different stylesheets for print and screen?

that said, we tend to define all css in a common place and combine it all with assetic, rather than include fragments on a par page + per block basis, as this is not caching friendly. still as the feature is there, rather have it meaningful.

[rande]

The getStyleSheets and getJavascripts methods are not the best thing in this bundle. However it works with some drawbacks.

The template helpers usage is not mandatory at all. So you can use the helpers and this will not work with assetic or you can create your js/css package with assetic or bower.

Not sure how to respond to you ;)

Can I close this issue ?

[dbu]

maybe adding a phpdoc saying @param string $media The css media type to use: all|screen|...

[rande]

Do you want to send a PR ?

[dbu]

yeah that is the right answer i guess :-)
just sent the PR