Fixed deprecation of security.context on AdminSecurityController #834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
approved these changes
Feb 3, 2017
|
Added another commit replacing other |
|
We'll squash them for you, but please next time use |
core23
approved these changes
Feb 3, 2017
|
I can do it when the build passes. |
As you wish, really |
|
Test failed because of phpunit version? |
jordisala1991
force-pushed
the
hotfix/class_exists
branch
from
53849fd
to
c13969f
Compare
|
Yes, sorry for that, see sonata-project/dev-kit#231 |
jordisala1991
force-pushed
the
hotfix/class_exists
branch
from
c13969f
to
d21f74b
Compare
|
Thanks @jordisala1991 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am targetting this branch, because it is BC.
Changelog
Subject
It removes a deprecated message. The code was testing if a class_exists on an interface (that always returns false). I replaced it with a container has method, which is used earlier in the same class for another BC trick.