Php7.2 #257
Merged
Php7.2 #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We cannot add the types to this signature without getting an error about imcompatibility with \php_user_filter::filter: > Declaration of Sonata\Exporter\Writer\CsvWriterTerminate::filter($in, $out, int &$consumed, bool $closing): int should be compatible with php_user_filter::filter($in, $out, &$consumed, $closing)
|
Anticipates sonata-project/dev-kit#448 |
kunicmarko20
reviewed
Dec 1, 2018
| * @param resource $in | ||
| * @param resource $out | ||
| * @param int $consumed | ||
| * @param bool $closing | ||
| */ | ||
| public function filter($in, $out, &$consumed, $closing): int |
There was a problem hiding this comment.
why these arent types in the signature?
OskarStark
approved these changes
Dec 2, 2018
OskarStark
approved these changes
Dec 2, 2018
|
Thanks @greg0ire |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am targeting this branch, because this PR has BC-breaks.