Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Php7.2 #257

Merged
merged 3 commits into from Dec 2, 2018
Merged

Php7.2 #257

merged 3 commits into from Dec 2, 2018

Commits on Dec 1, 2018

  1. Require php 7.2

    @greg0ire
    greg0ire committed Dec 1, 2018
    Configuration menu
    Copy the full SHA
    c51d6c5 View commit details
    Browse the repository at this point in the history

  2. Add missing type docs 

    We cannot add the types to this signature without getting an error about
imcompatibility with \php_user_filter::filter:

> Declaration of Sonata\Exporter\Writer\CsvWriterTerminate::filter($in,
$out, int &$consumed, bool $closing): int should be compatible with
php_user_filter::filter($in, $out, &$consumed, $closing)
    @greg0ire
    greg0ire committed Dec 1, 2018
    Configuration menu
    Copy the full SHA
    67fd9d8 View commit details
    Browse the repository at this point in the history

  3. Restrict type to string only

    @greg0ire
    greg0ire committed Dec 1, 2018
    Configuration menu
    Copy the full SHA
    a2a7146 View commit details
    Browse the repository at this point in the history