Skip to content

Commit

Permalink
Fix for application of tooltip causing error in population of symbols.
Browse files Browse the repository at this point in the history
  • Loading branch information
Jason Burns committed Apr 30, 2020
1 parent e32dbab commit 871442c
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 6 deletions.
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ To find your plugins directory...

# Changelog

* **0.23** - Fix for application of tooltip causing error in population of symbols.
* **0.22** - Second attempt at fix for select box not populating correctly when swapping individual symbols.
* **0.21** - Fix for select box not populating correctly when swapping individual symbols.
* **0.20** - Improved select boxes when swapping instances, fixed broken check for updates after library swapping.
Expand Down
2 changes: 1 addition & 1 deletion Symbol Swapper.sketchplugin/Contents/Sketch/manifest.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"description" : "Swap the selected symbols and/or symbol instances to another master, or swap entire libraries.",
"author" : "Jason Burns",
"homepage" : "https://github.com/sonburn/symbol-swapper",
"version" : "0.22",
"version" : "0.23",
"identifier" : "com.sonburn.sketchplugins.symbol-swapper",
"appcast" : "https://raw.githubusercontent.com/sonburn/symbol-swapper/master/appcast.xml",
"icon" : "icon.png",
Expand Down
9 changes: 7 additions & 2 deletions Symbol Swapper.sketchplugin/Contents/Sketch/script.js
Original file line number Diff line number Diff line change
Expand Up @@ -1102,12 +1102,17 @@ function getLibrary(context) {
alertWindow.addAccessoryView(symbolMaster);

symbolMaster.setEnabled(0);
symbolMaster.setToolTip(symbolArray[symbolMaster.indexOfSelectedItem()]);

if (symbolMaster.numberOfItems() > 0) {
symbolMaster.setToolTip(symbolArray[symbolMaster.indexOfSelectedItem()]);
}

// Create the symbol master delegate
var symbolMasterDelegate = new MochaJSDelegate({
"comboBoxSelectionDidChange:" : (function() {
symbolMaster.setToolTip(symbolArray[symbolMaster.indexOfSelectedItem()]);
var tooltip = (symbolMaster.numberOfItems() > 0) ? symbolArray[symbolMaster.indexOfSelectedItem()] : '';

symbolMaster.setToolTip(tooltip);
})
});

Expand Down
6 changes: 3 additions & 3 deletions appcast.xml
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,15 @@
<description>Swap the selected symbols and/or symbol instances to another master.</description>
<language>en</language>
<item>
<title>Version 0.22</title>
<title>Version 0.23</title>
<description>
<![CDATA[
<ul>
<li>Second attempt at fix for select box not populating correctly when swapping individual symbols.</li>
<li>Fix for application of tooltip causing error in population of symbols.</li>
</ul>
]]>
</description>
<enclosure url="https://github.com/sonburn/symbol-swapper/archive/master.zip" sparkle:version="0.22" />
<enclosure url="https://github.com/sonburn/symbol-swapper/archive/master.zip" sparkle:version="0.23" />
</item>
</channel>
</rss>

0 comments on commit 871442c

Please sign in to comment.