is a signature necessary for transaction->toEnvelopeXdrBase64();

[arduent]

Soneso/StellarSDK/Transaction.php

Why does it have to be signed? Stellar Laboratory lets you import unsigned XDR envelopes so that they may be signed.

Can the signature requirement be removed or maybe it needs a new function/parameter? But the function still works with signatures, without the check. If something else in the SDK needs a signature I'm not sure this is the place to check.

/**
 * @throws Exception if transaction is not signed.
 */
public function toEnvelopeXdr(): XdrTransactionEnvelope
{
    if (count($this->getSignatures()) == 0) {
        throw new Exception("Transaction must be signed by at least one signer. Use transaction.sign().");
    }
    $xdrTransaction = $this->toXdr();
    $v1Envelope = new XdrTransactionV1Envelope($xdrTransaction, $this->getSignatures());
    $type = new XdrEnvelopeType(XdrEnvelopeType::ENVELOPE_TYPE_TX);
    $xdrEnvelope = new XdrTransactionEnvelope($type);
    $xdrEnvelope->setV1($v1Envelope);
    return $xdrEnvelope;
}

https://laboratory.stellar.org/#txsigner

If i comment out the sig check the the XDR imports just fine. But maybe this breaks something else in the SDK.

[christian-rogobete]

Hello @arduent,

it seams that you have an old version of the SDK. I can not find this check in the current version of the SDK. But I need to remove the comment because it dose not throw.

Thanks

[christian-rogobete]

see also #8