Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add RD bit to UDP Client #36

Closed
wants to merge 1 commit into from
Closed

add RD bit to UDP Client #36

wants to merge 1 commit into from

Conversation

eviltik
Copy link
Contributor

@eviltik eviltik commented Mar 8, 2021

fix #33
fix #29

Copy link

@fishcharlie fishcharlie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm this should fix #29. My patch to fix #29 has this same code, except it is right above client.send(query.toBuffer(), port, dns, err => err && reject(err));.

I don't think the position of this code should make an impact, so long as it's done before client.send.

Thanks @eviltik!!

@eviltik
Copy link
Contributor Author

eviltik commented Mar 8, 2021

Please ignore this PR. RD bit should be enable by default, but must be MUST be togglelable.

@eviltik eviltik closed this Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UDP Client: doesn't resolve inside VirtualBox No RD bit in request - DNS Query Randomly Fails
2 participants