Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sonic-config-engine] Yang validation for sonic-config-engine is blocked by sonic-bgp-voq-chassis-neighbor.yang #10793

Closed
ganglyu opened this issue May 10, 2022 · 0 comments · Fixed by #10805
Assignees
Labels
sonic-cfggen SONiC Configuration Generator Tool YANG YANG model related changes

Comments

@ganglyu
Copy link
Contributor

ganglyu commented May 10, 2022

Description

I’m trying to merge this PR, and it will run Yang validation for sonic-config-engine unit test.
#9700
And I find the unit test is blocked by sonic-bgp-voq-chassis-neighbor.yang, and many test cases can’t satisfy this constraint.
https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-yang-models/yang-models/sonic-bgp-voq-chassis-neighbor.yang#L57-L59
And related test cases are:
test_minigraph_storage_backend_subintf
test_minigraph_storage_backend_resource_type
test_minigraph_storage_backend_no_resource_type
test_var_json_data
test_minigraph_vxlan
test_minigraph_vnet
test_minigraph_vlans
test_minigraph_vlan_members
test_minigraph_vlan_interfaces
test_minigraph_sub_port_intf_sub
test_minigraph_sub_port_intf_resource_type_non_backend_tor
test_minigraph_sub_port_intf_resource_type
test_minigraph_sub_port_interfaces
test_minigraph_portchannels
test_minigraph_portchannel_interfaces
test_minigraph_interfaces
test_minigraph_extra_ethernet_interfaces
test_minigraph_ethernet_interfaces
test_minigraph_bgp_voq_chassis_peer
test_minigraph_bgp_mon

Steps to reproduce the issue:

  1. Use my PR to build sonic-config-engine
  2. Check unit test result.

Describe the results you received:

20 test cases failed.

Describe the results you expected:

All test cases should pass.

Output of show version:

(paste your output here)

Output of show techsupport:

(paste your output here or download and attach the file here )

Additional information you deem important (e.g. issue happens only occasionally):

@ganglyu ganglyu added sonic-cfggen SONiC Configuration Generator Tool YANG YANG model related changes labels May 10, 2022
ganglyu pushed a commit that referenced this issue May 12, 2022
Why I did it
Fixes #10793

How I did it
Removed the switch_type validation from the Yang model.

How to verify it
compile sonic_yang_mgmt-1.0-py3-none-any.whl and sonic_yang_mgmt-1.0-py3-none-any.whl

Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com>
liushilongbuaa pushed a commit to liushilongbuaa/sonic-buildimage that referenced this issue Jun 20, 2022
…anch

Related work items: #52, #71, #73, #75, #77, sonic-net#1306, sonic-net#1588, sonic-net#1991, sonic-net#2031, sonic-net#2040, sonic-net#2053, sonic-net#2066, sonic-net#2069, sonic-net#2087, sonic-net#2107, sonic-net#2110, sonic-net#2112, sonic-net#2113, sonic-net#2117, sonic-net#2124, sonic-net#2125, sonic-net#2126, sonic-net#2128, sonic-net#2130, sonic-net#2131, sonic-net#2132, sonic-net#2133, sonic-net#2134, sonic-net#2135, sonic-net#2136, sonic-net#2137, sonic-net#2138, sonic-net#2139, sonic-net#2140, sonic-net#2143, sonic-net#2158, sonic-net#2161, sonic-net#2233, sonic-net#2243, sonic-net#2250, sonic-net#2254, sonic-net#2260, sonic-net#2261, sonic-net#2267, sonic-net#2278, sonic-net#2282, sonic-net#2285, sonic-net#2288, sonic-net#2289, sonic-net#2292, sonic-net#2294, sonic-net#8887, sonic-net#9279, sonic-net#9390, sonic-net#9511, sonic-net#9700, sonic-net#10025, sonic-net#10322, sonic-net#10479, sonic-net#10484, sonic-net#10493, sonic-net#10500, sonic-net#10580, sonic-net#10595, sonic-net#10628, sonic-net#10634, sonic-net#10635, sonic-net#10644, sonic-net#10670, sonic-net#10691, sonic-net#10716, sonic-net#10731, sonic-net#10750, sonic-net#10751, sonic-net#10752, sonic-net#10761, sonic-net#10769, sonic-net#10775, sonic-net#10776, sonic-net#10779, sonic-net#10786, sonic-net#10792, sonic-net#10793, sonic-net#10800, sonic-net#10806, sonic-net#10826, sonic-net#10839, sonic-net#10840, sonic-net#10842, sonic-net#10844, sonic-net#10847, sonic-net#10849, sonic-net#10852, sonic-net#10865, sonic-net#10872, sonic-net#10877, sonic-net#10886, sonic-net#10889, sonic-net#10903, sonic-net#10904, sonic-net#10905, sonic-net#10913, sonic-net#10914, sonic-net#10916, sonic-net#10919, sonic-net#10925, sonic-net#10926, sonic-net#10929, sonic-net#10933, sonic-net#10934, sonic-net#10937, sonic-net#10941, sonic-net#10947, sonic-net#10952, sonic-net#10953, sonic-net#10957, sonic-net#10959, sonic-net#10971, sonic-net#10972, sonic-net#10980
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sonic-cfggen SONiC Configuration Generator Tool YANG YANG model related changes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants