Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Sub-If|VRF] Unbind sub-interface from VRF is failed #12170

Closed
Hedgehog-Guru opened this issue Sep 23, 2022 · 6 comments · Fixed by #13113
Closed

[Sub-If|VRF] Unbind sub-interface from VRF is failed #12170

Hedgehog-Guru opened this issue Sep 23, 2022 · 6 comments · Fixed by #13113
Assignees
@adyeung @preetham-singh
Labels
Issue for 202205

Comments

@Hedgehog-Guru
Copy link

Hedgehog-Guru commented Sep 23, 2022 •
edited
Loading

Description

Sun-Interface is left in inconsistent state if it was unbinded from VRF

Steps to reproduce the issue:

  1. Create any VRF config vrf add Vrf_11
  2. Create any sub-interface config subinterface add Eth0.11 11
  3. Bind sub-interface to VRF config interface vrf bind Eth0.11 Vrf_11
  4. Check bind was successful
    show vrf
    ip link show vrf Vrf_11
  5. Unbind config interface vrf unbind Eth0.11
  6. Check again
    show vrf
    ip link show vrf Vrf_11

Describe the results you received:

After unbinding Linux interface is still has master Vrf_11. SONIC output looks OK

root@qa-eth-vt01-3-2700a0:/home/admin# ip link show vrf Vrf_11
77: Eth0.11@Ethernet0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 9100 qdisc noqueue master Vrf_11 state UP mode DEFAULT group default qlen 1000
    link/ether 24:8a:07:80:d1:40 brd ff:ff:ff:ff:ff:ff
root@qa-eth-vt01-3-2700a0:/home/admin# show vrf
VRF     Interfaces
------  ------------
Vrf_11
root@qa-eth-vt01-3-2700a0:/home/admin#

Describe the results you expected:

Linux interface unbinded too

Output of show version:

SONiC Software Version: SONiC.202205_rc.11-a0e7525cf_Internal
Distribution: Debian 11.5
Kernel: 5.10.0-12-2-amd64
Build commit: a0e7525cf
Build date: Wed Sep 14 14:08:46 UTC 2022
Built by: sw-r2d2-bot@r-build-sonic-ci02-241

Platform: x86_64-mlnx_msn2700-r0
HwSKU: Mellanox-SN2700
ASIC: mellanox
ASIC Count: 1
Serial Number: MT1649X04248
Model Number: MSN2700-CS2F
Hardware Revision: Not Specified
Uptime: 11:24:02 up 14 min,  2 users,  load average: 0.94, 0.90, 0.76
Date: Mon 19 Sep 2022 11:24:02

Output of show techsupport:

sonic_dump_qa-eth-vt01-3-2700a0_20220919_112341.tar.gz

Additional information you deem important (e.g. issue happens only occasionally):
@Hedgehog-Guru Hedgehog-Guru changed the title [Sub-If] [Sub-If|VRF] Unbind sub-interface from VRF is failed Sep 23, 2022
@dgsudharsan
Copy link
Collaborator

@adyeung @preetham-singh Can you please investigate?
This is due to unbind not properly handled for subinterface. In unbind call CLI rather than deleting the interface the vlan subinterface table is set with fields other than Vrf which is not properly handled in swss
127.0.0.1:6379[4]> hgetall "VLAN_SUB_INTERFACE|Eth0.11"

  1. "admin_status"
  2. "up"
  3. "vlan"
  4. "11"
    127.0.0.1:6379> hgetall "INTF_TABLE:Eth0.11"
  5. "vlan"
  6. "11"
  7. "vrf_name"
  8. "Vrf_11"
  9. "mtu"
  10. "0"
  11. ""
  12. ""
  13. "admin_status"
  14. "up"
  15. "mac_addr"
  16. "00:00:00:00:00:00"

@preetham-singh
Copy link
Contributor

Please assign the issue to me. I am working on fix.

@gechiang
Copy link
Collaborator

According to @adyeung this is being addressed by Broadcom team.

@dgsudharsan
Copy link
Collaborator

@preetham-singh @adyeung Any update on ETA for this issue?

@preetham-singh
Copy link
Contributor

ETA: 7th Nov'2022

@dgsudharsan
Copy link
Collaborator

@preetham-singh Do we have a PR to fix this issue?

@preetham-singh preetham-singh mentioned this issue Nov 21, 2022
Merged
@keboliu keboliu mentioned this issue Dec 20, 2022
Merged
8 tasks
@dgsudharsan dgsudharsan mentioned this issue Dec 20, 2022
Merged
dgsudharsan added a commit to dgsudharsan/sonic-buildimage that referenced this issue Dec 20, 2022
@dgsudharsan
[202205][submodule] Update sonic-utilities submodule
82b4aab 
Update sonic-utilities submodule pointer to include the following:
* 67cbb15 [202205]Fixes sonic-net#12170: Delete subinterface and recreate the subinterface in default-vrf ([sonic-net#2564](sonic-net/sonic-utilities#2564))
* 93172c4 [202205] [generate_dump] Optimize the execution time of the 'show techsupport' script to 5-10% by reducing calls to the 'tar append' operation ([sonic-net#2562](sonic-net/sonic-utilities#2562))

Signed-off-by: dgsudharsan <sudharsand@nvidia.com>
@dgsudharsan dgsudharsan mentioned this issue Dec 20, 2022
Closed
8 tasks
dprital added a commit to dprital/sonic-buildimage that referenced this issue Dec 26, 2022
@dprital
[202205][submodule] Advance sonic-utilities pointer
0885998 
Update sonic-utilities submodule pointer to include the following:
* f7988b0 [202205] [timer.unit.j2] use wanted-by in timer unit ([sonic-net#2561](sonic-net/sonic-utilities#2561))
* f45dcfb [generate_dump] Optimize the execution time of 'show techsupport' CLI by paraller function execution ([sonic-net#2565](sonic-net/sonic-utilities#2565))
* 67cbb15 [202205]Fixes sonic-net#12170: Delete subinterface and recreate the subinterface in default-vrf ([sonic-net#2564](sonic-net/sonic-utilities#2564))
* 93172c4 [202205] [generate_dump] Optimize the execution time of the 'show techsupport' script to 5-10% by reducing calls to the 'tar append' operation ([sonic-net#2562](sonic-net/sonic-utilities#2562))

Signed-off-by: dprital <drorp@nvidia.com>
@dprital dprital mentioned this issue Dec 26, 2022
Merged
8 tasks
@StormLiangMS StormLiangMS mentioned this issue Dec 30, 2022
Merged
8 tasks
StormLiangMS added a commit that referenced this issue Jan 14, 2023
@StormLiangMS
[submodule advance] advance sonic-utilities submodule for 202211 branch
542c47c 
#13202

advance sonic-utilities submodule for 202211 branch

34428157 - (HEAD, origin/202211) Revert "Optimize the execution time of the 'show techsupport' script to 5-10%, (Qos config change #2504)" (6 days ago) [stormliang]
c3bd01f6 - Revert "[generate_dump] Optimize the execution time of 'show techsupport' CLI by parallel function execution ([201811][Devices] Add new device CIG CS6436-56P #2512)" (6 days ago) [stormliang]
5a326d8b - [Mellanox] Change severity to NOTICE in Mellanox buffer migrator when unable to fetch DEVICE_METADATA due to empty CONFIG_DB during initialization ([warm boot] cherry-pick PR #2538 and advance related sub-modules in 201811 branch #2569) (2 weeks ago) [Stephen Sun]
50b36ef3 - Fix issue: unconfigured PGs are displayed in watermarkstat ([docker-lldp]: fix several issues in lldpd docker #2556) (2 weeks ago) [Stephen Sun]
a9fd2a79 - [Command Ref] Add doc for syslog rate limit ([sub module] move sairedis and swss to 201811 branch #2508) (2 weeks ago) [Junchao-Mellanox]
80546ff3 - [generate_dump] Optimize the execution time of 'show techsupport' CLI by parallel function execution ([201811][Devices] Add new device CIG CS6436-56P #2512) (2 weeks ago) [Vadym Hlushko]
6649ca8a - [timer.unit.j2] use wanted-by in timer unit ([201803] [services] Restart SwSS service upon unexpected critical process exit #2546) (2 weeks ago) [Stepan Blyshchak]
dd23d0ef - Fixes [Sub-If|VRF] Unbind sub-interface from VRF is failed #12170: Delete subinterface and recreate the subinterface in ([VLAN] "show mac" doesn't work when interface added to vlan as tagged member #2513) (2 weeks ago) [Preetham]
236749d3 - [db_migrator] Fix migration of Loopback data: handle all Loopback interfaces (DellEMC S6000 xcvrd support #2560) (2 weeks ago) [Vaibhav Hemant Dixit]
5762d814 - Optimize the execution time of the 'show techsupport' script to 5-10%, (Qos config change #2504) (2 weeks ago) [Vadym Hlushko]
d3c3e368 - [muxcable][show] update show mux tunnel-route to separate ASIC and kernel into two columns (build errors on branch 201811 for centec platform #2553) (2 weeks ago) [Jing Zhang]
c98648a1 - [show]Fix show route return code on error (Dell SMF driver hwmon number reorder fix for Dell S6100/Z9100 #2542) (2 weeks ago) [Sudharsan Dhamal Gopalarathnam]
01374673 - [route_check]: Ignore ASIC only SOC IPs (Added new SN3700/SN3700C Mellanox platforms #2548) (2 weeks ago) [Lawrence Lee]
d2967805 - YANG Validation for ConfigDB Updates: WARM_RESTART, SFLOW_SESSION, SFLOW, VXLAN_TUNNEL, VXLAN_EVPN_NVO, VXLAN_TUNNEL_MAP, MGMT_VRF_CONFIG, CABLE_LENGTH, VRF tables ([submodule 201811] advance sairedis and swss submodule for 201811 branch #2526) (2 weeks ago) [isabelmsft]
88b01ffd - [db_migrator] Remove import of swsssdk as it is not supported in master ([build]: apply proxy setting to curl. #2544) (2 weeks ago) [Vaibhav Hemant Dixit]
4ae970c6 - Support syslog rate limit configuration for containers and host (Move FRR from 4.0 to 6.0.2 and make new frr version and pkg compile #2454) (2 weeks ago) [Junchao-Mellanox]
608ed147 - [generate_dump] [Mellanox] Fix the duplicate dfw dump collection problem by adding symlinks ('show vlan config' is not displaying the VLAN members, after the clear config and reload with default l2 configuration. #2536) (2 weeks ago) [Vivek]
bdc2599f - [config] Add check in config interface ip command to block if the interface is portchannel member ([sub module] advance sonic-swss sub module #2539) (2 weeks ago) [Sudharsan Dhamal Gopalarathnam]
cff4fed5 - [system-health] Improve code structure of system health CLIs ([sub-module] advance sonic-swss sub-module #2453) (2 weeks ago) [Junchao-Mellanox]
488e5714 - Transceiver eeprom dom CLI modification to show output from TRANSCEIVER_DOM_THRESHOLD table (Fix for KeyError: 'DEVICE_NEIGHBOR' when executing 'show interfaces neighbor expected' command #2535) (2 weeks ago) [mihirpat1]
07ca5def - sonic-utilities: Update config reload() to verify formatting of an input file ([ntp]: Do not disable reader for error ENOBUFS #2529) (2 weeks ago) [Caitlin Choate]
f0f083a2 - [GCU] Add RemoveCreateOnlyDependency Validator/Generator (Enabling Fast-reboot command in s6100 loaded with T0 topo getting Failed unmounting /host error #2500) (2 weeks ago) [jingwenxie]
eca0253c - [QoS] Introduce delay to the qos reload flow (Config reload/load_minigraph not clearing State DB #2503) (2 weeks ago) [DavidZagury]
35158ee0 - Use github code scanning instead of LGTM ([sub module] sub module sonic-swss-common tracking 201811 branch #2530) (2 weeks ago) [Liu Shilong]
682b5cee - Change show kube command default value of insecure key to True ([submodule] update sonic-snmpagent #2517) (2 weeks ago) [lixiaoyuner]
ce19e631 - Add db_migrator_constants.py script to setup.py (Add device data for Arista 7060PX/DX4-32 #2534) (2 weeks ago) [Vaibhav Hemant Dixit]
0d0c2693 - [drop counters] Fix CLI script for unconfigured PGs ([config] Do not fail for minigraphs which do not have neighbors listed in <Devices> section #2518) (2 weeks ago) [Lior Avramov]
2c69d0fd - Update vrf add, del commands for duplicate/non-existing VRFs (solve package build dependency issue #2467) (2 weeks ago) [Muhammad Danish]
efc09280 - Port 202012 DB migration changes to newer branches ([vs]: Force10-S6000 buffer settings for virtual switch #2515) (2 weeks ago) [Vaibhav Hemant Dixit]
70a15aaa - [VXLAN]Fixing traceback in show remotemac when mac moves during command execution ([build] When generating image version, handle case where current commit has no reachable tags #2506) (2 weeks ago) [Sudharsan Dhamal Gopalarathnam]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adyeung adyeung

@preetham-singh preetham-singh

Labels
Issue for 202205
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[submodule] Advance sonic-utilities submodule pointer keboliu/sonic-buildimage
5 participants
@dgsudharsan @adyeung @preetham-singh @gechiang @Hedgehog-Guru