Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VOQ] 'portstat -j' generates invalid output #15439

Closed
ysmanman opened this issue Jun 12, 2023 · 1 comment · Fixed by sonic-net/sonic-utilities#2874
Closed

[VOQ] 'portstat -j' generates invalid output #15439

ysmanman opened this issue Jun 12, 2023 · 1 comment · Fixed by sonic-net/sonic-utilities#2874

Comments

@ysmanman
Copy link
Contributor

Description

We observed this issue in T2 testing with recent 202205 image.

portstat -j produced the following line that is not able parsed by json.

Reminder: Please execute 'show interface counters -d all' to include internal links

This seems a regression from sonic-net/sonic-utilities#2851. The offending line is https://github.com/sonic-net/sonic-utilities/blob/dbcaaf8aa27b37dfba1b088e2fa59fd94b8dc683/scripts/portstat#L341

if multi_asic.is_multi_asic() or device_info.is_chassis() and not use_json:

With the above condition, Reminder: Please execute 'show interface counters -d all' to include internal links is printed even when use_json is True.

Steps to reproduce the issue:

Describe the results you received:

Describe the results you expected:

Output of show version:

(paste your output here)

Output of show techsupport:

(paste your output here or download and attach the file here )

Additional information you deem important (e.g. issue happens only occasionally):

@ysmanman
Copy link
Contributor Author

Add @arlakshm @wenyiz2021 for visiblity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant