Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LAG state becomes no-carrier even if there are members in LOWER_UP #600

Closed
marian-pritsak opened this issue May 12, 2017 · 8 comments
Closed

LAG state becomes no-carrier even if there are members in LOWER_UP #600

marian-pritsak opened this issue May 12, 2017 · 8 comments
Labels
Bug 🐛

Comments

@marian-pritsak
Copy link
Collaborator 

$ ip link show PortChannel0 ; ip link show Ethernet0 ; ip link show Ethernet4
38: PortChannel0: <NO-CARRIER,BROADCAST,MULTICAST,UP> mtu 1500 qdisc noqueue state DOWN mode DEFAULT group default 
    link/ether 24:8a:07:05:31:c0 brd ff:ff:ff:ff:ff:ff
17: Ethernet0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc pfifo_fast master PortChannel0 state UP mode DEFAULT group default qlen 1000
    link/ether 24:8a:07:05:31:c0 brd ff:ff:ff:ff:ff:ff
23: Ethernet4: <NO-CARRIER,BROADCAST,MULTICAST,UP> mtu 1500 qdisc pfifo_fast master PortChannel0 state DOWN mode DEFAULT group default qlen 1000
    link/ether 24:8a:07:05:31:c0 brd ff:ff:ff:ff:ff:ff

teamd min_ports configuration does not allow less than 75% of active members causing whole LAG to go down.
@marian-pritsak
Copy link
Collaborator Author

@lguohan is it a desired behavior?

@stcheng
Copy link
Contributor

stcheng commented May 12, 2017

yes. if less than 75% of members are DOWN. the whole LAG will be set to DOWN with NO-CARRIER flag.

@liatgrozovik
Copy link

The LAG test is running for more than a month on daily now and it was passing until recently (all was good a week ago. IMO build 2.3.3 was working while 2.3.4 is not).
The behaviour seems to be modified recently. @stcheng please elaborate why the change introduced and why the desired behaviour has been modified without taking into consideration tests available and behaviour should not be modified unless all are sync.

@lguohan
Copy link
Collaborator

lguohan commented May 16, 2017

what are build 2.3.3 and 2.3.4? minlink was added at jan 30. which lag test fails?

@marian-pritsak
Copy link
Collaborator Author

Build 233 and 234.

We tried to put link on the other side of LAG member down to check if traffic will be redistributed via another member, but whole LAG goes down as soon as one LAG member goes down and packets are not transmitted at all.

@lguohan
Copy link
Collaborator

lguohan commented May 17, 2017

Here are the changed in build 234. https://sonic-jenkins.westus.cloudapp.azure.com/job/mellanox/job/buildimage-mlnx-all/234/

I do not find any changes related to lag. given the min_link is merged into master and Jan 30. I do not have explaination why build 233 works but not build 234.

@lguohan
Copy link
Collaborator

lguohan commented May 23, 2017

can we close this issue? it is by design.

@marian-pritsak
Copy link
Collaborator Author

Closing

@daall daall mentioned this issue Sep 3, 2019
Merged
lguohan pushed a commit that referenced this issue Sep 5, 2019
@daall @lguohan
[src/sonic-utilities] Update sonic-utilities submodule (#3405)
47504d1 
Submodule src/sonic-utilities 4024019:

[doc/command-reference.md] dos2unix & remove trailing spaces (#591)
[show] Add BGP neighbor info to 'show ip/ipv6 interfaces' command output (#598)
[config]: fix the runtime error of the 'show line' command (#595) (#596)
Revert "Removed 'show interfaces alias'. (#412)" (#603)
[debug][undebug] Rework of CLI for BGP (#583)
Changing "show runningconfiguration interface" to "show runningconfiguration ports" (#600)
[config] Add commands to add/remove DHCP server address from a VLAN (#585)
[neighbor_advertiser] Use full vlan name for vxlan tunnel map programming (#604)
[neighbor_advertise]: Use the existing MIRROR ACL table (#605)
Read config DB for running interface(s) and display per port/interface (#594)
[fast/warm reboot] kill radv docker before stopping BGP (#608)
[config] Add commands for adding/removing syslog servers (#609)
[config] Call 'systemctl reset-failed' before 'systemctl restart' when restarting services (#607)
[Command Reference] Add config commands for DHCP relay destination address (#610)
[config] Add commands for adding/removing NTP servers (#611)
[neighbor_advertiser]: Add V6 support to mirror ICMPV6 packets (#612)
[neighbor advertiser] try getting vlan addresses from o.s first (#613)
[show] Add command 'show runningconfiguration syslog' (#617)
[show] Add command 'show runningconfig ntp' (#620)
Added check to config syslog del to verify if ip address was configured. (#622)
[fast-reboot] Check if ASIC config has changed before warm reboot (#621)

Signed-off-by: Danny Allen daall@microsoft.com
sridhar-ravindran pushed a commit to sridhar-ravindran/sonic-buildimage that referenced this issue Sep 6, 2019
@daall @sridhar-ravindran
[src/sonic-utilities] Update sonic-utilities submodule (sonic-net#3405)
7a839fa 
Submodule src/sonic-utilities 4024019:

[doc/command-reference.md] dos2unix & remove trailing spaces (sonic-net#591)
[show] Add BGP neighbor info to 'show ip/ipv6 interfaces' command output (sonic-net#598)
[config]: fix the runtime error of the 'show line' command (sonic-net#595) (sonic-net#596)
Revert "Removed 'show interfaces alias'. (sonic-net#412)" (sonic-net#603)
[debug][undebug] Rework of CLI for BGP (sonic-net#583)
Changing "show runningconfiguration interface" to "show runningconfiguration ports" (sonic-net#600)
[config] Add commands to add/remove DHCP server address from a VLAN (sonic-net#585)
[neighbor_advertiser] Use full vlan name for vxlan tunnel map programming (sonic-net#604)
[neighbor_advertise]: Use the existing MIRROR ACL table (sonic-net#605)
Read config DB for running interface(s) and display per port/interface (sonic-net#594)
[fast/warm reboot] kill radv docker before stopping BGP (sonic-net#608)
[config] Add commands for adding/removing syslog servers (sonic-net#609)
[config] Call 'systemctl reset-failed' before 'systemctl restart' when restarting services (sonic-net#607)
[Command Reference] Add config commands for DHCP relay destination address (sonic-net#610)
[config] Add commands for adding/removing NTP servers (sonic-net#611)
[neighbor_advertiser]: Add V6 support to mirror ICMPV6 packets (sonic-net#612)
[neighbor advertiser] try getting vlan addresses from o.s first (sonic-net#613)
[show] Add command 'show runningconfiguration syslog' (sonic-net#617)
[show] Add command 'show runningconfig ntp' (sonic-net#620)
Added check to config syslog del to verify if ip address was configured. (sonic-net#622)
[fast-reboot] Check if ASIC config has changed before warm reboot (sonic-net#621)

Signed-off-by: Danny Allen daall@microsoft.com
Kalimuthu-Velappan pushed a commit to Kalimuthu-Velappan/sonic-buildimage that referenced this issue Sep 12, 2019
@vasant17 @jleveque
Changing "show runningconfiguration interface" to "show runningconfig…
48e0e1b 
…uration ports" (sonic-net#600)

Signed-off-by: Vasant Patil <vapatil@linkedin.com>
madhanmellanox pushed a commit to madhanmellanox/sonic-buildimage that referenced this issue Mar 23, 2020
@rodnymolina @lguohan
WarmRestart class changes (sonic-net#600)
65b015b 
* WarmRestart class changes

The current WarmStart class assumes that restarting applications will invoke checkWarmStart() method during initialization. Currently, this method serves two main purposes: 1) a static-constructor and 2) checks if WarmRestart feature has been enabled for a given application.

In this PR i'm proposing to split these different logics in two separated methods. The main goal here is to allow applications such as fpmSyncd to call checkWarmStart whenever it please (i.e. fpmSyncd restart or zebra<->fpmSyncd tcp re-establishment). There could be other applications in the future interested in this differentiated approch.

Other than that i'm making small adjustments in the code to enhance readibility.

Signed-off-by: Rodny Molina <rmolina@linkedin.com>

* Adjusting schema as per latest discussions

Signed-off-by: Rodny Molina <rmolina@linkedin.com>

* Taking care of minor comment.

Signed-off-by: Rodny Molina <rmolina@linkedin.com>

* Removing WarmRestart's implicit initialization instruction.

Signed-off-by: Rodny Molina <rmolina@linkedin.com>

* Readjusting schema to clarify the role of warm-reboot's INITIALIZED state.

Signed-off-by: Rodny Molina <rmolina@linkedin.com>

* Adjusting neighborsyncd-warmreboot to latest WarmStart class changes

Signed-off-by: Rodny Molina <rmolina@linkedin.com>
lguohan added a commit to lguohan/sonic-buildimage that referenced this issue Apr 12, 2020
@lguohan
[submodule]: update sonic-sairedis
781dc02 
* f972073 2020-04-12 | [vs]: set mtu only on the physical port (sonic-net#601) (HEAD, origin/master, origin/HEAD) [lguohan]
* e566f7a 2020-04-10 | [saiplayer] Convert saiplayer to static library (sonic-net#600) [Kamil Cudnik]
* fc3a413 2020-04-09 | [syncd] Convert syncd_request_shutdown to static library (sonic-net#599) [Kamil Cudnik]
* 027de8f 2020-04-09 | Do not translateVidToRid for processBulkQuadEvent in InitViewMode (sonic-net#598) [Qi Luo]
* b0ee63d 2020-04-08 | [syncd] [vs] [sairedis] Add support for bulk api in init view (sonic-net#591) [Kamil Cudnik]
* 48ef314 2020-04-08 | [sairedis] Add pragma once to lib header (sonic-net#597) [Kamil Cudnik]
* 74af900 2020-04-08 | [build]: allow to use extra inc/lib location to build the package (sonic-net#595) [lguohan]
* 9b8c63e 2020-04-07 | Update README.txt: add LGTM badges (sonic-net#596) [Qi Luo]
* fdd79e6 2020-04-07 | [tests] Update lib order (sonic-net#594) [Kamil Cudnik]
* d89eb59 2020-04-07 | [syncd] Change order of libs in Makefile.am (sonic-net#593) [Kamil Cudnik]

Signed-off-by: Guohan Lu <lguohan@gmail.com>
@lguohan lguohan mentioned this issue Apr 12, 2020
Merged
lguohan added a commit that referenced this issue Apr 13, 2020
@lguohan
[submodule]: update sonic-sairedis (#4416)
24231ba 
* f972073 2020-04-12 | [vs]: set mtu only on the physical port (#601) (HEAD, origin/master, origin/HEAD) [lguohan]
* e566f7a 2020-04-10 | [saiplayer] Convert saiplayer to static library (#600) [Kamil Cudnik]
* fc3a413 2020-04-09 | [syncd] Convert syncd_request_shutdown to static library (#599) [Kamil Cudnik]
* 027de8f 2020-04-09 | Do not translateVidToRid for processBulkQuadEvent in InitViewMode (#598) [Qi Luo]
* b0ee63d 2020-04-08 | [syncd] [vs] [sairedis] Add support for bulk api in init view (#591) [Kamil Cudnik]
* 48ef314 2020-04-08 | [sairedis] Add pragma once to lib header (#597) [Kamil Cudnik]
* 74af900 2020-04-08 | [build]: allow to use extra inc/lib location to build the package (#595) [lguohan]
* 9b8c63e 2020-04-07 | Update README.txt: add LGTM badges (#596) [Qi Luo]
* fdd79e6 2020-04-07 | [tests] Update lib order (#594) [Kamil Cudnik]
* d89eb59 2020-04-07 | [syncd] Change order of libs in Makefile.am (#593) [Kamil Cudnik]

Signed-off-by: Guohan Lu <lguohan@gmail.com>
dmytroxshevchuk pushed a commit to dmytroxshevchuk/sonic-buildimage that referenced this issue Aug 31, 2020
@kcudnik
[saiplayer] Convert saiplayer to static library (sonic-net#600)
e566f7a
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug 🐛
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@lguohan @stcheng @liatgrozovik @marian-pritsak