Always use the openssl backend of curl #14351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should make sure that the openssl backend of curl is used, instead of the gnutls or nss backend, for consistency reasons. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
saiarcot895
force-pushed
the
curl-openssl
branch
from
3efb603
to
a0d11a5
Compare
ganglyu
approved these changes
Mar 21, 2023
xumia
approved these changes
Mar 23, 2023
8 tasks
xumia
reviewed
Mar 23, 2023
| @@ -202,7 +202,7 @@ RUN apt-get update && apt-get install -y \ | |||
| libxml2-dev \ | |||
| # For BFN sdk build | |||
| libusb-1.0-0-dev \ | |||
| libcurl3-nss-dev \ | |||
| libcurl4-openssl-dev \ | |||
There was a problem hiding this comment.
Can we change the one in sonic-slave-buster/Dockerfile.j2 as well? We are still using the docker image.
8 tasks
xumia
added a commit
that referenced
this pull request
Mar 28, 2023
Why I did it Change to use the default ssl lib openssl not nss Backport #14351. How I did it
|
@saiarcot895 PR conflicts with 202205 branch |
8 tasks
saiarcot895
added a commit
to saiarcot895/sonic-buildimage
that referenced
this pull request
Apr 5, 2023
Why I did it This should make sure that the openssl backend of curl is used, instead of the gnutls or nss backend, for consistency reasons.
yxieca
pushed a commit
that referenced
this pull request
Apr 18, 2023
|
@saiarcot895 PR conflicts with 202211 branch |
|
Could you please clarify. https://github.com/sonic-net/sonic-mgmt-framework/blob/d5e23d8bd64d8c186b88d8faa7d56cf90cabe5a9/CLI/klish/Makefile#L22 |
|
@k-v1 I think it would be better for feature/capability consistency (and some minor space savings) that everything uses the openssl version of curl, unless there's a very good reason that some other backend needs to be used. |
saiarcot895
added a commit
to saiarcot895/sonic-buildimage
that referenced
this pull request
May 5, 2023
Why I did it This should make sure that the openssl backend of curl is used, instead of the gnutls or nss backend, for consistency reasons.
lixiaoyuner
pushed a commit
to lixiaoyuner/sonic-buildimage
that referenced
this pull request
Feb 6, 2024
https://msazure.visualstudio.com/One/_workitems/edit/17813211 Related work items: sonic-net#9216, sonic-net#11437, sonic-net#13507, sonic-net#13512, sonic-net#13567, sonic-net#13972, sonic-net#14351, sonic-net#14371, sonic-net#14375, sonic-net#14401, sonic-net#14407, sonic-net#14408, sonic-net#14427, sonic-net#14428, sonic-net#14439
lixiaoyuner
pushed a commit
to lixiaoyuner/sonic-buildimage
that referenced
this pull request
Feb 6, 2024
bluecmd
added a commit
to kamelnetworks/sonic-buildimage
that referenced
this pull request
Feb 20, 2024
|
I filed sonic-net/sonic-mgmt-framework#130 to investigate changing it to openssl as well instead of gnutls. |
bluecmd
added a commit
to kamelnetworks/sonic-buildimage
that referenced
this pull request
Mar 3, 2024
bluecmd
added a commit
to kamelnetworks/sonic-buildimage
that referenced
this pull request
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make sure that the openssl backend of curl is used, instead of the gnutls or nss backend, for consistency reasons.
Why I did it
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)