[chassis][lldp] Fix the lldp error log in host instance which doesn't contain front panel ports #14814

mlok-nokia · 2023-04-23T20:54:56Z

Why I did it

Fix issue #14251
In multiasic platform, there is NO front panel port in the host lldp docker. Because of there is NO front panel port, the host APPL_DB database will not genernate the "PORT_CONFIG_DONE" and "PORT_INIT_DONE" event. Therefore, the lldpmgrd log the error log - Port init timeout reached (300 seconds), resuming lldpd... in syslog.

Apr 18 01:57:03.993698 ixre-cpm-chassis9 ERR lldp#lldpmgrd[29]: Port init timeout reached (300 seconds), resuming lldpd...

OC test case failed-- autorestart/test_container_autorestart.py::test_containers_autorestart[ixre-cpm-chassis9-10-snmp

Work item tracking

Microsoft ADO https://msazure.visualstudio.com/One/_workitems/edit/17966117:

How I did it

Since there is NO front panel ports in the host database in the multiasic platform , there won't be PORT_CONFIG_DONE and PORT_INIT_DONE event from the APPL_DB. The error log ``Port init timeout reached (300 seconds), resuming lldpd...``` is not applicable to the host lldp. In or to suppress this error message, add function appdb_contains_lldp_port() to return False for the supervisor card and host instance in the multasic platform which NAMESPACE_ID is none. And use this function to determine and not to log this error log for the supervisor card and host database in the multasic platform.

How to verify it

Running image with this fix in the multiasic platform, verify this error log Port init timeout reached (300 seconds), resuming lldpd... should not be logged in the syslog.

Which release branch to backport (provide reason below if selected)

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

mlok-nokia · 2023-04-23T20:57:10Z

@judyjoseph @rlhui Judy and Rita, I have created this PR to supress the lldp error log for the host instance lldp. Please review it. THanks

mlok-nokia · 2023-04-24T14:55:18Z

@SuvarnaMeenakshi Hi Suvarna, I am not if you are working on this issue which show SNMP in the test case name. Please review this change. Thanks.

mlok-nokia · 2023-05-01T15:01:53Z

@abdosi @judyjoseph @SuvarnaMeenakshi Please help to review this PR.

abdosi · 2023-05-08T23:56:56Z

dockers/docker-lldp/lldpmgrd

@@ -267,6 +269,15 @@ class LldpManager(daemon_base.DaemonBase):
        elif key == "PortConfigDone":
            self.port_config_done = True

+    def appdb_contains_lldp_port(self):


let's make it utility function and add in device_info.py as rename something as is_frontend_port_present_in_host()

let's make it utility function and add in device_info.py as rename something as is_frontend_port_present_in_host()

Addressed the comment as the suggestion. Define the utility function `is_frontend_port_present_in_host()' in the device_inof.py and use it in the lldpmgrd file

abdosi

as added in comments

mlok-nokia · 2023-06-03T20:19:30Z

@abdosi Your comment has been addressed. Please review it again. Thanks

… contain front pannel ports Signed-off-by: mlok <marty.lok@nokia.com>

abdosi · 2023-06-13T00:42:44Z

/azp run Azure.sonic-buildimage

azure-pipelines · 2023-06-13T00:42:54Z

Azure Pipelines successfully started running 1 pipeline(s).

mlok-nokia · 2023-06-22T14:44:44Z

@abdosi @rlhui Could you please help to merge this PR?

abdosi · 2023-06-23T05:48:34Z

@yxieca can you please help merge this.

mssonicbld · 2023-06-23T17:02:40Z

Cherry-pick PR to 202305: #15603

gechiang · 2023-06-23T21:13:44Z

@mlok-nokia Goot catch! I have removed the wrong label and added the 202211 branch label.

Also, can you comment if this change was tested with the 202205 branch already or only on master branch?
Thanks!

mlok-nokia · 2023-06-28T15:47:11Z

@mlok-nokia Goot catch! I have removed the wrong label and added the 202211 branch label.

Also, can you comment if this change was tested with the 202205 branch already or only on master branch? Thanks!

Change has been tested on 202205 branch as well as master branch.

… contain front panel ports (sonic-net#14814) * [chassis][lldp] Fix the lldp error log in host instance which doesn't contain front pannel ports --------- Signed-off-by: mlok <marty.lok@nokia.com>

… contain front panel ports (#14814) (#15603)

… contain front panel ports (sonic-net#14814) * [chassis][lldp] Fix the lldp error log in host instance which doesn't contain front pannel ports --------- Signed-off-by: mlok <marty.lok@nokia.com>

mssonicbld · 2023-06-29T20:39:05Z

Cherry-pick PR to 202205: #15669

… contain front panel ports (sonic-net#14814) * [chassis][lldp] Fix the lldp error log in host instance which doesn't contain front pannel ports --------- Signed-off-by: mlok <marty.lok@nokia.com>

mssonicbld · 2023-06-29T20:39:08Z

Cherry-pick PR to 202211: #15670

… contain front panel ports (#14814) (#15670)

… contain front panel ports (#14814) (#15669) * [chassis][lldp] Fix the lldp error log in host instance which doesn't contain front pannel ports --------- Signed-off-by: mlok <marty.lok@nokia.com> Co-authored-by: Marty Y. Lok <76118573+mlok-nokia@users.noreply.github.com>

… contain front panel ports (sonic-net#14814) * [chassis][lldp] Fix the lldp error log in host instance which doesn't contain front pannel ports --------- Signed-off-by: mlok <marty.lok@nokia.com>

Highlight change, the DHCP config removed from master branch. files/image_config/resolv-config/resolv.conf Related work items: sonic-net#49, sonic-net#2598, sonic-net#11862, sonic-net#12530, sonic-net#14000, sonic-net#14549, sonic-net#14814, sonic-net#15077, sonic-net#15252, sonic-net#15253, sonic-net#15357, sonic-net#15384, sonic-net#15394, sonic-net#15399, sonic-net#15405, sonic-net#15566, sonic-net#15591, sonic-net#15592, sonic-net#15593, sonic-net#15602, sonic-net#15604, sonic-net#15611, sonic-net#15621, sonic-net#15625, sonic-net#15634, sonic-net#15635

Merge code from master to internal Related work items: sonic-net#32, sonic-net#49, sonic-net#376, sonic-net#2598, sonic-net#11862, sonic-net#12530, sonic-net#14000, sonic-net#14547, sonic-net#14549, sonic-net#14814, sonic-net#15077, sonic-net#15239, sonic-net#15252, sonic-net#15253, sonic-net#15298, sonic-net#15357, sonic-net#15384, sonic-net#15394, sonic-net#15399, sonic-net#15405, sonic-net#15511, sonic-net#15566, sonic-net#15583, sonic-net#15591, sonic-net#15592, sonic-net#15593, sonic-net#15602, sonic-net#15604, sonic-net#15611, sonic-net#15621, sonic-net#15625, sonic-net#15634, sonic-net#15635, sonic-net#15645, sonic-net#15646, sonic-net#15647, sonic-net#15657, sonic-net#15658, sonic-net#15697, sonic-net#15699

mlok-nokia requested a review from lguohan as a code owner April 23, 2023 20:54

rlhui assigned mlok-nokia Apr 24, 2023

mlok-nokia mentioned this pull request Apr 26, 2023

Chassis: ERR lldp#lldpmgrd[31]: Port init timeout reached (300 seconds), resuming lldpd... #14251

Closed

mlok-nokia force-pushed the fix-lldp-error-log branch 2 times, most recently from b9bc9d6 to 8ccdcb6 Compare May 1, 2023 15:00

rlhui requested a review from abdosi May 3, 2023 17:13

abdosi reviewed May 8, 2023

View reviewed changes

abdosi requested changes May 8, 2023

View reviewed changes

mlok-nokia force-pushed the fix-lldp-error-log branch from 8ccdcb6 to 4406ebc Compare June 3, 2023 20:15

mlok-nokia force-pushed the fix-lldp-error-log branch from 4406ebc to 37d6d36 Compare June 6, 2023 04:38

mlok-nokia added 2 commits June 8, 2023 11:42

[chassis][lldp] Fix the lldp error log in host instance which doesn't…

18031dd

… contain front pannel ports Signed-off-by: mlok <marty.lok@nokia.com>

[lldpmgrd] Address the review comment

e126e37

mlok-nokia force-pushed the fix-lldp-error-log branch from 37d6d36 to e126e37 Compare June 8, 2023 15:43

abdosi approved these changes Jun 12, 2023

View reviewed changes

abdosi added Request for 202205 Branch Request for 202111 Branch For PRs being requested for 202111 branch labels Jun 12, 2023

rlhui merged commit 16bb026 into sonic-net:master Jun 23, 2023
19 checks passed

gechiang added the Approved for 202305 Branch label Jun 23, 2023

mssonicbld added the Created PR to 202305 Branch label Jun 23, 2023

gechiang removed the Approved for 202305 Branch label Jun 23, 2023

gechiang added Request for 202211 Branch and removed Request for 202111 Branch For PRs being requested for 202111 branch labels Jun 23, 2023

StormLiangMS added the Approved for 202305 Branch label Jun 29, 2023

mssonicbld added a commit that referenced this pull request Jun 29, 2023

[chassis][lldp] Fix the lldp error log in host instance which doesn't…

2fc98cd

… contain front panel ports (#14814) (#15603)

mssonicbld added the Included in 202305 Branch label Jun 29, 2023

yxieca added Approved for 202205 Branch Approved for 202211 Branch labels Jun 29, 2023

mssonicbld added the Created PR to 202205 Branch label Jun 29, 2023

mssonicbld added the Created PR to 202211 Branch label Jun 29, 2023

This was referenced Jun 29, 2023

[action] [PR:14814] [chassis][lldp] Fix the lldp error log in host instance which doesn't contain front panel ports #15669

Merged

[action] [PR:14814] [chassis][lldp] Fix the lldp error log in host instance which doesn't contain front panel ports #15670

Merged

mssonicbld added a commit that referenced this pull request Jun 30, 2023

[chassis][lldp] Fix the lldp error log in host instance which doesn't…

e4a7a53

… contain front panel ports (#14814) (#15670)

mssonicbld added Included in 202211 Branch and removed Approved for 202211 Branch Created PR to 202211 Branch labels Jun 30, 2023

mssonicbld added Included in 202205 Branch and removed Approved for 202205 Branch Created PR to 202205 Branch labels Jun 30, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[chassis][lldp] Fix the lldp error log in host instance which doesn't contain front panel ports #14814

[chassis][lldp] Fix the lldp error log in host instance which doesn't contain front panel ports #14814

mlok-nokia commented Apr 23, 2023 •

edited by abdosi

Loading

mlok-nokia commented Apr 23, 2023

mlok-nokia commented Apr 24, 2023

mlok-nokia commented May 1, 2023

abdosi May 8, 2023

mlok-nokia Jun 3, 2023

abdosi left a comment

mlok-nokia commented Jun 3, 2023

abdosi commented Jun 13, 2023

azure-pipelines bot commented Jun 13, 2023

mlok-nokia commented Jun 22, 2023

abdosi commented Jun 23, 2023

mssonicbld commented Jun 23, 2023

gechiang commented Jun 23, 2023 •

edited

Loading

mlok-nokia commented Jun 28, 2023

mssonicbld commented Jun 29, 2023

mssonicbld commented Jun 29, 2023

[chassis][lldp] Fix the lldp error log in host instance which doesn't contain front panel ports #14814

[chassis][lldp] Fix the lldp error log in host instance which doesn't contain front panel ports #14814

Conversation

mlok-nokia commented Apr 23, 2023 • edited by abdosi Loading

Why I did it

Work item tracking

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

mlok-nokia commented Apr 23, 2023

mlok-nokia commented Apr 24, 2023

mlok-nokia commented May 1, 2023

abdosi May 8, 2023

Choose a reason for hiding this comment

mlok-nokia Jun 3, 2023

Choose a reason for hiding this comment

abdosi left a comment

Choose a reason for hiding this comment

mlok-nokia commented Jun 3, 2023

abdosi commented Jun 13, 2023

azure-pipelines bot commented Jun 13, 2023

mlok-nokia commented Jun 22, 2023

abdosi commented Jun 23, 2023

mssonicbld commented Jun 23, 2023

gechiang commented Jun 23, 2023 • edited Loading

mlok-nokia commented Jun 28, 2023

mssonicbld commented Jun 29, 2023

mssonicbld commented Jun 29, 2023

mlok-nokia commented Apr 23, 2023 •

edited by abdosi

Loading

gechiang commented Jun 23, 2023 •

edited

Loading