Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sonic-pit] Add PIT(Platform Integration Test) feature, second part, … #12530

Merged
merged 3 commits into from
Jun 27, 2023

Conversation

clarklee-guizhao
Copy link
Contributor

…add 6 test cases.

Signed-off-by: Li Hua guizhao.lh@alibaba-inc.com

Why I did it

sonic-pit is originated from S3IP(Simplify Switch System Integration Program) PIT(Platform Integration Test). It's designed to verify switch devices in the process of development, manufacturing and delivering stages. It focus on 2 roles: ODM and user. ODM may use PIT in developing and manufaturing stages, user may use PIT in delivery stage for acceptance test. It aims to provide an verify system for siwtch devices' hardware, drivers and firmware. More information, see HLD: https://github.com/clarklee-guizhao/SONiC/blob/pit/doc/pit/Platform_Integration_Test_high_level_design.md

How I did it

Porting sonic-pit from S3IP-PIT, make the original code clean enough, add PIT source as sonic-pit, add PIT running environment as docker-pit.
The whole PIT system is divided into several PR, this is the second PR with 6 test cases only.

How to verify it

First of all, this PR should be merged with the first PR(which has the PIT framework). After a sucessful build, copy sonic_pit-1.0-py3-none-any.whl to your device running sonic, install it with pip install sonic_pit-1.0-py3-none-any.whl, then run '/usr/local/pit-sysdiag/src/sysdiag -d' to start test.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205

Description for the changelog

Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

…add 6 test cases.

Signed-off-by: Li Hua <guizhao.lh@alibaba-inc.com>
Signed-off-by: Li Hua <guizhao.lh@alibaba-inc.com>
@lgtm-com
Copy link

lgtm-com bot commented Oct 27, 2022

This pull request introduces 9 alerts when merging 5812398 into 3df031c - view on LGTM.com

new alerts:

  • 3 for Unused local variable
  • 3 for Except block handles 'BaseException'
  • 3 for Variable defined multiple times

@clarklee-guizhao
Copy link
Contributor Author

clarklee-guizhao commented Oct 31, 2022

Add PIT HLD document. sonic-net/SONiC#1014

@clarklee-guizhao
Copy link
Contributor Author

@lguohan Hi Guohan, please help review this PR, thanks. This is the second part of sonic-pit, which only inlucde some test case logic.

src/sonic-pit/pit-sysdiag/src/ssd_tc.py Outdated Show resolved Hide resolved
src/sonic-pit/pit-sysdiag/src/memory_tc.py Outdated Show resolved Hide resolved
@zhangyanzhao
Copy link
Collaborator

@lguohan can you please check if this can be merged? Thanks.

@zhangyanzhao
Copy link
Collaborator

/azpw run

@lguohan lguohan merged commit 8b21b61 into sonic-net:master Jun 27, 2023
sonic-otn pushed a commit to sonic-otn/sonic-buildimage that referenced this pull request Sep 20, 2023
sonic-net#12530)

* [sonic-pit] Add PIT(Platform Integration Test) feature, second part, add 6 test cases.

Signed-off-by: Li Hua <guizhao.lh@alibaba-inc.com>

* Add missing test case configuration and platform configuration.

Signed-off-by: Li Hua <guizhao.lh@alibaba-inc.com>

* Remove unsed comment, replace duplicated function with import from other moduls.

---------

Signed-off-by: Li Hua <guizhao.lh@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants