[SONiC Telemetry]: Fix the problem of ENABLE_SYSTEM_TELEMETRY not taking effect in rules… #1615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/config Signed-off-by: Jipan Yang <jipan.yang@alibaba-inc.com>
rodnymolina
approved these changes
Apr 18, 2018
lguohan
approved these changes
Apr 18, 2018
zhenggen-xu
added a commit
to zhenggen-xu/sonic-buildimage
that referenced
this pull request
Oct 17, 2019
… in rules/config (sonic-net#1615) RB=1334542 G=lnos-reviewers R=pchaudha,pmao,rmolina,zxu A=
4 tasks
lguohan
pushed a commit
that referenced
this pull request
Feb 6, 2021
…#6701) sonic-swss: - [Mux] Route handling based on mux status, kernel tunnel support (#1615) - Reduce noise during frequent route update (#1624) - Changed Error log to Notice log during FDB flush notification after VLAN delete (#1618) - [PortsOrch] Add reference counting to ports for ACL bindings (#1614) - [crm]: Ignore unsupported/non-implemented switch attributes (#1613) - [Mux] Fix repeating logs in case of tunnel creation fail (#1610) sonic-utilities: - [config reload]: Restart mux container (#1401) - [storyteller] Enhance the storyteller utility (#1400) - [show] Fix int status when portchannel is in the system (#1376) - [config][show] cli support for retrieving ber, eye-info and configuring prbs, loopback on Y-cable (#1386) - Skip route check for tun0 interfaces (#1399) - do not parse stderr to get correct routing stack (#1398) - [storyteller] allow storyteller to work on downloaded logs (#1388) - [show] Run fwutil with sudo (#1364) Signed-off-by: Danny Allen <daall@microsoft.com>
prsunny
added a commit
that referenced
this pull request
Mar 8, 2021
yxieca
added a commit
to yxieca/sonic-buildimage
that referenced
this pull request
May 28, 2021
sonic-utilities: * 8b98d45 2021-05-25 | [show] support for show muxcable firmware version of only active banks (sonic-net#1629) (HEAD -> 202012) [vdahiya12] * afd0975 2021-05-20 | [show] add support for muxcable metrics (sonic-net#1615) [vdahiya12] sonic-swss * 7611df5 2021-05-27 | [tunneldecaporch] Set default MTU for the overlay loopback interface (sonic-net#1756) (HEAD -> 202012) [Volodymyr Samotiy] * 22fbb5c 2021-05-27 | [202012] Resolve neighbor when nexthop does not exist (sonic-net#1759) (github/202012) [Shi Su] * ec7710c 2021-05-27 | [Bulk mode] Limit the size of bulker (sonic-net#1760) [Shi Su] Signed-off-by: Ying Xie <ying.xie@microsoft.com>
yxieca
added a commit
that referenced
this pull request
May 28, 2021
sonic-utilities: * 8b98d45 2021-05-25 | [show] support for show muxcable firmware version of only active banks (#1629) (HEAD -> 202012) [vdahiya12] * afd0975 2021-05-20 | [show] add support for muxcable metrics (#1615) [vdahiya12] sonic-swss * 7611df5 2021-05-27 | [tunneldecaporch] Set default MTU for the overlay loopback interface (#1756) (HEAD -> 202012) [Volodymyr Samotiy] * 22fbb5c 2021-05-27 | [202012] Resolve neighbor when nexthop does not exist (#1759) (github/202012) [Shi Su] * ec7710c 2021-05-27 | [Bulk mode] Limit the size of bulker (#1760) [Shi Su] Signed-off-by: Ying Xie <ying.xie@microsoft.com>
lguohan
pushed a commit
that referenced
this pull request
Jun 17, 2021
19615e3 Fixing db_migrator for Feature table (#1674) d1c1c61 [tests]: skip some dynamic port breakout unit tests (#1677) 25669c3 [CI] sonic-config-engine now depends on SONiC YANG packages (#1675) 3ff68c4 [neighbor-advertiser] delete the tunnel maps appropriately (#1663) a425ca2 [config] support for configuring muxcable to manual mode of operation (#1642) 25e17de [show platform summary] Add chassis hardware info to platform summary and version (#1624) f5f2a00 [db_migrator] fix old 1911 feature config migration to a new one. (#1635) 56db162 [config] Fix config int add incorrect ip (#1414) 1da879c [db_migrator][Mellanox] Update Mellanox buffer migrator with 2km-cable supported (#1564) c2b760f [sonic_package_manager] flush once finished saving docker image into temporary file (#1638) cd69473 Replace swsssdk.ConfigDBConnector and SonicDBConfig with swsscommon implementation (#1620) 5f20365 Change to use rvtysh when calling the show commands (#1572) 51d6bf5 Fix Aboot breakage in sonic package manager in sonic-installer (#1625) 18bed46 [console][show] Force refresh all lines status during show line (#1641) b616cd9 [TPID CONFIG] Added TPID configuration CLI support (#1618) 01eb4b1 [show] support for show muxcable firmware version of only active banks (#1629) 7744c8d [fdb]cli: fdb entries are cleared according to vlan or port or vlan&&port (#657) e23c5ee Add psu hardware revision to psushow table (#1601) f1726fe Make advance_version_for_expected_database available for other db migrator test cases as well (#1614) 5d1ad05 [show] add support for muxcable metrics (#1615) feeab29 [config] Sort Config Db When Saving (#1623)
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
* [Submodule] Update sonic-swss till the commit: 0b0d24c - 2021-02-04 : [Mux] Route handling based on mux status, kernel tunnel support (sonic-net#1615) [Prince Sunny]
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
19615e3 Fixing db_migrator for Feature table (sonic-net#1674) d1c1c61 [tests]: skip some dynamic port breakout unit tests (sonic-net#1677) 25669c3 [CI] sonic-config-engine now depends on SONiC YANG packages (sonic-net#1675) 3ff68c4 [neighbor-advertiser] delete the tunnel maps appropriately (sonic-net#1663) a425ca2 [config] support for configuring muxcable to manual mode of operation (sonic-net#1642) 25e17de [show platform summary] Add chassis hardware info to platform summary and version (sonic-net#1624) f5f2a00 [db_migrator] fix old 1911 feature config migration to a new one. (sonic-net#1635) 56db162 [config] Fix config int add incorrect ip (sonic-net#1414) 1da879c [db_migrator][Mellanox] Update Mellanox buffer migrator with 2km-cable supported (sonic-net#1564) c2b760f [sonic_package_manager] flush once finished saving docker image into temporary file (sonic-net#1638) cd69473 Replace swsssdk.ConfigDBConnector and SonicDBConfig with swsscommon implementation (sonic-net#1620) 5f20365 Change to use rvtysh when calling the show commands (sonic-net#1572) 51d6bf5 Fix Aboot breakage in sonic package manager in sonic-installer (sonic-net#1625) 18bed46 [console][show] Force refresh all lines status during show line (sonic-net#1641) b616cd9 [TPID CONFIG] Added TPID configuration CLI support (sonic-net#1618) 01eb4b1 [show] support for show muxcable firmware version of only active banks (sonic-net#1629) 7744c8d [fdb]cli: fdb entries are cleared according to vlan or port or vlan&&port (sonic-net#657) e23c5ee Add psu hardware revision to psushow table (sonic-net#1601) f1726fe Make advance_version_for_expected_database available for other db migrator test cases as well (sonic-net#1614) 5d1ad05 [show] add support for muxcable metrics (sonic-net#1615) feeab29 [config] Sort Config Db When Saving (sonic-net#1623)
theasianpianist
pushed a commit
to theasianpianist/sonic-buildimage
that referenced
this pull request
Feb 5, 2022
…c-net#1615) Program/Reprogram routes to hardware based on Mux status Create tunnel interface (tun0) in kernel Add/remove tunnel routes in kernel
taras-keryk
pushed a commit
to taras-keryk/sonic-buildimage
that referenced
this pull request
Apr 28, 2022
* [show] add support for muxcable metrics
What I did
Added support for show muxcable metrics. This essentially records what events came to different modules per se
for toggling the mux from one state to another.
for example
admin@sonic$ show muxcable metrics Ethernet0 --json
{
"linkmgrd_switch_active_start": "2021-May-13 10:00:21.420898",
"linkmgrd_switch_standby_end": "2021-May-13 10:01:15.696728",
"linkmgrd_switch_unknown_end": "2021-May-13 10:00:26.123319",
"xcvrd_switch_standby_end": "2021-May-13 10:01:15.696051",
"xcvrd_switch_standby_start": "2021-May-13 10:01:15.690835"
}
or
admin@sonic:$ show muxcable metrics Ethernet0
PORT EVENT TIME
--------- ---------------------------- ---------------------------
Ethernet0 linkmgrd_switch_active_start 2021-May-13 10:00:21.420898
Ethernet0 linkmgrd_switch_standby_end 2021-May-13 10:01:15.696728
Ethernet0 linkmgrd_switch_unknown_end 2021-May-13 10:00:26.123319
Ethernet0 xcvrd_switch_standby_end 2021-May-13 10:01:15.696051
Ethernet0 xcvrd_switch_standby_start 2021-May-13 10:01:15.690835
How I did it
added changes in show/muxcable.py by reading and publishing the state DB contents for the corresponding table
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…/config
Signed-off-by: Jipan Yang jipan.yang@alibaba-inc.com
- What I did
The value of ENABLE_SYSTEM_TELEMETRY in Makefile overwrites the same ENABLE_SYSTEM_TELEMETRY defined in rules/config. By default it is empty, the value specified in rules/config won't take effect.
Use temporary SONIC_ENABLE_SYSTEM_TELEMETRY to take the value specified at make configure, so value defined in rules/config takes precedence if specified there.
- How I did it
With this patch, uncomment "ENABLE_SYSTEM_TELEMETRY = y", telemetry docker will be created.
Previously only make command like "make configure ENABLE_SYSTEM_TELEMETRY=y PLATFORM=broadcom" worked.
$ make configure PLATFORM=broadcom
SONiC Build System
Build Configuration
"CONFIGURED_PLATFORM" : "broadcom"
"SONIC_CONFIG_PRINT_DEPENDENCIES" : ""
"SONIC_BUILD_JOBS" : "8"
"SONIC_CONFIG_MAKE_JOBS" : "8"
"DEFAULT_USERNAME" : "admin"
"DEFAULT_PASSWORD" : "admin"
"ENABLE_DHCP_GRAPH_SERVICE" : ""
"SHUTDOWN_BGP_ON_START" : ""
"ENABLE_PFCWD_ON_START" : "y"
"SONIC_CONFIG_DEBUG" : "y"
"ROUTING_STACK" : "quagga"
"ENABLE_SYNCD_RPC" : ""
"ENABLE_ORGANIZATION_EXTENSIONS" : "y"
"HTTP_PROXY" : ""
"HTTPS_PROXY" : ""
"ENABLE_SYSTEM_TELEMETRY" : "y"
- How to verify it