Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docker-platform-monitor] Convert ledd from polling-based to subscription-based model #1623

Merged
merged 2 commits into from
Apr 20, 2018
Merged

[docker-platform-monitor] Convert ledd from polling-based to subscription-based model #1623

merged 2 commits into from
Apr 20, 2018

Conversation

jleveque
Copy link
Contributor

- What I did

  • Instead of polling State DB for link state changes, ledd now subscribes for changes to PORT_TABLE and reacts to notifications.
  • Also clean up Dockerfile.j2 template for docker-platform-monitor

- How to verify it

  • Flap all links and verify respective front panel LEDs turn on when link is up and off when link is down.

@jleveque jleveque self-assigned this Apr 19, 2018
@jleveque jleveque requested a review from lguohan April 19, 2018 19:41
@jleveque jleveque changed the title [sonic-platform-daemons] Convert ledd from polling-based to subscription-based model [docker-platform-monitor] Convert ledd from polling-based to subscription-based model Apr 19, 2018
@jleveque jleveque merged commit 1df7c9a into sonic-net:master Apr 20, 2018
@jleveque jleveque deleted the ledd_notifications branch April 20, 2018 17:42
yxieca added a commit to yxieca/sonic-buildimage that referenced this pull request Apr 8, 2021
@yxieca
[202012][swss][utilities] advance submodule heads
ab85469 
SWSS:
* d97c7c7 2021-04-07 | [Dynamic Buffer Calc] Enhancement: coding style and LGTM alerts (sonic-net#1693) (HEAD -> 202012) [Stephen Sun]
* f70b3da 2021-04-03 | [Makefile] Reorder libsaimetadata and libswsscommon (sonic-net#1689) [Kamil Cudnik]
* 72ae85d 2021-04-08 | [vlan] Add support of VLAN host interface (sonic-net#1645) [Volodymyr Samotiy]
* a555b9c 2021-04-02 | Correct the sflow default sample rate (sonic-net#1623) [fredyu190011]

Utilities:
* 1a789d2 2021-04-07 | Fixed the possibility of using uninitialized variable in route_check.py (sonic-net#1551) (HEAD -> 202012) [Renuka Manavalan]
* 2412e3c 2021-04-06 | Fix fast-reboot-dump.py SonicV2Connector after late merge (sonic-net#1546) [shlomibitton]
* f99c5f1 2021-04-02 | [fast-reboot] Fix dump script to support PortChannels in a VLAN group (sonic-net#1393) [shlomibitton]
* 716e2af 2021-04-04 | Reduce time taken by show commands on multi-asic platforms (sonic-net#1544) [abdosi]
* a160519 2021-04-03 | [setup.py]: move the module to test requirement (sonic-net#1542) [lguohan]
* eaa67fe 2021-04-04 | [config] Eliminate race condition between reloading Monit config and (sonic-net#1543) [yozhao101]
* 2497a9e 2021-04-03 | [reboot] No need enable the Linux magic system request key (sonic-net#1538) [yozhao101]
* 9fda6fe 2021-04-06 | [fwutil]: Fix next image mount (sonic-net#1533) [Nazarii Hnydyn]
* 9af50fe 2021-02-09 | Import 'mock' module from 'unittest' library (sonic-net#1415) (HEAD -> 202012) [Joe LeVeque]

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
@yxieca yxieca mentioned this pull request Apr 8, 2021
Merged
lguohan pushed a commit that referenced this pull request Apr 8, 2021
@stepanblyschak
[sonic-swss] update sonic-swss submodule (#7263)
4351db7 
5c63670 (HEAD, origin/master, origin/HEAD) [intfmgrd] reach reconciled state at start when there are no interfaces configuration to process (#1695)
66e1aab [Dynamic Buffer Calc] Enhancement: coding style and LGTM alerts (#1693)
637e8d0 Skip Macsec test case till macsec orch code is made SAIv1.8.0 compatible (#1688)
872b5cb [ci]: archive swss pytests (#1690)
73cbd91 [Makefile] Reorder libsaimetadata and libswsscommon (#1689)
cba6576 Correct the sflow default sample rate (#1623)
aac71e6 Don't update pools when ingress_lossless_pool is created but the initialization hasn't finished yet (#1685)
ae5f051 Fix dynamic buffer bug occuring in rare condition (#1678)
691bd30 [voq/systemlag] Voq system lag functionality (#1605)

Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
yxieca added a commit that referenced this pull request Apr 9, 2021
@yxieca
[202012][swss][utilities] advance submodule heads (#7267)
4a54148 
SWSS:
* d97c7c7 2021-04-07 | [Dynamic Buffer Calc] Enhancement: coding style and LGTM alerts (#1693) (HEAD -> 202012) [Stephen Sun]
* f70b3da 2021-04-03 | [Makefile] Reorder libsaimetadata and libswsscommon (#1689) [Kamil Cudnik]
* 72ae85d 2021-04-08 | [vlan] Add support of VLAN host interface (#1645) [Volodymyr Samotiy]
* a555b9c 2021-04-02 | Correct the sflow default sample rate (#1623) [fredyu190011]

Utilities:
* 1a789d2 2021-04-07 | Fixed the possibility of using uninitialized variable in route_check.py (#1551) (HEAD -> 202012) [Renuka Manavalan]
* 2412e3c 2021-04-06 | Fix fast-reboot-dump.py SonicV2Connector after late merge (#1546) [shlomibitton]
* f99c5f1 2021-04-02 | [fast-reboot] Fix dump script to support PortChannels in a VLAN group (#1393) [shlomibitton]
* 716e2af 2021-04-04 | Reduce time taken by show commands on multi-asic platforms (#1544) [abdosi]
* a160519 2021-04-03 | [setup.py]: move the module to test requirement (#1542) [lguohan]
* eaa67fe 2021-04-04 | [config] Eliminate race condition between reloading Monit config and (#1543) [yozhao101]
* 2497a9e 2021-04-03 | [reboot] No need enable the Linux magic system request key (#1538) [yozhao101]
* 9fda6fe 2021-04-06 | [fwutil]: Fix next image mount (#1533) [Nazarii Hnydyn]
* 9af50fe 2021-02-09 | Import 'mock' module from 'unittest' library (#1415) (HEAD -> 202012) [Joe LeVeque]

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
raphaelt-nvidia pushed a commit to raphaelt-nvidia/sonic-buildimage that referenced this pull request May 23, 2021
@stepanblyschak @raphaelt-nvidia
[sonic-swss] update sonic-swss submodule (sonic-net#7263)
f274f3f 
5c63670 (HEAD, origin/master, origin/HEAD) [intfmgrd] reach reconciled state at start when there are no interfaces configuration to process (sonic-net#1695)
66e1aab [Dynamic Buffer Calc] Enhancement: coding style and LGTM alerts (sonic-net#1693)
637e8d0 Skip Macsec test case till macsec orch code is made SAIv1.8.0 compatible (sonic-net#1688)
872b5cb [ci]: archive swss pytests (sonic-net#1690)
73cbd91 [Makefile] Reorder libsaimetadata and libswsscommon (sonic-net#1689)
cba6576 Correct the sflow default sample rate (sonic-net#1623)
aac71e6 Don't update pools when ingress_lossless_pool is created but the initialization hasn't finished yet (sonic-net#1685)
ae5f051 Fix dynamic buffer bug occuring in rare condition (sonic-net#1678)
691bd30 [voq/systemlag] Voq system lag functionality (sonic-net#1605)

Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
@dprital dprital mentioned this pull request Jun 14, 2021
Closed
@alexrallen alexrallen mentioned this pull request Jun 14, 2021
Merged
dgsudharsan added a commit to dgsudharsan/sonic-buildimage that referenced this pull request Jun 16, 2021
@dgsudharsan
sonic-utilities submodule update
90ae39c 
d86d765 [202012]Fixing db_migrator for Feature table (sonic-net#1676)
440b0f4 [config] Sort Config Db When Saving (sonic-net#1623) (sonic-net#1651)
@dgsudharsan dgsudharsan mentioned this pull request Jun 16, 2021
Merged
4 tasks
liat-grozovik pushed a commit that referenced this pull request Jun 16, 2021
@dgsudharsan
[202012][sonic-utilities] submodule update (#7891)
199c75f 
d86d765 [202012]Fixing db_migrator for Feature table (#1676)
440b0f4 [config] Sort Config Db When Saving (#1623) (#1651)
lguohan pushed a commit that referenced this pull request Jun 17, 2021
@alexrallen
[sonic-utilities] submodule update (#7799)
f39fc88 
19615e3 Fixing db_migrator for Feature table (#1674)
d1c1c61 [tests]: skip some dynamic port breakout unit tests (#1677)
25669c3 [CI] sonic-config-engine now depends on SONiC YANG packages (#1675)
3ff68c4 [neighbor-advertiser] delete the tunnel maps appropriately (#1663)
a425ca2 [config] support for configuring muxcable to manual mode of operation  (#1642)
25e17de [show platform summary] Add chassis hardware info to platform summary and version (#1624)
f5f2a00 [db_migrator] fix old 1911 feature config migration to a new one. (#1635)
56db162 [config] Fix config int add incorrect ip (#1414)
1da879c [db_migrator][Mellanox] Update Mellanox buffer migrator with 2km-cable supported (#1564)
c2b760f [sonic_package_manager] flush once finished saving docker image into temporary file (#1638)
cd69473 Replace swsssdk.ConfigDBConnector and SonicDBConfig with swsscommon implementation (#1620)
5f20365 Change to use rvtysh when calling the show commands (#1572)
51d6bf5 Fix Aboot breakage in sonic package manager in sonic-installer (#1625)
18bed46 [console][show] Force refresh all lines status during show line (#1641)
b616cd9 [TPID CONFIG] Added TPID configuration CLI support (#1618)
01eb4b1 [show] support for show muxcable firmware version of only active banks (#1629)
7744c8d [fdb]cli: fdb entries are cleared according to vlan or port or vlan&&port (#657)
e23c5ee Add psu hardware revision to psushow table (#1601)
f1726fe Make advance_version_for_expected_database available for other db migrator test cases as well (#1614)
5d1ad05 [show] add support for muxcable metrics (#1615)
feeab29 [config] Sort Config Db When Saving (#1623)
carl-nokia pushed a commit to carl-nokia/sonic-buildimage that referenced this pull request Aug 7, 2021
@stepanblyschak
[sonic-swss] update sonic-swss submodule (sonic-net#7263)
16f00b9 
5c63670 (HEAD, origin/master, origin/HEAD) [intfmgrd] reach reconciled state at start when there are no interfaces configuration to process (sonic-net#1695)
66e1aab [Dynamic Buffer Calc] Enhancement: coding style and LGTM alerts (sonic-net#1693)
637e8d0 Skip Macsec test case till macsec orch code is made SAIv1.8.0 compatible (sonic-net#1688)
872b5cb [ci]: archive swss pytests (sonic-net#1690)
73cbd91 [Makefile] Reorder libsaimetadata and libswsscommon (sonic-net#1689)
cba6576 Correct the sflow default sample rate (sonic-net#1623)
aac71e6 Don't update pools when ingress_lossless_pool is created but the initialization hasn't finished yet (sonic-net#1685)
ae5f051 Fix dynamic buffer bug occuring in rare condition (sonic-net#1678)
691bd30 [voq/systemlag] Voq system lag functionality (sonic-net#1605)

Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
carl-nokia pushed a commit to carl-nokia/sonic-buildimage that referenced this pull request Aug 7, 2021
@alexrallen
[sonic-utilities] submodule update (sonic-net#7799)
ca0264b 
19615e3 Fixing db_migrator for Feature table (sonic-net#1674)
d1c1c61 [tests]: skip some dynamic port breakout unit tests (sonic-net#1677)
25669c3 [CI] sonic-config-engine now depends on SONiC YANG packages (sonic-net#1675)
3ff68c4 [neighbor-advertiser] delete the tunnel maps appropriately (sonic-net#1663)
a425ca2 [config] support for configuring muxcable to manual mode of operation  (sonic-net#1642)
25e17de [show platform summary] Add chassis hardware info to platform summary and version (sonic-net#1624)
f5f2a00 [db_migrator] fix old 1911 feature config migration to a new one. (sonic-net#1635)
56db162 [config] Fix config int add incorrect ip (sonic-net#1414)
1da879c [db_migrator][Mellanox] Update Mellanox buffer migrator with 2km-cable supported (sonic-net#1564)
c2b760f [sonic_package_manager] flush once finished saving docker image into temporary file (sonic-net#1638)
cd69473 Replace swsssdk.ConfigDBConnector and SonicDBConfig with swsscommon implementation (sonic-net#1620)
5f20365 Change to use rvtysh when calling the show commands (sonic-net#1572)
51d6bf5 Fix Aboot breakage in sonic package manager in sonic-installer (sonic-net#1625)
18bed46 [console][show] Force refresh all lines status during show line (sonic-net#1641)
b616cd9 [TPID CONFIG] Added TPID configuration CLI support (sonic-net#1618)
01eb4b1 [show] support for show muxcable firmware version of only active banks (sonic-net#1629)
7744c8d [fdb]cli: fdb entries are cleared according to vlan or port or vlan&&port (sonic-net#657)
e23c5ee Add psu hardware revision to psushow table (sonic-net#1601)
f1726fe Make advance_version_for_expected_database available for other db migrator test cases as well (sonic-net#1614)
5d1ad05 [show] add support for muxcable metrics (sonic-net#1615)
feeab29 [config] Sort Config Db When Saving (sonic-net#1623)
theasianpianist pushed a commit to theasianpianist/sonic-buildimage that referenced this pull request Feb 5, 2022
@fredyu190011
Correct the sflow default sample rate (sonic-net#1623)
cba6576 
According the PR: SONiC#746, the sample rate should be "ifSpeed / 1e6".

Signed-off-by: Fred Yu fred_yu@edge-core.com
taras-keryk pushed a commit to taras-keryk/sonic-buildimage that referenced this pull request Apr 28, 2022
@tahmed-dev
[config] Sort Config Db When Saving (sonic-net#1623)
feeab29 
Restored cfggen sort method of json data and used it to
sort config db before saving.

signed-off-by: Tamer Ahmed <tamer.ahmed@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lguohan lguohan lguohan approved these changes

Assignees

@jleveque jleveque

Labels
Enhancement ➕ Submodule Update ⏫
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jleveque @lguohan