[build] Fix frr dpkg cache calculation issue on symbolic link file. #16700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liushilongbuaa
requested review from
qiluo-msft,
xumia and
lguohan
as code owners
xumia
approved these changes
Sep 26, 2023
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Oct 10, 2023
…onic-net#16700) Why I did it Now build will fail on: fatal: Unable to hash src/sonic-frr/frr/tests/topotests/grpc_basic/lib fatal: Unable to hash src/sonic-frr/frr/tests/topotests/ospfapi/lib make: *** [Makefile.cache:528: target/debs/buster/frr_8.5.1-sonic-0_amd64.deb.smdep] Error 123 make: *** Waiting for unfinished jobs.... Root cause is that these files are symbol links. git hash-object can't hash symbol links. Work item tracking Microsoft ADO (number only): 25271730 How I did it These two files are symbol links. When calculate sha value, skip these two files.
|
Cherry-pick PR to 202305: #16819 |
Merged
11 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Oct 10, 2023
…16700) Why I did it Now build will fail on: fatal: Unable to hash src/sonic-frr/frr/tests/topotests/grpc_basic/lib fatal: Unable to hash src/sonic-frr/frr/tests/topotests/ospfapi/lib make: *** [Makefile.cache:528: target/debs/buster/frr_8.5.1-sonic-0_amd64.deb.smdep] Error 123 make: *** Waiting for unfinished jobs.... Root cause is that these files are symbol links. git hash-object can't hash symbol links. Work item tracking Microsoft ADO (number only): 25271730 How I did it These two files are symbol links. When calculate sha value, skip these two files.
mssonicbld
added
Included in 202305 Branch
and removed
Created PR to 202305 Branch
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Now build will fail on:
Root cause is that these files are symbol links.
git hash-object can't hash symbol links.
Work item tracking
How I did it
These two files are symbol links.
When calculate sha value, skip these two files.
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)