Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[201807][platform] Accton: As5712-54x. Fix sfputil and accton_util #2002

Merged
merged 2 commits into from
Aug 30, 2018
Merged

[201807][platform] Accton: As5712-54x. Fix sfputil and accton_util #2002

merged 2 commits into from
Aug 30, 2018

Conversation

roylee123
Copy link
Collaborator

  • What I did
    sfputil has some problem:
  1. CPU has 2 indigenous i2c buses, their order may get flipped on every boot.
  2. 4 of 6 QSFP's lp_mode and reset pin are not in order as port index.
  3. Use optoe2 for SFP+ ports.
  • How I did it
  1. Update accton_util to check order of i2c buses.
  2. Change sfputil.py for i2c bus flipping and validate lp_mode and reset commands.

  • How to verify it
    accton_as5712_util.py show
    psuutil status
    decode-syseeprom
    sfputil show presence
    sfputil show eeprom --dom
    sfputil show lpmode
    sfputil reset EthernetXX
    sfputil lpmode on EthernetXX

  • Description for the changelog

@roylee123
[platform] accton as5712-54x, fixed
543ff8d 
    1. Check i2c buses, they may get fliped on every bootup.
    2. QSFP's lp_mode and reset are out of port order.
    3. Change QSFP is reset with 1 second period.
Signed-off-by: roy_lee <roy_lee@accton.com>
@roylee123
[platform] accton as5712-54x. Fix util.py error about SFP/QSFP's tx_d…
de21387 
…isable and present.

Signed-off-by: roy_lee <roy_lee@accton.com>
@roylee123 roylee123 mentioned this pull request Aug 30, 2018
Open
@lguohan lguohan merged commit f07181e into sonic-net:201807 Aug 30, 2018
@roylee123 roylee123 mentioned this pull request Sep 3, 2018
Closed
roylee123 added a commit to roylee123/sonic-buildimage that referenced this pull request Oct 2, 2018
@roylee123
[platform] as5712-54x, merge the change of sonic-net#2002 which is on…
0b1daef 
… branch 201807.

Signed-off-by: roy_lee <roy_lee@accton.com>
lguohan pushed a commit that referenced this pull request Oct 2, 2018
@roylee123 @lguohan
[device] accton update driver and sync as5712-54x from 201807. (#2110)
593bcb1 
* [platform_accton] Remove dependency on particular version of linux.
Signed-off-by: Polly Hsu <polly_hsu@edge-core.com>

* [platfrom] as5712-54x: update i2c_client for linux kernel 4.x.
Signed-off-by: Polly Hsu <polly_hsu@edge-core.com>

* [platform] Update lastest optoe.c from https://github.com/opencomputeproject/oom/blob/master/optoe/optoe.c.
Signed-off-by: roy_lee <roy_lee@accton.com>

* [platform] rm optoe driver here. For it's inside the kernel.
Signed-off-by: roy_lee <roy_lee@accton.com>

* [platform] as5712-54x, merge the change of #2002 which is on branch 201807.
Signed-off-by: roy_lee <roy_lee@accton.com>
theasianpianist added a commit to theasianpianist/sonic-buildimage that referenced this pull request Sep 2, 2022
@theasianpianist
[sonic-util]: Submodule update:
cf9c516 
Include following commits:

414e239 update unit tests for swap allocator
a91a492 consider swap checking memory in installer
f0ce586 [route_check]: Ignore standalone tunnel routes (sonic-net#2325)
3af8ba4 Replace cmp in acl_loader with operator.eq (sonic-net#2328)
899ba12 Subinterface vrf bind issue fix (sonic-net#2211)
e45b47a [VRF]Adding CLI checks to ensure Vrf is valid in interface bind and static route commands (sonic-net#2333)
f82835e [doc]: Add MACsec CLI doc (sonic-net#2334)
666bdc0 [sonic-package-manager] Drop 'expires_in' (sonic-net#2002)
52ac8ac Handle non-front-panel ports in is_rj45_port (sonic-net#2327)
42ed6d5 [service_mgmt]: Fix fetch MULTI_INST_DEPENDENT bug in service_mgmt.sh.j2 (sonic-net#2319)
d1a2d72 correct an error by changing "show bgp summary" to "show bfd summary" (sonic-net#2324)
7d409a0 Update VRF unbind command (sonic-net#2331)
e14f679 Fix issue: port_type is referenced before initialized (sonic-net#2323)
7704f63 Fix issue: exception in is_rj45_port in multi ASIC env (sonic-net#2313)
6fc4f15 Delete .DS_Store (sonic-net#2244)
ece4049 Fix bug with checking VRF's routes in route_check.py  (sonic-net#2301)
20c6d18 [decode-syseeprom] Fix setting use_db based on support_eeprom_db (sonic-net#2270)
9282e6c Fix vrf UT failed issue (sonic-net#2309)
37eb2b3 add lacp_rate to portchannel (sonic-net#2036)

Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
liat-grozovik pushed a commit that referenced this pull request Sep 4, 2022
@dprital
[submodule]] Advance sonic-utilities pointer (#11897)
4e18510 
Update sonic-utilities submodule pointer to include the following:

Replace cmp in acl_loader with operator.eq (#2328)
Subinterface vrf bind issue fix (#2211)
[VRF]Adding CLI checks to ensure Vrf is valid in interface bind and static route commands (#2333)
[doc]: Add MACsec CLI doc (#2334)
[sonic-package-manager] Drop 'expires_in' (#2002)
Handle non-front-panel ports in is_rj45_port (#2327)
[service_mgmt]: Fix fetch MULTI_INST_DEPENDENT bug in service_mgmt.sh.j2 (#2319)
correct an error by changing "show bgp summary" to "show bfd summary" (#2324)
Update VRF unbind command (#2331)
Fix issue: port_type is referenced before initialized (#2323)
Fix issue: exception in is_rj45_port in multi ASIC env (#2313)
Delete .DS_Store (#2244)
Fix bug with checking VRF's routes in route_check.py (#2301)
[decode-syseeprom] Fix setting use_db based on support_eeprom_db (#2270)
Fix vrf UT failed issue (#2309)
add lacp_rate to portchannel (#2036)
@aravindmani-1 aravindmani-1 mentioned this pull request Nov 18, 2022
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug 🐛 Platform: Accton
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@roylee123 @lguohan @stcheng