[boot] Delay ntp-config service to start after 5 minutes #2494
Conversation
|
@nikos-github: Please refer to #2335. If you remember, we're now configuring NTP after all Dockers have started due to the fact Supervisor doesn't properly handle the clock rolling backward in between process state changes. We found that there was still a chance that ntp-config gets started while some Dockers were still starting up. This delay is to ensure that all Supervisor processes in all Dockers have finished starting up processes before NTP has a chance to roll the clock backward. This PR and #2335 are interim solutions until we can get a version of Supervisor which uses the monotonic clock. |
|
@jleveque @lguohan 5 mins is a long time to wait for ntp to start. We may as well not start it at all - why bother? :-) On a serious note, are we getting to a point where we either push supervisord to fix this or we fix it ourselves? Why have the dockers not started within 5 minutes? What if we find out there are cases where it's 10 minutes or 15? Clearly we hit such a case with the 5 minutes interval. |
Yes. I think we are going to have to fix it ourselves. |
|
@nikos-github , the docker started, it is just all the supervisord services in the docker needs time to start. Simply put the ntp after docker start is not enough, so we have to introduce the timer. Since this is a follow-up fix for the previous issue. It is better to have this in as a complete solution (workaround). |
There was a problem hiding this comment.
I hope we have a plan to fix this soon because it's not a good idea to have ntp syncrhonise the clock so late (and we can discuss why offline along with examples). BTW I haven't seen such a delay in the supervisord services inside the docker. Would be nice to know under what scenario this is observed.
|
Made to 201811 branch on 2/2/2019 |
…sonic-net#2494)" (sonic-net#2590) This reverts commit 33fe8d2.
…sonic-net#2494)" (sonic-net#2590) This reverts commit 33fe8d2.
…sonic-net#2494)" (sonic-net#2590) This reverts commit 33fe8d2.
… advance submodule heads utilities: * 0157086 2022-11-22 | [VXLAN]Fixing traceback in show remotemac when mac moves during command execution (sonic-net#2506) [Sudharsan Dhamal Gopalarathnam] * 1f26c8c 2022-11-17 | avoid printing error if no neighbors are present (sonic-net#2502) [arlakshm] * 2573aae 2022-11-19 | [sfp] Fix issue: Application Advertisement is not well formatted (sonic-net#2491) [Junchao-Mellanox] * 1d96b55 2022-11-10 | [show][muxcable] Catch port Value error exception (sonic-net#2076) (sonic-net#2486) [Isabella de Leon] * 6ed2afb 2022-11-09 | bugfix[2024] vnet route check exit code fix. (sonic-net#2480) [siqbal1986] * d8c49dc 2022-11-17 | Fixed SONIC_CLI_IFACE_MODE=alias show ip|ipv6 route output in default mode issue (sonic-net#2422) [Marty Y. Lok] * 166739e 2022-11-11 | Accept 0 for queue and dscp (sonic-net#2494) (github/202205) [bingwang-ms] swss: * 7e274a4 2022-11-18 | [Fdbsyncd] Bug Fix for remote MAC move to local MAC and Fix for Static MAC advertisement in EVPN. (sonic-net#2521) (HEAD -> 202205, github/202205) [KISHORE KUNAL] * 434e80c 2022-11-02 | Fix vs test issue: failed to remove vlan due to referenced by vlan interface (sonic-net#2504) [Stephen Sun] * 11bef87 2022-11-27 | [dual-tor] add missing SAI attribte in order to create IPNIP tunnel (sonic-net#2503) [Andriy Yurkiv] * 11aba29 2022-11-09 | [SWSS] Innovium platform specific changes in PFC Detect lua script (sonic-net#2493) [maulik_patel_marvell] * 4a165ee 2022-11-14 | Revert "[vlanmgr] Disable `arp_evict_nocarrier` for vlan host intf (sonic-net#2469)" (sonic-net#2518) [Longxiang Lyu] sairedis: * 98def2d 2022-11-16 | [Recorder]: Acquire lock for ofstream changes (sonic-net#1145) (HEAD -> 202205, github/202205) [Lawrence Lee] platform-daemon: * 9983106 2022-11-15 | [chassisd] update chassisd to write fabric and lc asics on sep erate table (sonic-net#311) (HEAD -> 202205) [arlakshm] * 8324c26 2022-11-10 | [ycabled] fix exception-handling logic for ycabled (sonic-net#306) [vdahiya12] * eaf73f8 2022-11-07 | [ycabled] move swsscommon API's from subroutines to call them exactly once per task_worker/thread (sonic-net#303) [vdahiya12] platform-common: * 4b528a0 2022-11-21 | Add missing PM and VDM related EEPROM read (sonic-net#326) (HEAD -> 202205) [mihirpat1] * 8ca6c17 2022-11-14 | Initial commit (sonic-net#323) [mihirpat1] * 47f87d9 2022-11-23 | EEPROM/DOM Info: The Compliance Code will show "unknown" by using FINISAR 10G LR XCVR (sonic-net#319) [ChiouRung Haung] * 6273850 2022-06-01 | [ssd_generic] Fix innodisk health regex (sonic-net#287) [Alexander Allen] Signed-off-by: Ying Xie <ying.xie@microsoft.com>
utilities: * 4b7335f 2022-11-29 | Add db_migrator_constants.py script to setup.py (#2534) (HEAD -> 202205) [Vaibhav Hemant Dixit] * 8a78cf4 2022-11-23 | Port 202012 DB migration changes to newer branches (#2515) (HEAD -> 202205) [Vaibhav Hemant Dixit] * 0157086 2022-11-22 | [VXLAN]Fixing traceback in show remotemac when mac moves during command execution (#2506) [Sudharsan Dhamal Gopalarathnam] * 1f26c8c 2022-11-17 | avoid printing error if no neighbors are present (#2502) [arlakshm] * 2573aae 2022-11-19 | [sfp] Fix issue: Application Advertisement is not well formatted (#2491) [Junchao-Mellanox] * 1d96b55 2022-11-10 | [show][muxcable] Catch port Value error exception (#2076) (#2486) [Isabella de Leon] * 6ed2afb 2022-11-09 | bugfix[2024] vnet route check exit code fix. (#2480) [siqbal1986] * d8c49dc 2022-11-17 | Fixed SONIC_CLI_IFACE_MODE=alias show ip|ipv6 route output in default mode issue (#2422) [Marty Y. Lok] * 166739e 2022-11-11 | Accept 0 for queue and dscp (#2494) (github/202205) [bingwang-ms] Signed-off-by: Ying Xie <ying.xie@microsoft.com> Signed-off-by: Ying Xie <ying.xie@microsoft.com>
This is an addendum to PR #2335, to ensure that the supervisor processes in all Docker containers have finished starting up all processes in the respective containers.