Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kvm]: initial support for all hwsku in kvm switch #2495

Merged
merged 5 commits into from
Jan 30, 2019

Conversation

lguohan
Copy link
Collaborator

@lguohan lguohan commented Jan 28, 2019

- What I did
Support all hwsku in kvm switch.

- How I did it

- How to verify it
Build kvm image and tested Force10-S6000 (32 ports) and Force10-S6100 (64 port)

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Guohan Lu <gulv@microsoft.com>
Signed-off-by: Guohan Lu <gulv@microsoft.com>
Signed-off-by: Guohan Lu <gulv@microsoft.com>
@lguohan lguohan requested a review from yxieca January 30, 2019 03:26
Copy link
Contributor

@yxieca yxieca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So real hardware will also carry virtual switch HWSKUs? Is this desirable?

@lguohan
Copy link
Collaborator Author

lguohan commented Jan 30, 2019

it does not matter since real hardware will have have the kvm onie string.

@lguohan lguohan merged commit 2b01beb into sonic-net:master Jan 30, 2019
lguohan added a commit that referenced this pull request Jul 13, 2019
Signed-off-by: Guohan Lu <gulv@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants