Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docker-platform-monitor]: Add smartmontools 6.6-1 #2703

Merged
merged 5 commits into from Apr 11, 2019
Merged

[docker-platform-monitor]: Add smartmontools 6.6-1 #2703

merged 5 commits into from Apr 11, 2019

Conversation

mudsut4ke
Copy link
Contributor

- What I did

  • Add smartmontools version 6.6-1 to platform monitor docker
    (to support SSD testing)

- How I did it

  1. Download smartmontools source from debian server
  2. Build smartmontools with strech debian
  3. Add smartmontools to pmon docker

- How to verify it

  • Run command smartctl on SONiC

Signed-off-by: Wirut Getbamrung wgetbumr@celestica.com

@mudsut4ke mudsut4ke mentioned this pull request Mar 26, 2019
Closed
@mudsut4ke
Copy link
Contributor Author

Retest this please

@zhenggen-xu
Copy link
Collaborator

Can you add the output from the smartctl command?
Does the smartd service running by default on the system after this fix?

@mudsut4ke
Copy link
Contributor Author

Here is an output from smartctl and smartd
( only smartctl command can access from sonic cli)

root@sonic:~# show version 
SONiC Software Version: SONiC.HEAD.3935-92958e2
Distribution: Debian 9.8
Kernel: 4.9.0-8-2-amd64
Build commit: 92958e2
Build date: Mon Apr  1 06:45:45 UTC 2019
Built by: johnar@jenkins-worker-1

Docker images:
REPOSITORY                 TAG                 IMAGE ID            SIZE
docker-syncd-brcm          HEAD.3935-92958e2   b876cb6118ed        361MB
docker-syncd-brcm          latest              b876cb6118ed        361MB
docker-dhcp-relay          HEAD.3935-92958e2   c015caf978ec        256MB
docker-dhcp-relay          latest              c015caf978ec        256MB
docker-teamd               HEAD.3935-92958e2   fe56807e38a7        274MB
docker-teamd               latest              fe56807e38a7        274MB
docker-snmp-sv2            HEAD.3935-92958e2   2253115a19cb        294MB
docker-snmp-sv2            latest              2253115a19cb        294MB
docker-lldp-sv2            HEAD.3935-92958e2   48f061d61cc6        274MB
docker-lldp-sv2            latest              48f061d61cc6        274MB
docker-fpm-quagga          HEAD.3935-92958e2   2b8446835a87        281MB
docker-fpm-quagga          latest              2b8446835a87        281MB
docker-orchagent-brcm      HEAD.3935-92958e2   e99869b4a44b        315MB
docker-orchagent-brcm      latest              e99869b4a44b        315MB
docker-database            HEAD.3935-92958e2   2a8da020e01d        280MB
docker-database            latest              2a8da020e01d        280MB
docker-sonic-telemetry     HEAD.3935-92958e2   4667ba5feaf8        300MB
docker-sonic-telemetry     latest              4667ba5feaf8        300MB
docker-platform-monitor    HEAD.3935-92958e2   2c789c0a078d        324MB
docker-platform-monitor    latest              2c789c0a078d        324MB
docker-router-advertiser   HEAD.3935-92958e2   7ff966f67961        279MB
docker-router-advertiser   latest              7ff966f67961        279MB

root@sonic:~# smartctl -V
smartctl 6.6 2017-11-05 r4594 [x86_64-linux-4.9.0-8-2-amd64] (local build)
Copyright (C) 2002-17, Bruce Allen, Christian Franke, www.smartmontools.org

smartctl comes with ABSOLUTELY NO WARRANTY. This is free
software, and you are welcome to redistribute it under
the terms of the GNU General Public License; either
version 2, or (at your option) any later version.
See http://www.gnu.org for further details.

smartmontools release 6.6 dated 2017-11-05 at 15:20:58 UTC
smartmontools SVN rev 4594 dated 2017-11-05 at 15:21:35
smartmontools build host: x86_64-pc-linux-gnu
smartmontools build with: C++14, GCC 6.3.0 20170516
smartmontools configure arguments: '--prefix=/usr' '--build=x86_64-linux-gnu' '--host=x86_64-linux-gnu' '--sysconfdir=/etc' '--mandir=/usr/share/man' '--with-initscriptdir=no' '--docdir=/usr/s'
root@sonic:~# 
root@sonic:~# docker exec -it pmon smartd -V
smartd 6.6 2017-11-05 r4594 [x86_64-linux-4.9.0-8-2-amd64] (local build)
Copyright (C) 2002-17, Bruce Allen, Christian Franke, www.smartmontools.org

smartd comes with ABSOLUTELY NO WARRANTY. This is free
software, and you are welcome to redistribute it under
the terms of the GNU General Public License; either
version 2, or (at your option) any later version.
See http://www.gnu.org for further details.

smartmontools release 6.6 dated 2017-11-05 at 15:20:58 UTC
smartmontools SVN rev 4594 dated 2017-11-05 at 15:21:35
smartmontools build host: x86_64-pc-linux-gnu
smartmontools build with: C++14, GCC 6.3.0 20170516
smartmontools configure arguments: '--prefix=/usr' '--build=x86_64-linux-gnu' '--host=x86_64-linux-gnu' '--sysconfdir=/etc' '--mandir=/usr/share/man' '--with-initscriptdir=no' '--docdir=/usr/s'
root@sonic:~#

@qiluo-msft
Copy link
Collaborator

Hi @mudsut4ke
I shared those source packages in Azure Blob, in order to stable the build process. Could you use those links?

https://sonicstorage.blob.core.windows.net/packages/debian/smartmontools_6.6-1.debian.tar.xz?sv=2015-04-05&sr=b&sig=H0RFeC41MCvhTQCln85DuPLn5v2goozwz%2FB9sA9p5eQ%3D&se=2046-08-20T23%3A46%3A02Z&sp=r
https://sonicstorage.blob.core.windows.net/packages/debian/smartmontools_6.6-1.dsc?sv=2015-04-05&sr=b&sig=IS7FKUN%2Bvq0T55f4X2hGAViB70Y%2FgzjGgvzpUJLyUfA%3D&se=2046-08-20T23%3A46%3A57Z&sp=r
https://sonicstorage.blob.core.windows.net/packages/debian/smartmontools_6.6.orig.tar.gz?sv=2015-04-05&sr=b&sig=JZx4qiLuO36T0rsGqk4V2RDuWjRw6NztsLK7vlBYAkg%3D&se=2046-08-20T23%3A47%3A13Z&sp=r

qiluo-msft
qiluo-msft requested changes Apr 4, 2019
View reviewed changes
Copy link
Collaborator

@qiluo-msft qiluo-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As comments

@mudsut4ke
Copy link
Contributor Author

Hi @mudsut4ke
I shared those source packages in Azure Blob, in order to stable the build process. Could you use those links?

https://sonicstorage.blob.core.windows.net/packages/debian/smartmontools_6.6-1.debian.tar.xz?sv=2015-04-05&sr=b&sig=H0RFeC41MCvhTQCln85DuPLn5v2goozwz%2FB9sA9p5eQ%3D&se=2046-08-20T23%3A46%3A02Z&sp=r
https://sonicstorage.blob.core.windows.net/packages/debian/smartmontools_6.6-1.dsc?sv=2015-04-05&sr=b&sig=IS7FKUN%2Bvq0T55f4X2hGAViB70Y%2FgzjGgvzpUJLyUfA%3D&se=2046-08-20T23%3A46%3A57Z&sp=r
https://sonicstorage.blob.core.windows.net/packages/debian/smartmontools_6.6.orig.tar.gz?sv=2015-04-05&sr=b&sig=JZx4qiLuO36T0rsGqk4V2RDuWjRw6NztsLK7vlBYAkg%3D&se=2046-08-20T23%3A47%3A13Z&sp=r

OK, Updated

@mudsut4ke mudsut4ke mentioned this pull request Apr 8, 2019
Closed
@lguohan lguohan merged commit 27803ec into sonic-net:master Apr 11, 2019
@mudsut4ke mudsut4ke deleted the master-add-smartmontools-6.6-1 branch July 11, 2019 04:12
@StormLiangMS StormLiangMS mentioned this pull request Mar 28, 2023
Merged
8 tasks
StormLiangMS added a commit that referenced this pull request Mar 30, 2023
@StormLiangMS
Advance submodule sonic-utilities to 832ef9c4 (#14445)
3d1733b 
Why I did it
832ef9c4 - Fix bug in GCU vlanintf_validator ([Bcm SAI] ugprade Broadcom SAI to version 3.3.5.4m-1 #2765) (5 minutes ago) [jingwenxie]
53f611b7 - Revert "Convert IPv6 addresses to lowercase in apply-patch (Add Pegatron project to branch 201807 #2299)" (Add note for running out of disk space in /var/lib/docker to README.md #2758) (20 hours ago) [jingwenxie]
79a21cef - Revert frr route check ([mlnx] fix url inconsistency in fw.mk #2761) (8 minutes ago) [StormLiangMS]
824680ed - Resolved rc!=0 problem by replacing fgrep with awk. Added ipv4 filtering to get only v4 peers in case of show ip bgp neighbors (Improve eeprom access reliability #2756) (30 hours ago) [saurabh17g]
10f31ea6 - Revert "Replace pickle by json (Add autoneg to 7170-Q59S20 #2636)" ([hostcfgd] Default value of fallthrough for authentication set to be False.  #2746) (7 days ago) [Mai Bui]
05fa7513 - Fix the show interface counters throwing exception on device with no external interfaces ([docker-platform-monitor]: Add smartmontools 6.6-1 #2703) (11 days ago) [abdosi]
f27dea0c - [route_check] remove check-frr_patch mock ([minigraph]: Mark both ERSPAN and ERSPANv6 as mirror ACL tables #2732) (11 days ago) [Stepan Blyshchak]
2d95529d - Revert "Update load minigraph to load backend acl (mlnx msn2010: default config_db.json generation with sonic-cfggen is not working #2236)" (swss stretch update broke restore_neighbors.py for neigh service #2735) (12 days ago) [Neetha John]
c869c970 - (master) Update the ref guide to reflect the vlan brief output ([teamd] update teamd docker to stretch and fix teamd_init failure #2731) (2 weeks ago) [Vivek]
76457141 - Fix fast-reboot DB migration ([teamd]: update teamd docker to stretch #2734) (2 weeks ago) [Aryeh Feigin]
f7f783bc - Enhance the logic to wait for all buffer tables to be removed in _clear_qos ([sfputil] Not able to read out values of voltage/temp/power on some cables  #2720) (2 weeks ago) [Stephen Sun]
e6179afa - Remove timer from FAST_REBOOT STATE_DB entry and use finalizer (Rollback kernel submodule update. #2621) (3 weeks ago) [Aryeh Feigin]
ff688323 - [route_check] fix IPv6 address handling ([docker pmon] install fancontrol & sensord #2722) (3 weeks ago) [Stepan Blyshchak]
7a604c51 - update fast-reboot ([201811][sairedis][swss] advance sub module head of sairedis and swss #2728) (3 weeks ago) [jhli-cisco]
9f83ace9 - [GCU] Add vlanintf-validator (Revert "[device/celestica] blacklist gpio_ich kernel module on haliburton" #2697) (3 weeks ago) [jingwenxie]
338d1c05 - Check SONiC dependencies before installation. ([sonic-slave]: Add iproute2 dependencies in stretch docker #2716) (3 weeks ago) [Liu Shilong]
64d2efd2 - Improve show acl commands ([sonic-utilities] update submodule #2667) (3 weeks ago) [bingwang-ms]
2ef5b31e - [GCU] Add PFC_WD RDMA validator ([sub module] advance sonic-utilities sub module for 201811 branch #2619) (3 weeks ago) [isabelmsft]
c7aa8416 - [show][muxcable] increase timeout for displaying HW_STATUS (Fixing get_transceiver_change_event #2712) (3 weeks ago) [vdahiya12]
2fc2b826 - YANG validation for ConfigDB Updates: MIRROR_SESSION use case ([mellanox] Update SDK to 4.3.0132 #2430) (3 weeks ago) [isabelmsft]
e16bdaae - Fix non-zero status exit on non secure boot system ([service] add warmboot finializer service #2715) (3 weeks ago) [kellyyeh]
90d70152 - [route_check] implement a check for FRR routes not marked offloaded (Feature to run an option platform specific script on the first boot #2531) (3 weeks ago) [Stepan Blyshchak]
c2bc150a - [warm/fast-reboot] Backup logs from tmpfs to disk during fast/warm shutdown ([swss]: update swss docker to stretch #2714) (3 weeks ago) [Vaibhav Hemant Dixit]
a015834d - [db_migrator] Add missing attribute 'weight' to route entries in APPL DB ([device/celestica] blacklist gpio_ich kernel module on seastone #2691) (4 weeks ago) [Vaibhav Hemant Dixit]
cd519aac - [ci] Fix pipeline issue caused by sonic-slave-* change. ([201803] Modify Debian apt repos to reflect changes made by maintainers #2709) (4 weeks ago) [Liu Shilong]
2680e6f3 - [dhcp_relay] Fix dhcp_relay restart error while add/del vlan ([thrift] add a patch to revert THRIFT-3650 #2688) (4 weeks ago) [Yaqiang Zhu]
How I did it
How to verify it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lguohan lguohan lguohan approved these changes

@qiluo-msft qiluo-msft qiluo-msft approved these changes

@zhenggen-xu zhenggen-xu zhenggen-xu approved these changes

@andriymoroz-mlnx andriymoroz-mlnx Awaiting requested review from andriymoroz-mlnx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mudsut4ke @zhenggen-xu @qiluo-msft @lguohan