Build sonic-broadcom.bin using debug dockers for all stretch based dockers #2833

renukamanavalan · 2019-04-28T01:11:58Z

- What I did
Enable build of dbg-sonic-broadcom.bin, which uses dbg-dockers in place of regular dockers, for dockers that build debug version. For dockers that do not build debug version, it uses the regular docker.

As of now, all stretch based dockers build a debug version.

The debug version, carries all needed debug symbols and tools (like gdb, gdbserver, ...) required for debugging.

The debug bin is installable like regular bin in a DUT.

Most commonly, as a dev, you may not need the .bin, but just docker--dbg.gz, which you can load & run in your VM, with bash as entrypoint and your core file location mapped. Now you can debug your core in VM.

Have fun debugging!!!
Of course, look at your log file for tidbits, before you go this route. When you write code, make sure to log all your errors, which can save a ton of time, in debugging

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

As a sample, platform/broadcom/docker-orchagent-brcm.mk is updated to add a docker-orchagent-brcm-dbg.gz target. Now "BLDENV=stretch make target/docker-orchagent-brcm-dbg.gz" will build the debug image. NOTE: If you don't specify NOSTRETcH=1, it implicitly calls "make stretch", which builds all stretch targets and that would include debug dockers too. This debug image can be used in any linux box to inspect core file. If your module's external dependency can be suitably mocked, you my even manually run it inside. "docker run -it --entrypoint=/bin/bash e47a8fb8ed38" You may map the core file path to this docker run.

… to help readability.

…UG_TOOLS=y. When this change ('building debug docker image transparently') is extended to all dockers, this flag would become redundant. Yet, there can be some test based use cases that rely on this flag. Until after all the dockers gets their debug images by default and we switch all use cases of this flag to use the newly built debug images, we need to maintain the existing behavior.

2) Debug template builder: renamed build_dbg_j2.sh to build_debug_docker_j2.sh 3) Dropped insignifcant statement CMD from debug Docker file, as base docker has Entrypoint.

"User, uid, guid, frr-uid & frr-guid" are required for all docker images, with exception of debug images.

…(SONIC_STRETCH_DOCKERS_FOR_INSTALLERS) and build debug-dockers only for those to be built and debug target is available.

merge with upstream

Where needed a platform entry can override the template. This avoids duplication, hence easier to maintain.

Just take the platform code and do the rest in template.

sync with upstream

…e under rules/docker-orchagent.mk 2) Extened debug image to all stretch dockers

1) Dropped LIBSAIREDIS_DBG from database, teamd, router-advertiser, telemetry, and platform-monitor docker*.mk files from _DBG_DEPENDS list 2) W.r.t docker make for syncd, moved DEPENDS from template to specific makefile and let the template has stuff that is applicable to all.

Sync with upstream

…er as DOCKER_SYNCD_BASE instead of DOCKER_SYNCD_<platform code>. Fix the docker-syncd-<mlnx, bfn>.mk to use the new one. [Yet to be tested locally]

…ce of regular dockers, for dockers that build debug version. For dockers that do not build debug version, it uses the regular docker. This debug bin is installable and usable in a DUT, just like a regular bin.

marian-pritsak · 2019-04-28T12:47:47Z

Why is this change related to broadcom?
Why not utilize debug configs and build debug dockers per request?

marian-pritsak

Is there any high-level design for this?
It looks like a big and permanent change and needs a review.

slave.mk

renukamanavalan · 2019-04-28T18:27:26Z

My computer has crashed, hence unable to access. I will get back by tomorrow

Sent from my iPhone On Apr 28, 2019, at 6:02 AM, Marian Pritsak <notifications@github.com<mailto:notifications@github.com>> wrote: @marian-pritsak requested changes on this pull request. Is there any high-level design for this? It looks like a big and permanent change and needs a review.

________________________________ In slave.mk<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fsonic-buildimage%2Fpull%2F2833%23discussion_r279193714&data=01%7C01%7CRenuka.Manavalan%40microsoft.com%7C9611695d96e44b2ef4de08d6cbd9b2f5%7C72f988bf86f141af91ab2d7cd011db47%7C1&sdata=gvUSWWDZ3PYc9tgSOCYdJznI6SjXcUIn9jIInHguiho%3D&reserved=0>:

@@ -664,6 +665,103 @@ $(addprefix $(TARGET_PATH)/, $(SONIC_INSTALLERS)) : $(TARGET_PATH)/% : \

SONIC_TARGET_LIST += $(addprefix $(TARGET_PATH)/, $(SONIC_INSTALLERS)) +# targets for building debug installers with base image +$(addprefix $(TARGET_PATH)/, $(SONIC_DBG_INSTALLERS)) : $(TARGET_PATH)/$(DBG_IMAGE_MARK)-% : \ It looks like a copy of a target above, which makes it hard to maintain and update. What's the difference from the above? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fsonic-buildimage%2Fpull%2F2833%23pullrequestreview-231467380&data=01%7C01%7CRenuka.Manavalan%40microsoft.com%7C9611695d96e44b2ef4de08d6cbd9b2f5%7C72f988bf86f141af91ab2d7cd011db47%7C1&sdata=QkgClU%2FcPz7qRXNIIkKYeNk0erdhl1FmzhCK6GYuvvg%3D&reserved=0>, or mute the thread<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FALIXUJLAZN7TIRO272F5NFTPSWN4NANCNFSM4HI5LGKQ&data=01%7C01%7CRenuka.Manavalan%40microsoft.com%7C9611695d96e44b2ef4de08d6cbd9b2f5%7C72f988bf86f141af91ab2d7cd011db47%7C1&sdata=pJAVhZyRiVtNm8vGJRa0dLOgNL%2FI1u2uSX9T3GGi5eA%3D&reserved=0>.

renukamanavalan

Hi Marian,

Yes indeed this is one of the final pieces of the work, with debug dockers.

Main Goal:
To transparently build debug docker images for each docker image.

Gain/purpose of the goal:
Today, if you need to a debug session, on a dead core file or live debugging, you need to find DUT running that version, get into docker container, download & install all debug symbols and download/install debug tools like gdb.

If you are looking at core files from two different versions, you need two DUTs (virtual/real)

With this goal:
To analyze a dead core file, you don't need any DUT. From the build server, get debug version of your docker, run the docker in any docker-supported environment (e.g. a VM running linux), load & run the docker with bash as entrypoint and core file mapped.
This saves us a lot of time and reduce our requirements.

To do live debugging, instead of upgrading your docker with debug symbols & tools, get the debug version of the same docker from the build server, load that image and you are set to go.

BTW, this main goal is already accomplished for all stretch based dockers, through following PRs that are committed.

#2753
#2789
#2812

Add-on goal:
Now the debug docker images are available for all stretch based dockers. With goal of moving all dockers to stretch based, soon all docker images will have a debug version available.

So wonder, why not build a debug version of final sonic image (.bin/.swi/...) using debug docker images.

With this, you could have a real/virtual DUT with all docker images enhanced with debug symbols & tools.

This PR is the first step, to build debug version of sonic-broadcom.bin.

lguohan · 2019-04-29T05:54:23Z

onie-image.conf


 ## Kvm image size in GB
 KVM_IMAGE_DISK_SIZE=16

 ## Output file name for aboot installer
-OUTPUT_ABOOT_IMAGE=target/sonic-aboot-$TARGET_MACHINE.swi
+OUTPUT_ABOOT_IMAGE=target/${IMAGE_PREFIX}sonic-aboot-$TARGET_MACHINE.swi


it is better to put dbg as a suffix instead of prefix. sonic-broadom-dbg.bin.

lguohan · 2019-04-29T06:12:49Z

agree with marian, it is better to have a design doc as this question will be raise every pr. @renukamanavalan , can you prepare a design doc?

Merge remote-tracking branch 'upstream/master'

1) Share a single rule for final image for normal & debug flavors (e.g. sonic-broadcom.bin & sonic-broadcom-dbg.bin) 2) Put dbg as suffix in final image name. 3) Compared target/sonic-broadcom.bin.logs with & w/o fix to verify integrity of sonic-broadcom.bin 4) Compared target/sonic-broadcom.bin.logs with sonic-broadcom-dbg.bin.log for verification This fix takes care of ONIE image only. The next PR will cover the rest. The next PR, will also make debug image conditional with flag.

build_image.sh

platform/broadcom/one-image.mk

slave.mk

lguohan · 2019-05-29T08:16:11Z

the approach is a little bit complicated than I think. I think you can just define an option ENABLE_DBG_BUILD = y. When it is enabled, then when you build sonic-broadcom.bin, then it is using the debug docker, then you do not need most of the changes in the slave.mk. Since you are not using a new image name.

it is much easier, the only difference between a normal build and a debug build is load different dockers. You will be able to support build debug swi, debug kvm image by default.

lguohan

define a ENABLE_DEBUG_BUILD = y option, when option is enabled, build sonic-broadcom.bin using debug docker images. do not change the build target name sonic-broadcom.bin. it is where all complexity coming from in your current pr. user can management to build sonic-broadcom.bin and rename it to sonic-broadcom-dbg.bin.

Now that debug dockers are available, do not need a way to install debug symbols in regular dockers. With this commit, when INSTALL_DEBUG_TOOLS=y is set, it builds debug dockers (for dockers that enable debug build) and the final image uses debug dockers. For dockers that do not enable debug build, regular dockers get used in the final image. Note: The debug dockers are explicitly named as <docker name>-dbg.gz. But there is no "-dbg" suffix for image. Hence if you make two runs with and w/o INSTALL_DEBUG_TOOLS=y, you have complete set of regular dockers + debug dockers. But the image gets overwritten. Hence if both regular & debug images are needed, make two runs, as one with INSTALL_DEBUG_TOOLS=y and one w/o. Make sure to copy/rename the final image, before making the second run.

renukamanavalan · 2019-06-02T20:57:51Z

retest this please

lguohan

revert to use INSTALL_DEBUG_TOOLS option.

lguohan · 2019-06-09T06:43:36Z

@marian-pritsak, can you review again?

… latest HEAD sonic-swss: ``` * 13ef25bf - (HEAD -> master, origin/master, origin/HEAD) [teamd]: Clean teamd process if LAG creation fails (sonic-net#2888) (5 days ago) [Lawrence Lee] * ae010bfa - Support type7 encoded CAK key for macsec in config_db (sonic-net#2892) (13 days ago) [judyjoseph] * e6f134fb - [orchagent]: admin-disable port before setPortSerdesAttribute() (sonic-net#2831) (4 weeks ago) [Aman Singhal] * a67d4a77 - Change default branch to build_branch (sonic-net#2885) (4 weeks ago) [Ze Gan] * d44761cc - Make sure new binaries replace existing binaries in docker-sonic-vs (sonic-net#2870) (4 weeks ago) [Saikrishna Arcot] * 7102220a - [Fixbug]: Fix vnet attribute miss if route action is vnet_direct and vnet test cases (sonic-net#2873) (sonic-net#2877) (4 weeks ago) [Ze Gan] * 873455b7 - Merge pull request sonic-net#2878 from Pterosaur/enable_dash_vstest (4 weeks ago) [Guohan Lu] |\ | * 44457c86 - Simplify test task and remove duplicated artifacts (4 weeks ago) [Ze Gan] | * 8bca4ed2 - Trigger Azp (4 weeks ago) [Ze Gan] | * 6de56ee1 - Merge branch 'master' into enable_dash_vstest (4 weeks ago) [Ze Gan] | |\ | * | aad88a36 - Disable test_dash_crm (5 weeks ago) [Ze Gan] | * | 61126eb0 - Enable Dash test in Pipeline (5 weeks ago) [Ze Gan] * | | ecd88108 - update portStatIds for cisco (sonic-net#2876) (4 weeks ago) [Zhixin Zhu] * | | f1294999 - [ppi] Relax port attributes validation (sonic-net#2872) (4 weeks ago) [Nazarii Hnydyn] | |/ |/| * | b4fcfc9f - Remove fabric queue counters. (sonic-net#2862) (5 weeks ago) [jfeng-arista] |/ * bb99f418 - Merge pull request sonic-net#2856 from theasianpianist/master-dash-merge (5 weeks ago) [Guohan Lu] |\ | * 84b32af2 - Merge branch 'master' into master-dash-merge (5 weeks ago) [Lawrence Lee] | |\ | |/ |/| * | ca728200 - [FEC] Adding support of override based on attribute query of SAI_PORT_ATTR_AUTO_NEG_FEC_MODE_OVERRIDE (sonic-net#2874) (5 weeks ago) [Sudharsan Dhamal Gopalarathnam] / * 3bb71809 - Merge branch 'master' into master-dash-merge (5 weeks ago) [Lawrence Lee] * 574940dd - Merge branch 'master' into master-dash-merge (6 weeks ago) [Lawrence Lee] * 660e5e4c - Merge branch 'master' into master-dash-merge (6 weeks ago) [Lawrence Lee] * 6d941746 - Merge branch 'master' into master-dash-merge (6 weeks ago) [Lawrence Lee] * c87c86e6 - [dash]: Refactor DASH orch by protobuf format (sonic-net#2722) (8 weeks ago) [Ze Gan] * c999ea32 - [tests]: Change DVS ENV HWKSU to DPU-2P for DASH vstest (sonic-net#2847) (8 weeks ago) [prabhataravind] * b2c25dcd - (conflict)[dash] Improve dash orchagent ZMQ code. (sonic-net#2836) (8 weeks ago) [Hua Liu] * 409b3833 - [tests]: Set HWSKU to NPU-2P for dash vstests (sonic-net#2833) (8 weeks ago) [prabhataravind] * f2365af9 - (conflict)Enable/disable Zmq by parameter (sonic-net#2828) (8 weeks ago) [Hua Liu] * 3ade5fc3 - (conflict)[dash] Change dash orchagent from Redis consumer state table to ZMQ consumer state table. (sonic-net#2779) (8 weeks ago) [Hua Liu] * eaf1bb85 - [crm]: Remove NOT_IMPLEMENTED checks (8 weeks ago) [Lawrence Lee] * 916d2f10 - [azp]: Don't run DASH tests for regular test runs (8 weeks ago) [Lawrence Lee] * 208e80bd - update azp to use public pipeline artifacts (8 weeks ago) [Lawrence Lee] * 2168554d - [dash][ci] fix build pipeline (8 weeks ago) [Yakiv Huryk] * b6036635 - [dash][ci] update build pipeline to build with bullseye (8 weeks ago) [Yakiv Huryk] * 37a61ddb - (conflict)[azp] Add DASH to PR trigger for non-DASH VS tests (sonic-net#2813) (8 weeks ago) [Lawrence Lee] * 37d27b01 - Fix Dash orchagent build issue. (sonic-net#2788) (8 weeks ago) [Hua Liu] * 07cce313 - (conflict)[CRM][DASH] Extend CrmOrch to support DASH resources. (sonic-net#2739) (8 weeks ago) [Oleksandr Ivantsiv] * 7c435d1e - [DASH]: Miscellaneous bug fixes and adding vstests (sonic-net#2745) (8 weeks ago) [prabhataravind] * 6613dd4f - [dash]: Check if overlay IP is specified (sonic-net#2741) (8 weeks ago) [Lawrence Lee] * c863d48b - [dash] Do not use an action drop with the inbound routing table. (sonic-net#2710) (8 weeks ago) [Oleksandr Ivantsiv] * 89ce4e0c - [dash]: Don't attempt to bind empty ACL groups (sonic-net#2613) (8 weeks ago) [Lawrence Lee] * 8ec36a6f - (conflict)[dash]: ACL orchagent (sonic-net#2470) (8 weeks ago) [Ze Gan] * 29c23b12 - [DASH] Fix compilation issue caused by merge from the master branch. (sonic-net#2594) (8 weeks ago) [Oleksandr Ivantsiv] * fd3539e5 - [DASH] Add retry logic for VNET mapping table (sonic-net#2583) (8 weeks ago) [Lawrence Lee] * 9b179c07 - [dash] add USE_DST_VNET_VNI attribute to CA-to-PA entry (sonic-net#2533) (8 weeks ago) [Yakiv Huryk] * f7fe55fa - Add SAI_ENI_ATTR_VM_UNDERLAY_DIP and SAI_ENI_ATTR_VM_VNI attributes to ENI entry (sonic-net#2514) (8 weeks ago) [prabhataravind] * aa2a02c5 - (conflict)[Azp]: Add Azp for DASH (sonic-net#2501) (8 weeks ago) [Ze Gan] * 2d1972f2 - (conflict)orchagent: DASH changes (sonic-net#2459) (8 weeks ago) [prabhataravind] * acf0fe42 - [DPU] Fix unit tests compilation after merge from master branch. (sonic-net#2478) (8 weeks ago) [Oleksandr Ivantsiv] * 22c62f63 - (conflict)[DPU] Simplify SWSS initialization to meet DPU requirements. (sonic-net#2440) (8 weeks ago) [Oleksandr Ivantsiv] ``` sonic-sairedis ``` * cfa8da4 - (HEAD -> master, origin/master, origin/HEAD) Add extra parameter to pass vendor LDFLAGS for libsai.so (sonic-net#1291) (3 days ago) [Kamil Cudnik] * 8046908 - [CRM][DASH] Add the possibility of querying availability for OIDs. (sonic-net#1245) (5 days ago) [Oleksandr Ivantsiv] * 9547060 - Install nlohmann-json3-dev package for codeql (sonic-net#1290) (10 days ago) [Saikrishna Arcot] * f3b4dd5 - Use json.hpp from nlohmann-json-dev instead of swss-common (sonic-net#1289) (11 days ago) [Saikrishna Arcot] * 40c9d13 - [azp] Update az pipeline for swss docker to add syslog (sonic-net#1287) (2 weeks ago) [Kamil Cudnik] * 4c2527f - port counter support on sonic-vs (sonic-net#1275) (3 weeks ago) [Vishnu Shetty] * 92c58cf - [Azp]: Change default branch to build_branch (sonic-net#1279) (4 weeks ago) [Ze Gan] * 7178fb6 - [submodule] Update SAI to latest v1.12 branch (sonic-net#1284) (4 weeks ago) [Oleksandr Ivantsiv] * 52247b9 - [syncd] Fix missing comma (sonic-net#1278) (4 weeks ago) [Kamil Cudnik] * 44cd8c4 - [azp] Attempt to fix swss missing libs (sonic-net#1277) (4 weeks ago) [Ze Gan] * ee308bb - [submodule] Update SAI to latest v1.12 branch (sonic-net#1272) (5 weeks ago) [Kamil Cudnik] ``` Signed-off-by: Ze Gan <ganze718@gmail.com>

… latest HEAD (#16599) sonic-swss: ``` * 13ef25bf - (HEAD -> master, origin/master, origin/HEAD) [teamd]: Clean teamd process if LAG creation fails (#2888) (5 days ago) [Lawrence Lee] * ae010bfa - Support type7 encoded CAK key for macsec in config_db (#2892) (13 days ago) [judyjoseph] * e6f134fb - [orchagent]: admin-disable port before setPortSerdesAttribute() (#2831) (4 weeks ago) [Aman Singhal] * a67d4a77 - Change default branch to build_branch (#2885) (4 weeks ago) [Ze Gan] * d44761cc - Make sure new binaries replace existing binaries in docker-sonic-vs (#2870) (4 weeks ago) [Saikrishna Arcot] * 7102220a - [Fixbug]: Fix vnet attribute miss if route action is vnet_direct and vnet test cases (#2873) (#2877) (4 weeks ago) [Ze Gan] * 873455b7 - Merge pull request #2878 from Pterosaur/enable_dash_vstest (4 weeks ago) [Guohan Lu] |\ | * 44457c86 - Simplify test task and remove duplicated artifacts (4 weeks ago) [Ze Gan] | * 8bca4ed2 - Trigger Azp (4 weeks ago) [Ze Gan] | * 6de56ee1 - Merge branch 'master' into enable_dash_vstest (4 weeks ago) [Ze Gan] | |\ | * | aad88a36 - Disable test_dash_crm (5 weeks ago) [Ze Gan] | * | 61126eb0 - Enable Dash test in Pipeline (5 weeks ago) [Ze Gan] * | | ecd88108 - update portStatIds for cisco (#2876) (4 weeks ago) [Zhixin Zhu] * | | f1294999 - [ppi] Relax port attributes validation (#2872) (4 weeks ago) [Nazarii Hnydyn] | |/ |/| * | b4fcfc9f - Remove fabric queue counters. (#2862) (5 weeks ago) [jfeng-arista] |/ * bb99f418 - Merge pull request #2856 from theasianpianist/master-dash-merge (5 weeks ago) [Guohan Lu] |\ | * 84b32af2 - Merge branch 'master' into master-dash-merge (5 weeks ago) [Lawrence Lee] | |\ | |/ |/| * | ca728200 - [FEC] Adding support of override based on attribute query of SAI_PORT_ATTR_AUTO_NEG_FEC_MODE_OVERRIDE (#2874) (5 weeks ago) [Sudharsan Dhamal Gopalarathnam] / * 3bb71809 - Merge branch 'master' into master-dash-merge (5 weeks ago) [Lawrence Lee] * 574940dd - Merge branch 'master' into master-dash-merge (6 weeks ago) [Lawrence Lee] * 660e5e4c - Merge branch 'master' into master-dash-merge (6 weeks ago) [Lawrence Lee] * 6d941746 - Merge branch 'master' into master-dash-merge (6 weeks ago) [Lawrence Lee] * c87c86e6 - [dash]: Refactor DASH orch by protobuf format (#2722) (8 weeks ago) [Ze Gan] * c999ea32 - [tests]: Change DVS ENV HWKSU to DPU-2P for DASH vstest (#2847) (8 weeks ago) [prabhataravind] * b2c25dcd - (conflict)[dash] Improve dash orchagent ZMQ code. (#2836) (8 weeks ago) [Hua Liu] * 409b3833 - [tests]: Set HWSKU to NPU-2P for dash vstests (#2833) (8 weeks ago) [prabhataravind] * f2365af9 - (conflict)Enable/disable Zmq by parameter (#2828) (8 weeks ago) [Hua Liu] * 3ade5fc3 - (conflict)[dash] Change dash orchagent from Redis consumer state table to ZMQ consumer state table. (#2779) (8 weeks ago) [Hua Liu] * eaf1bb85 - [crm]: Remove NOT_IMPLEMENTED checks (8 weeks ago) [Lawrence Lee] * 916d2f10 - [azp]: Don't run DASH tests for regular test runs (8 weeks ago) [Lawrence Lee] * 208e80bd - update azp to use public pipeline artifacts (8 weeks ago) [Lawrence Lee] * 2168554d - [dash][ci] fix build pipeline (8 weeks ago) [Yakiv Huryk] * b6036635 - [dash][ci] update build pipeline to build with bullseye (8 weeks ago) [Yakiv Huryk] * 37a61ddb - (conflict)[azp] Add DASH to PR trigger for non-DASH VS tests (#2813) (8 weeks ago) [Lawrence Lee] * 37d27b01 - Fix Dash orchagent build issue. (#2788) (8 weeks ago) [Hua Liu] * 07cce313 - (conflict)[CRM][DASH] Extend CrmOrch to support DASH resources. (#2739) (8 weeks ago) [Oleksandr Ivantsiv] * 7c435d1e - [DASH]: Miscellaneous bug fixes and adding vstests (#2745) (8 weeks ago) [prabhataravind] * 6613dd4f - [dash]: Check if overlay IP is specified (#2741) (8 weeks ago) [Lawrence Lee] * c863d48b - [dash] Do not use an action drop with the inbound routing table. (#2710) (8 weeks ago) [Oleksandr Ivantsiv] * 89ce4e0c - [dash]: Don't attempt to bind empty ACL groups (#2613) (8 weeks ago) [Lawrence Lee] * 8ec36a6f - (conflict)[dash]: ACL orchagent (#2470) (8 weeks ago) [Ze Gan] * 29c23b12 - [DASH] Fix compilation issue caused by merge from the master branch. (#2594) (8 weeks ago) [Oleksandr Ivantsiv] * fd3539e5 - [DASH] Add retry logic for VNET mapping table (#2583) (8 weeks ago) [Lawrence Lee] * 9b179c07 - [dash] add USE_DST_VNET_VNI attribute to CA-to-PA entry (#2533) (8 weeks ago) [Yakiv Huryk] * f7fe55fa - Add SAI_ENI_ATTR_VM_UNDERLAY_DIP and SAI_ENI_ATTR_VM_VNI attributes to ENI entry (#2514) (8 weeks ago) [prabhataravind] * aa2a02c5 - (conflict)[Azp]: Add Azp for DASH (#2501) (8 weeks ago) [Ze Gan] * 2d1972f2 - (conflict)orchagent: DASH changes (#2459) (8 weeks ago) [prabhataravind] * acf0fe42 - [DPU] Fix unit tests compilation after merge from master branch. (#2478) (8 weeks ago) [Oleksandr Ivantsiv] * 22c62f63 - (conflict)[DPU] Simplify SWSS initialization to meet DPU requirements. (#2440) (8 weeks ago) [Oleksandr Ivantsiv] ``` sonic-sairedis ``` * cfa8da4 - (HEAD -> master, origin/master, origin/HEAD) Add extra parameter to pass vendor LDFLAGS for libsai.so (#1291) (3 days ago) [Kamil Cudnik] * 8046908 - [CRM][DASH] Add the possibility of querying availability for OIDs. (#1245) (5 days ago) [Oleksandr Ivantsiv] * 9547060 - Install nlohmann-json3-dev package for codeql (#1290) (10 days ago) [Saikrishna Arcot] * f3b4dd5 - Use json.hpp from nlohmann-json-dev instead of swss-common (#1289) (11 days ago) [Saikrishna Arcot] * 40c9d13 - [azp] Update az pipeline for swss docker to add syslog (#1287) (2 weeks ago) [Kamil Cudnik] * 4c2527f - port counter support on sonic-vs (#1275) (3 weeks ago) [Vishnu Shetty] * 92c58cf - [Azp]: Change default branch to build_branch (#1279) (4 weeks ago) [Ze Gan] * 7178fb6 - [submodule] Update SAI to latest v1.12 branch (#1284) (4 weeks ago) [Oleksandr Ivantsiv] * 52247b9 - [syncd] Fix missing comma (#1278) (4 weeks ago) [Kamil Cudnik] * 44cd8c4 - [azp] Attempt to fix swss missing libs (#1277) (4 weeks ago) [Ze Gan] * ee308bb - [submodule] Update SAI to latest v1.12 branch (#1272) (5 weeks ago) [Kamil Cudnik] ```

renukamanavalan added 22 commits April 5, 2019 23:16

Dropped the regular binary using DBG_PACKAGES and a small name change…

042d51e

… to help readability.

1) slave.mk - Dropped unused Docker build args

4443c70

2) Debug template builder: renamed build_dbg_j2.sh to build_debug_docker_j2.sh 3) Dropped insignifcant statement CMD from debug Docker file, as base docker has Entrypoint.

Reverted some changes, per review comments.

7b84e64

"User, uid, guid, frr-uid & frr-guid" are required for all docker images, with exception of debug images.

Merge remote-tracking branch 'upstream/master'

c717e50

Get in sync with the new update that filters out dockers to be built …

60a001c

…(SONIC_STRETCH_DOCKERS_FOR_INSTALLERS) and build debug-dockers only for those to be built and debug target is available.

Merge remote-tracking branch 'upstream/master'

cefc4b8

merge with upstream

Mkae a template for each target that can be shared by all platforms.

f659917

Where needed a platform entry can override the template. This avoids duplication, hence easier to maintain.

A small change, that can fit better with other targets too.

9d7aedb

Just take the platform code and do the rest in template.

Extended debug to all stretch based docker images

279084f

Merge remote-tracking branch 'upstream/master'

99783dd

sync with upstream

1) Combined all orchagent makefiles into one platform independent mak…

a2297a3

…e under rules/docker-orchagent.mk 2) Extened debug image to all stretch dockers

Merge remote-tracking branch 'upstream/master'

575e43d

1) Corrected a copy/paste mistake

e504eb7

Fixed a copy/paste bug

0db6c0f

Merge remote-tracking branch 'upstream/master'

755dcee

Sync with upstream

The base syncd dockers follow a template, which defines the base dock…

6f1c92b

…er as DOCKER_SYNCD_BASE instead of DOCKER_SYNCD_<platform code>. Fix the docker-syncd-<mlnx, bfn>.mk to use the new one. [Yet to be tested locally]

Fixed spelling mistake

3d74bcc

Merge remote-tracking branch 'upstream/master'

e537676

Enable build of dbg-sonic-broadcom.bin, which uses dbg-dockers in pla…

31fa832

…ce of regular dockers, for dockers that build debug version. For dockers that do not build debug version, it uses the regular docker. This debug bin is installable and usable in a DUT, just like a regular bin.

marian-pritsak previously requested changes Apr 28, 2019

View reviewed changes

slave.mk Outdated Show resolved Hide resolved

stcheng added the Enhancement ➕ label Apr 28, 2019

renukamanavalan commented Apr 28, 2019

View reviewed changes

lguohan reviewed Apr 29, 2019

View reviewed changes

Sync with master

b9ced6f

Merge remote-tracking branch 'upstream/master'

renukamanavalan added 2 commits May 20, 2019 03:09

Merge remote-tracking branch 'upstream/master'

fbaabca

renukamanavalan requested review from marian-pritsak and lguohan May 22, 2019 17:12

renukamanavalan self-assigned this May 28, 2019

lguohan reviewed May 29, 2019

View reviewed changes

build_image.sh Outdated Show resolved Hide resolved

lguohan reviewed May 29, 2019

View reviewed changes

platform/broadcom/one-image.mk Outdated Show resolved Hide resolved

lguohan reviewed May 29, 2019

View reviewed changes

slave.mk Outdated Show resolved Hide resolved

lguohan requested changes May 29, 2019

View reviewed changes

renukamanavalan added 3 commits June 2, 2019 04:08

Merge remote-tracking branch 'upstream/master'

fc019bb

Removed changes that are no more warranted.

fe438f8

lguohan approved these changes Jun 9, 2019

View reviewed changes

Merge branch 'master' into master

3fcfc18

marian-pritsak approved these changes Jun 11, 2019

View reviewed changes

lguohan merged commit cdca062 into sonic-net:master Jun 12, 2019

kellyyeh mentioned this pull request May 10, 2023

[202012] Advance sonic-utilities submodule #15009

Merged

10 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Build sonic-broadcom.bin using debug dockers for all stretch based dockers #2833

Build sonic-broadcom.bin using debug dockers for all stretch based dockers #2833

renukamanavalan commented Apr 28, 2019

marian-pritsak commented Apr 28, 2019 •

edited

Loading

marian-pritsak left a comment

renukamanavalan commented Apr 28, 2019 via email

renukamanavalan left a comment

lguohan Apr 29, 2019

renukamanavalan May 22, 2019

lguohan commented Apr 29, 2019

lguohan commented May 29, 2019

lguohan left a comment

renukamanavalan commented Jun 2, 2019

lguohan left a comment

lguohan commented Jun 9, 2019

Build sonic-broadcom.bin using debug dockers for all stretch based dockers #2833

Build sonic-broadcom.bin using debug dockers for all stretch based dockers #2833

Conversation

renukamanavalan commented Apr 28, 2019

marian-pritsak commented Apr 28, 2019 • edited Loading

marian-pritsak left a comment

Choose a reason for hiding this comment

renukamanavalan commented Apr 28, 2019 via email

renukamanavalan left a comment

Choose a reason for hiding this comment

lguohan Apr 29, 2019

Choose a reason for hiding this comment

renukamanavalan May 22, 2019

Choose a reason for hiding this comment

lguohan commented Apr 29, 2019

lguohan commented May 29, 2019

lguohan left a comment

Choose a reason for hiding this comment

renukamanavalan commented Jun 2, 2019

lguohan left a comment

Choose a reason for hiding this comment

lguohan commented Jun 9, 2019

marian-pritsak commented Apr 28, 2019 •

edited

Loading