[frr]: change frr as default sonic routing stack #2863
Conversation
|
retest this please |
There was a problem hiding this comment.
it is good we are moving to FRR. A few issues which may need some attention after this change.
<1> no supervisord in frr BGP docker as all other dockers. It is using docker entry point.
<2> zebra/bgpd will be restarted automatically by watchfrr. it will affect warm reboot function.
<3> bgp graceful-restart preserve-fw-state is off by default. It is hardcoded as enable in current sonic Quagga.
<4> Need to evaluate BGP “update-delay MAX-DELAY ESTABLISH-WAIT” configuration.
|
It looks VS docker change is needed to use frr? supervisord.conf is hardcoded with quagga path. |
|
current pr won't work in case the routing stack is quagga, need to figure out a way to support both quagga and frr. |
|
@jipanyang , for first 2, check #2870 |
Signed-off-by: Guohan Lu <gulv@microsoft.com>
|
@jipanyang Can you elaborate this "zebra/bgpd will be restarted automatically by watchfrr. it will affect warm reboot function."? What exactly the impact? In case BGP restart, zebra is supposed to remove all routes from kernel and SONiC. This is BGP feature gap that if we need support unplanned warm restart. In case zebra crash/restart, routes were not removed and the fpmsyncd will do the reconciliation later once zebra is back. |
|
@zhenggen-xu Currently bgpd and zebra are killed explicitly for warm reboot. If watchfrr is there, change may be needed to take watchfrr into account. |
* [frr]: change frr as default sonic routing stack * fix quagga configuration * [vstest]: fix bgp test for frr * [vstest]: skip bgp/test_invalid_nexthop.py for frr Signed-off-by: Guohan Lu <gulv@microsoft.com>
…atically (#15422) #### Why I did it src/sonic-utilities ``` * 1246bc81 - (HEAD -> 202211, origin/202211) [config reload]Config Reload Enhancement (#2693) (#2863) (2 days ago) [Sudharsan Dhamal Gopalarathnam] * d69aae4d - [vlan][dhcp_relay] Clear dhcpv6 relay counter while deleting vlan (#2852) (2 days ago) [Yaqiang Zhu] * 0f6bf8ac - [config]: Dynamically start and stop ndppd (#2814) (2 days ago) [Lawrence Lee] * 48a63ff1 - Fix issue: out of range sflow polling interval is accepted and stored in config_db (#2847) (2 days ago) [Junchao-Mellanox] ``` #### How I did it #### How to verify it #### Description for the changelog
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)