Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lldpd]: Ports few fixes from lldpd master #3889

Merged
merged 6 commits into from
Dec 13, 2019

Conversation

pavel-shirshov
Copy link
Contributor

@pavel-shirshov pavel-shirshov commented Dec 12, 2019

- What I did
Ported four fixes from lldp master https://github.com/vincentbernat/lldpd

  1. lldpctl: put a lock around some commands to avoid race conditions lldpctl: put a lock around some commands to avoid race conditions lldpd/lldpd#354
  2. Read all notifications in lldpctl_recv Read all notifications in lldpctl_recv. lldpd/lldpd#286
  3. lib: fix memory leak lib: fix memory leak lldpd/lldpd#345
  4. Fix memory leak in atom.c Fix memory leak in atom.c lldpd/lldpd#362

- How I did it
Extracted patches from the master tree, applied them on our tree and created three patches

- How to verify it
Build an image and run on your DUT

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@jleveque
Copy link
Contributor

@pavel-shirshov: This PR should also be labeled for cherry-picking into the 201911 branch, no?

@pavel-shirshov
Copy link
Contributor Author

@jleveque Done. I haven't known about then 201911.

@pavel-shirshov pavel-shirshov merged commit 86e23f9 into sonic-net:master Dec 13, 2019
@pavel-shirshov pavel-shirshov deleted the pavelsh/lldp branch December 13, 2019 21:46
yxieca pushed a commit that referenced this pull request Dec 14, 2019
* lldpctl: put a lock around some commands to avoid race conditions

* Read all notifications in lldpctl_recv

* lib: fix memory leak

* lib: fix memory leak when handling I/O

* Update series
abdosi pushed a commit that referenced this pull request Jan 3, 2020
* lldpctl: put a lock around some commands to avoid race conditions

* Read all notifications in lldpctl_recv

* lib: fix memory leak

* lib: fix memory leak when handling I/O

* Update series
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants