[Mellanox] Initialize system LED color to green for 201911 #4743
Conversation
|
This pull request introduces 1 alert when merging 4a85792 into 0a70571 - view on LGTM.com new alerts:
|
We need to handle all exception here to avoid this function break chassis initialization. |
Sure. |
|
Why not having that on master and once the system led will be fully available? |
On master, system led will depends on Led class which is a part of PSU/Fan LED feature. Since PSU/Fan LED feature will not be included in 201911, we can't reuse that part in 201911. |
| This is for 201911 branch only | ||
| """ | ||
| try: | ||
| with open(LED_GREEN, 'w') as f: |
There was a problem hiding this comment.
@Junchao-Mellanox maybe it is better to have more meaningful name, e.g. SYSTEM_STATUS_LED. This will help to differentiate from other board leds
|
This pull request introduces 1 alert when merging ff7c141 into 093d773 - view on LGTM.com new alerts:
|
- Why I did it
Before adding the system led control which is planned for 202006, set the system LED color to green by default.
- How I did it
Initialize system status LED color to green in the constructor of chassis.py.
- How to verify it
Manual test on SN2700, SN3800 and SN4700
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)