Use default table instead of main table for forced_mgmt_routes #635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
add some comments in the commit message? |
lguohan
approved these changes
May 27, 2017
lguohan
added a commit
to lguohan/sonic-buildimage
that referenced
this pull request
Dec 28, 2018
* 0c07a80 2018-12-27 | [intfmgrd]: Merge intfsyncd into intfmgrd (sonic-net#635) (HEAD, origin/master, origin/HEAD) [Marian Pritsak] * a45c7b5 2018-12-23 | [watermark] fix watermark clear not working for PG (sonic-net#729) [Mykola F] * 25d16b3 2018-12-23 | [neighorch] return back original condition for port oper status (sonic-net#727) [Qi Luo] |\ | * 05a3558 2018-12-12 | [neighorch] return back original condition for port oper status [Stepan Blyschak] * | 514cfef 2018-12-23 | [swssconfig]: Remove deprecated qos buffer configurations (sonic-net#726) [Shuotian Cheng] * | 025268a 2018-12-22 | [WR]: Add reconciliation logic for teamsyncd (sonic-net#725) [pavel-shirshov] * | 5803a8c 2018-12-21 | Fix: crash while destructing crmorch (sonic-net#731) [Qi Luo] * | 998b4ab 2018-12-21 | Temporarily skip the testcase test_routing_WarmRestart to unblock other pull requests (sonic-net#733) [Qi Luo] * | a7a68c1 2018-12-19 | Optimize neigh restore process during warm-reboot (sonic-net#722) [zhenggen-xu] |/ * 3d60b3e 2018-12-03 | [portsorch] Portsorch simple improvements (sonic-net#718) [stepanblyschak] Signed-off-by: Guohan Lu <gulv@microsoft.com>
lguohan
added a commit
that referenced
this pull request
Dec 29, 2018
* 0c07a80 2018-12-27 | [intfmgrd]: Merge intfsyncd into intfmgrd (#635) (HEAD, origin/master, origin/HEAD) [Marian Pritsak] * a45c7b5 2018-12-23 | [watermark] fix watermark clear not working for PG (#729) [Mykola F] * 25d16b3 2018-12-23 | [neighorch] return back original condition for port oper status (#727) [Qi Luo] |\ | * 05a3558 2018-12-12 | [neighorch] return back original condition for port oper status [Stepan Blyschak] * | 514cfef 2018-12-23 | [swssconfig]: Remove deprecated qos buffer configurations (#726) [Shuotian Cheng] * | 025268a 2018-12-22 | [WR]: Add reconciliation logic for teamsyncd (#725) [pavel-shirshov] * | 5803a8c 2018-12-21 | Fix: crash while destructing crmorch (#731) [Qi Luo] * | 998b4ab 2018-12-21 | Temporarily skip the testcase test_routing_WarmRestart to unblock other pull requests (#733) [Qi Luo] * | a7a68c1 2018-12-19 | Optimize neigh restore process during warm-reboot (#722) [zhenggen-xu] |/ * 3d60b3e 2018-12-03 | [portsorch] Portsorch simple improvements (#718) [stepanblyschak] Signed-off-by: Guohan Lu <gulv@microsoft.com>
yxieca
pushed a commit
that referenced
this pull request
Jan 4, 2019
* 0c07a80 2018-12-27 | [intfmgrd]: Merge intfsyncd into intfmgrd (#635) (HEAD, origin/master, origin/HEAD) [Marian Pritsak] * a45c7b5 2018-12-23 | [watermark] fix watermark clear not working for PG (#729) [Mykola F] * 25d16b3 2018-12-23 | [neighorch] return back original condition for port oper status (#727) [Qi Luo] |\ | * 05a3558 2018-12-12 | [neighorch] return back original condition for port oper status [Stepan Blyschak] * | 514cfef 2018-12-23 | [swssconfig]: Remove deprecated qos buffer configurations (#726) [Shuotian Cheng] * | 025268a 2018-12-22 | [WR]: Add reconciliation logic for teamsyncd (#725) [pavel-shirshov] * | 5803a8c 2018-12-21 | Fix: crash while destructing crmorch (#731) [Qi Luo] * | 998b4ab 2018-12-21 | Temporarily skip the testcase test_routing_WarmRestart to unblock other pull requests (#733) [Qi Luo] * | a7a68c1 2018-12-19 | Optimize neigh restore process during warm-reboot (#722) [zhenggen-xu] |/ * 3d60b3e 2018-12-03 | [portsorch] Portsorch simple improvements (#718) [stepanblyschak] Signed-off-by: Guohan Lu <gulv@microsoft.com>
madhanmellanox
pushed a commit
to madhanmellanox/sonic-buildimage
that referenced
this pull request
Mar 23, 2020
* VNET/VRF Changes (#6) * VRF changes * Fixed an IPv6 address parsing issue * Updated logs, removed intfmgr changes in favour of PR sonic-net#635 * Updated VRF table name * Addressed review comment, test fixes * Remove extra semi-colon * Route handling, review comments (#8) * Vnet route table handling * Addressed review comments * Fix for interface routes, add debug logs
madhanmellanox
pushed a commit
to madhanmellanox/sonic-buildimage
that referenced
this pull request
Mar 23, 2020
* [intfmgrd]: Merge intfsyncd into intfmgrd Move intfsyncd functionality to intfmgrd, add VRF membership support.
stepanblyschak
pushed a commit
to stepanblyschak/sonic-buildimage
that referenced
this pull request
Jul 15, 2020
Updated sonic-sairedis pointer:
d54bfb4 [SAI] update pointer (sonic-net#636)
1885a8c [syncd] Fix notification on shutdown request (sonic-net#635)
9e57ba2 Fixing hostif For Genetlink host interfaces (sonic-net#633)
449a092 sonic-sairedis: Add support to sonic-sairedis for gearbox phys (sonic-net#632)
Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>
lguohan
pushed a commit
that referenced
this pull request
Jul 18, 2020
Upgrade to libsensors5
Updated sonic-sairedis pointer:
d54bfb4 [SAI] update pointer (#636)
1885a8c [syncd] Fix notification on shutdown request (#635)
9e57ba2 Fixing hostif For Genetlink host interfaces (#633)
449a092 sonic-sairedis: Add support to sonic-sairedis for gearbox phys (#632)
Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>
dmytroxshevchuk
pushed a commit
to dmytroxshevchuk/sonic-buildimage
that referenced
this pull request
Aug 31, 2020
* [syncd] Fix notification on shutdown request * Move check to the beginning of the function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the previous version, we forced certain prefixes to use mgmt route by adding routes into routing table in eth0 interface up script. This is mainly for connection to crucial mgmt services such as syslog when front panel port networking is not healthy. However, this creates an issue when BGP neighbor announces the same prefixes - those routes will fail to be added into kernel routing table, thus fail to be synced into ASIC.
The correct way to add forced mgmt routes is to create another routing table using mgmt network (which we already did), and to use ip rule to use this routing table for certain destinations. By this approach control plane and data plane routes are isolated and could be configured independently.