Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Control fans and sensors by BMC #633

Closed
YaoTien opened this issue May 25, 2017 · 6 comments
Closed

Control fans and sensors by BMC #633

YaoTien opened this issue May 25, 2017 · 6 comments
Assignees
@jleveque
Labels
Question ❓

Comments

@YaoTien
Copy link
Contributor

YaoTien commented May 25, 2017

Hi,

I would like to porting fans and sensors for our device, and had been study the porting guide.
As the guide, it looks like fans and sensors be manage by CPU.
However, our device adopt BMC to manage fans and sensors, and commucate to system through IPMI.
As BMC case, SONiC how to control fans and sensors?
Can the porting guide be used on BMC case?
Thanks for your response.
@lguohan
Copy link
Collaborator

lguohan commented May 30, 2017

you mention "BMC to manage fans and sensors", since BMC already does that, what do you need SONiC to do with the fans and sensors? As you mention IPMI, SONiC can also use IPMI to retrieve information from BMC.

@YaoTien
Copy link
Contributor Author

YaoTien commented May 31, 2017 •
edited
Loading

Hi @lguohan
So I don't need to add fancontrol, sensors.conf and led_control.py files, right?
Thanks.

@stcheng
Copy link
Contributor

stcheng commented May 31, 2017

I think fancontrol is not needed in SONiC as it is already handled outside in BMC.
As for the sensors.conf, I think it is not bad to put one inside SONiC as we're doing passive monitoring on the sensors that the system could detect. As for the led_control.py, it is related to the front panel port LEDs not related to the box peripheral LEDs.

@YaoTien
Copy link
Contributor Author

YaoTien commented Jun 2, 2017

As I say, BMC manage fans, sensors, eeproms of sfp in our board.
So when I do "show environment", only display CPU's temperatures.
Should I get sensors information by IPMI and integrate to "show environment"?
Thanks.

@jleveque
Copy link
Contributor

jleveque commented Jul 3, 2019

Hi @YaoTien. The new SONiC platform API is now available here. https://github.com/Azure/sonic-platform-common/tree/master/sonic_platform_base. We will soon be transitioning all daemons and CLI to interact with platform hardware using this API. You should implement the API for your platform to communicate with your BMC. The "show environment" command will eventually display sensor data by calling functions in the new platform API.

@yxieca yxieca mentioned this issue Sep 9, 2019
Merged
yxieca added a commit to yxieca/sonic-buildimage that referenced this issue Sep 9, 2019
@yxieca
[201811] advance sairedis, swss and utilities sub module head
eee898b 
Submodule src/sonic-sairedis 4ee82cb..1cf2eea:
  > Add acl counter match logic based on acl entry field (sonic-net#511)
  > Add specific comparison logic for ACL counter (sonic-net#484)

Submodule src/sonic-swss 46bc1f4..660530e:
  > Fix VLAN error introduced with new 4.9 kernel behavior (sonic-net#1001)
  > Warmboot Vlan neigh restore fix (sonic-net#1040)

Submodule src/sonic-utilities 11b4cf1..f76fc2c:
  > [warm reboot] Skip ASIC config pre-check if current image does not support it (sonic-net#637)
  > [FastReboot]: Send SIGINT to all teamd before stop (sonic-net#633)
  > [warm/fast reboot] provide strict option to prevent warm reboot under certain conditions (sonic-net#631)

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
@jleveque jleveque mentioned this issue Sep 10, 2019
Merged
yxieca added a commit that referenced this issue Sep 10, 2019
@yxieca
[201811] advance sairedis, swss and utilities sub module head (#3424)
96038ee 
Submodule src/sonic-sairedis 4ee82cb..1cf2eea:
  > Add acl counter match logic based on acl entry field (#511)
  > Add specific comparison logic for ACL counter (#484)

Submodule src/sonic-swss 46bc1f4..660530e:
  > Fix VLAN error introduced with new 4.9 kernel behavior (#1001)
  > Warmboot Vlan neigh restore fix (#1040)

Submodule src/sonic-utilities 11b4cf1..f76fc2c:
  > [warm reboot] Skip ASIC config pre-check if current image does not support it (#637)
  > [FastReboot]: Send SIGINT to all teamd before stop (#633)
  > [warm/fast reboot] provide strict option to prevent warm reboot under certain conditions (#631)

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
Kalimuthu-Velappan pushed a commit to Kalimuthu-Velappan/sonic-buildimage that referenced this issue Sep 12, 2019
@pavel-shirshov
[FastReboot]: Send SIGINT to all teamd before stop (sonic-net#633)
7cf821c 
* [FastReboot]: Send SIGINT to all teamd before stop

* exit code == 1 is valid for pkill

* Check that all teamd are stopped before to kill the container
yxieca added a commit to yxieca/sonic-buildimage that referenced this issue Sep 17, 2019
@yxieca
[201811][utilities] advance sub module head
7e929a7 
Submodule src/sonic-utilities fe2c656..afaedb7:
  > Revert "[FastReboot]: Send SIGINT to all teamd before stop (sonic-net#633)" (sonic-net#650)
  > Fixed config Asym PFC CLI. (sonic-net#632)
  > [config] Do no stop or restart dependent services (sonic-net#582)

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
@yxieca yxieca mentioned this issue Sep 17, 2019
Merged
yxieca added a commit that referenced this issue Sep 18, 2019
@yxieca
[201811][utilities] advance sub module head (#3469)
9f03af0 
Submodule src/sonic-utilities fe2c656..afaedb7:
  > Revert "[FastReboot]: Send SIGINT to all teamd before stop (#633)" (#650)
  > Fixed config Asym PFC CLI. (#632)
  > [config] Do no stop or restart dependent services (#582)

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
@jleveque
Copy link
Contributor

@YaoTien: Since you haven't responded to my previous comment, I am assuming the new platform API will suffice. Please feel free to reopen this or open a new issue if need be.

madhanmellanox pushed a commit to madhanmellanox/sonic-buildimage that referenced this issue Mar 23, 2020
@jipanyang @qiluo-msft
Switch to "config warm_restart" CLI for warm restart configuration (s…
8f279a1 
…onic-net#633)
stepanblyschak pushed a commit to stepanblyschak/sonic-buildimage that referenced this issue Jul 15, 2020
[dockers] update mellanox syncd and pmon to buster
f892666 
Updated sonic-sairedis pointer:
    d54bfb4 [SAI] update pointer (sonic-net#636)
    1885a8c [syncd] Fix notification on shutdown request (sonic-net#635)
    9e57ba2 Fixing hostif For Genetlink host interfaces (sonic-net#633)
    449a092 sonic-sairedis: Add support to sonic-sairedis for gearbox phys (sonic-net#632)

Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>
lguohan pushed a commit that referenced this issue Jul 18, 2020
@stepanblyschak
[dockers] update mellanox syncd and pmon to buster (#4818)
16a37d8 
Upgrade to libsensors5

Updated sonic-sairedis pointer:
    d54bfb4 [SAI] update pointer (#636)
    1885a8c [syncd] Fix notification on shutdown request (#635)
    9e57ba2 Fixing hostif For Genetlink host interfaces (#633)
    449a092 sonic-sairedis: Add support to sonic-sairedis for gearbox phys (#632)

Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>
dmytroxshevchuk pushed a commit to dmytroxshevchuk/sonic-buildimage that referenced this issue Aug 31, 2020
Fixing hostif For Genetlink host interfaces (sonic-net#633)
9e57ba2 
Co-authored-by: dgsudharsan <sudharsan_gopalarat@dell.com>
stepanblyschak pushed a commit to stepanblyschak/sonic-buildimage that referenced this issue May 10, 2021
@yxieca @lguohan
Revert "[FastReboot]: Send SIGINT to all teamd before stop (sonic-net…
e8f93c4 
…#633)" (sonic-net#650)

This reverts commit 7cf821c.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jleveque jleveque

Labels
Question ❓
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@lguohan @stcheng @jleveque @YaoTien