V1.0.3 backup VLAN trunk implementation

[jipanyang]

No description provided.

[msftclas]

@JipanYanga,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

[lguohan]

@taoyl-ms to review

[stcheng]

Hi Jipan, is it possible that you could split this pull request into multiple related pull requests, e.g. one for the orchagent change, one for the config agent, etc.

[jipanyang]

Hi Shuotian, Technically I could split the changes into two parts, one for orchagent and the other for config agent. The hostenv setup in congfigAgent and ASIC setup from Orchagent need to work together to get VLAN trunk functioning. What is the purpose of this splitting? If it is for simplifying the review, I could do it. The commit history log for VLAN trunk will be lost. Thanks, Jipan From: Shuotian Cheng <notifications@github.com> Reply-To: Azure/sonic-buildimage <reply@reply.github.com> Date: Thursday, August 24, 2017 at 2:09 PM To: Azure/sonic-buildimage <sonic-buildimage@noreply.github.com> Cc: Jipan Yang <jipan.yang@alibaba-inc.com>, Mention <mention@noreply.github.com> Subject: Re: [Azure/sonic-buildimage] V1.0.3 backup VLAN trunk implementation (#911) Hi Jipan, is it possible that you could split this pull request into multiple related pull requests, e.g. one for the orchagent change, one for the config agent, etc. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread. {"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/Azure/sonic-buildimage","title":"Azure/sonic-buildimage","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/Azure/sonic-buildimage"}},"updates":{"snippets":[{"icon":"PERSON","message":"@stcheng in #911: Hi Jipan, is it possible that you could split this pull request into multiple related pull requests, e.g. one for the orchagent change, one for the config agent, etc."}],"action":{"name":"View Pull Request","url":"#911 (comment)"}}}

[stcheng]

I think this is a large feature. here you squash them into one commit. It is already losing the commit history. Either splitting the pull request, or have a better commit history so we do a regular merge commit instead of a squash one. This will benefit both git commit view and pull request review.

[stcheng]

Hello, @JipanYanga , sorry for the confusion. I'm referring to the sonic-swss code changes.

[taoyl-ms]

sonic-net/sonic-swss#294

[stcheng]

why adding dbg here?

[jipanyang]

Have been seeing issues related to netlink, this to get the dbg file copied to target/debs folder. It makes it easier to find the libnl debug package and install it when needed.

[jipanyang]

target branch not active.