Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sairedis]: force to disable parallel build for sairedis package #921

Closed
wants to merge 1 commit into from
Closed

[sairedis]: force to disable parallel build for sairedis package #921

wants to merge 1 commit into from

Conversation

lguohan
Copy link
Collaborator

@lguohan lguohan commented Aug 27, 2017 •
edited
Loading

sairedis package cannot be built in parellel

@marian-pritsak
Copy link
Collaborator

@lguohan When do you have problems with a parallel build for sairedis? Is it related to some platform? Can you share log with failure?

@lguohan
Copy link
Collaborator Author

lguohan commented Aug 31, 2017

when doing parellel, it tries to build syncd, syncd-rpc target at the same time, then there is race condition. It fails at the different places each time.

You can see following if you use dpkg-buildpackage -us -uc -b -j4

dh build  -N syncd-rpc -N syncd-rpc-dbg --with autotools-dev
dh build  -N syncd -N syncd-dbg --with autotools-dev

@marian-pritsak
Copy link
Collaborator

https://github.com/Azure/sonic-sairedis/blob/master/debian/rules#L25

Can you please try to change

binary: binary-syncd binary-syncd-rpc

to

binary: binary-syncd-rpc

binary-syncd-rpc: binary-syncd

This will make builds in sairedis sequential (first binary-syncd, then binary-syncd-rpc) and we won't have such conflicts

@stcheng
Copy link
Contributor

stcheng commented Sep 6, 2017

@marian-pritsak this seems to change the dependency relationship. but binary-syncd and binary-syncd-rpc are not dependent with each other.

@jleveque
Copy link
Contributor

jleveque commented Sep 6, 2017

We could just make binary-syncd an order-only prerequisite of binary-syncd-rpc, which will ensure binary-syncd is always built first, but does not imply a dependency between the two:

binary: binary-syncd binary-syncd-rpc
binary-syncd-rpc: | binary-syncd

@lguohan
Copy link
Collaborator Author

lguohan commented Sep 19, 2017

solve in sonic-net/sonic-sairedis#225

@lguohan lguohan closed this Sep 19, 2017
yxieca added a commit to yxieca/sonic-buildimage that referenced this pull request Jun 4, 2019
@yxieca
[201811][swss][utilities] advance sub module head
6168af6 
Submodule src/sonic-utilities 6b4d1a0..46b5aa8:
  > [show ip interface] Add support for 'alias' interface naming mode (sonic-net#486)

Submodule src/sonic-swss 9c4ae18..a637562:
  > Suppress storm detect counter increment for ongoing pfc storm case during a warm reboot (sonic-net#869)
  > Remove *_LEFT fields to allow PFC watchdog to enter fresh into the (sonic-net#897)
  > Set LAG mtu value based on kernel netlink msg (sonic-net#922)
  > [warm restart assist] assume vector values could be reordered (sonic-net#921)

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
@yxieca yxieca mentioned this pull request Jun 4, 2019
Merged
yxieca added a commit that referenced this pull request Jun 4, 2019
@yxieca
[201811][swss][utilities] advance sub module head (#2968)
fbe9715 
Submodule src/sonic-utilities 6b4d1a0..46b5aa8:
  > [show ip interface] Add support for 'alias' interface naming mode (#486)

Submodule src/sonic-swss 9c4ae18..a637562:
  > Suppress storm detect counter increment for ongoing pfc storm case during a warm reboot (#869)
  > Remove *_LEFT fields to allow PFC watchdog to enter fresh into the (#897)
  > Set LAG mtu value based on kernel netlink msg (#922)
  > [warm restart assist] assume vector values could be reordered (#921)

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
@dgsudharsan dgsudharsan mentioned this pull request Jun 7, 2019
Merged
seiferteric pushed a commit to project-arlo/sonic-buildimage that referenced this pull request Oct 14, 2019
@jangidrk
Update git submodules
587b146 
* Update src/sonic-swss from branch 'broadcom_sonic'
  to cd2a2e0504412254d4d44f5f97946921dc246cc6
  - Merge 201904 branch to broadcom_sonic branch on Mon Jul  1 13:57:57 PDT 2019
    
    Change-Id: I77bef1ba390171f204e27387bee0226ddab38971
    
  - [debian]: Do not build test when building with real SAI (sonic-net#932)
    
    
  - swss-orchagent: add new orch for vnet routes/tunnel routes tables in CONFIG_DB  (sonic-net#907)
    
    * Vnet route persistence
    
    Signed-off-by: weixi.chen@microsoft.com
    
    
  - pkill -9 zebra for frr warm restart VS test fix (sonic-net#927)
    
    Signed-off-by: Jipan Yang <jipan.yang@alibaba-inc.com>
  - [vnetorch]: Fix tunnel route removal flow for bitmap VNET (sonic-net#912)
    
    Signed-off-by: Volodymyr Samotiy <volodymyrs@mellanox.com>
  - [orchagent]: Added support of PFC WD for BFN platform (sonic-net#823)
    
    * [orchagent]: Added support of PFC WD for BFN platform
    
    Signed-off-by: Vitaliy Senchyshyn  <vsenchyshyn@barefootnetworks.com>
    
    * Fixed review comments
    
    Signed-off-by: Vitaliy Senchyshyn <vsenchyshyn@barefootnetworks.com>
    
    * Use PFC WD ACL handler for BFN platform
    
  - [aclorch] unittest by gtest (sonic-net#924)
    
    
  - [orchagent]: Remove try/catch for correct coredump file (sonic-net#790)
    
    Signed-off-by: Jipan Yang <jipan.yang@alibaba-inc.com>
    
    
  - Set LAG mtu value based on kernel netlink msg (sonic-net#922)
    
    * Update mtu value based on kernel netlink msg
    
    * Push the calculated MTU size into the fvVector
    
  - Address review comment: remove data member m_entriesCreated, which is introduced for dependancy resolution purpose. (sonic-net#839)
    
    Signed-off-by: Wenda Ni <wenni@microsoft.com>
  - [vxlanorch] Ambiguous return code for removeNextHopTunnel (sonic-net#880)
    
    Change to return false when isTunnelExists is fail
  - [vnet]: Extend Bitmap VNET test with "remove" flows (sonic-net#900)
    
    Signed-off-by: Volodymyr Samotiy <volodymyrs@mellanox.com>
  - add dynamic transceiver tuning support (sonic-net#821)
    
    
  - Remove *_LEFT fields to allow PFC watchdog to enter fresh into the (sonic-net#897)
    
    operational/storm state
    
    Signed-off-by: Wenda Ni <wenni@microsoft.com>
  - Fix vlan incremental config and add vs test cases (sonic-net#799)
    
    * Fix vlan incremental config and add vs test cases
    
    Signed-off-by: Jipan Yang <jipan.yang@alibaba-inc.com>
  - Suppress storm detect counter increment for ongoing pfc storm case during a warm reboot (sonic-net#869)
    
    * Suppress storm detect counter increment for ongoing pfc storm case during
    a warm reboot
    
    Signed-off-by: Wenda Ni <wenni@microsoft.com>
    
    * Comment touch-up
    
    Signed-off-by: Wenda Ni <wenni@microsoft.com>
    
  - [warm restart assist] assume vector values could be reordered (sonic-net#921)
    
    When comparing 2 vectors, assume their elements could be re-ordered.
    
    Signed-off-by: Ying Xie <ying.xie@microsoft.com>
  - [test]: Mark some VLAN tests as Stretch only (sonic-net#903)
    
    Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>
  - [aclorch]: Add MIRROR_DSCP table type (sonic-net#906)
    
    Add MIRROR_DSCP table to support creating an ACL mirro table
    that only matches DSCP value/mask.
    
    Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>
  - [debian] increment debian compatibility to 10 to enable parallel package build (sonic-net#911)
    
    From debhelper man pages:
    
    "If neither option is specified, debhelper currently defaults to
    --parallel in compat 10 (or later) and --no-parallel otherwise."
    
    Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>
  - [test]: Skip tests under investigation (sonic-net#919)
    
    
  - [vstest]: Update the mirror session state table name (sonic-net#917)
    
    Due to the change
    
    c033b23
    Fix MIRROR_SESSION table macro name (sonic-net#802)
    
    Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>
  - Ignore neighbor entry with BCAST MAC, check SAI status exists (sonic-net#914)
    
    * Ignore neighbor entry with BCAST MAC, check SAI status exists
    
    * Addressed review comment
    
  - Fix MIRROR_SESSION table macro name (sonic-net#802)
    
    Signed-off-by: Jipan Yang <jipan.yang@alibaba-inc.com>
  - [policerorch]: Add PolicerOrch to bundle with mirror session (sonic-net#889)
    
    Now that we could create a policer for the mirror session to
    throttle the mirroring traffic.
    
    configuration:
    
    POLICER|NAME:
     meter_type:packets|bytes
     mode:sr_tcm|tr_tcm|storm_control
     cir|DIGITS
     cbs|DIGITS
     pir|DIGITS
     pbs|DIGITS
     corlor_source:aware|blind
     red_action:drop
     yellow_action:drop
     green_action:drop
    
    MIRROR_SESSION|NAME:
     policer:policer_name
    
    Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>
madhanmellanox pushed a commit to madhanmellanox/sonic-buildimage that referenced this pull request Mar 23, 2020
@yxieca
[warm restart assist] assume vector values could be reordered (sonic-…
f3d0279 
…net#921)

When comparing 2 vectors, assume their elements could be re-ordered.

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
abdosi added a commit that referenced this pull request Jun 22, 2020
@abdosi
[submodule update] sonic-utilities
16d39c6 
Fix for command. show interface transceiver eeprom -d Ethernet (#955)
Updated natshow script to support DNAT Pool changes (#921)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marian-pritsak marian-pritsak Awaiting requested review from marian-pritsak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lguohan @marian-pritsak @stcheng @jleveque @msftclas