[pfcwd]: add command to set pfcwd polling interval #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
depends on sonic-net/sonic-swss#435 |
sihuihan88
force-pushed
the
dev/sihan/poll
branch
from
b9e67a8
to
ad08d7e
Compare
marian-pritsak
suggested changes
Jan 30, 2018
| @@ -92,7 +92,8 @@ def config(ports): | |||
| line = config_entry.get(config[1], config[2]) | |||
| config_list.append(line) | |||
| table.append([port] + config_list) | |||
|
|
|||
| poll_interval = configdb.get_entry( 'PFC_WD_TABLE', 'GLOBAL').get('POLL_INTERVAL') | |||
There was a problem hiding this comment.
Does someone write default value there or should we check if it's not empty?
There was a problem hiding this comment.
changed to display only when the value is changed.
pfcwd/main.py
Outdated
| configdb = swsssdk.ConfigDBConnector() | ||
| configdb.connect() | ||
| countersdb = swsssdk.SonicV2Connector(host='127.0.0.1') | ||
| countersdb.connect(countersdb.COUNTERS_DB) |
There was a problem hiding this comment.
No need to connect to COUNTERS_DB in this function
pfcwd/main.py
Outdated
| @@ -127,6 +128,21 @@ def start(action, restoration_time, ports, detection_time): | |||
| configdb.mod_entry("PFC_WD_TABLE", port, None) | |||
| configdb.mod_entry("PFC_WD_TABLE", port, pfcwd_info) | |||
|
|
|||
| # Set WD poll interval | |||
| @cli.command() | |||
| @click.option('--poll_interval', '-p', type=click.IntRange(100, 3000)) | |||
There was a problem hiding this comment.
Argument instead of an option?
Options are usually optional, and it's not the case for poll interval,
sihuihan88
force-pushed
the
dev/sihan/poll
branch
from
ad08d7e
to
cd658d3
Compare
Signed-off-by: Sihui Han <sihan@microsoft.com>
sihuihan88
force-pushed
the
dev/sihan/poll
branch
from
cd658d3
to
7360275
Compare
lguohan
approved these changes
Feb 9, 2018
marian-pritsak
approved these changes
Feb 9, 2018
zhenggen-xu
added a commit
to zhenggen-xu/sonic-utilities
that referenced
this pull request
Jun 6, 2018
RB=1288101
G=lnos-reviewers
R=ntrianta,pmao,rmolina,sfardeen,zxu
* github:
[acl_loader] Support Service ACL binding to multiple services (sonic-net#236)
[show] Rename 'show session' to 'show mirror session' (sonic-net#235)
[pfcstat]: create python cli tool to show pfc counters (sonic-net#233)
[queuestat] add python CLI tool to show queue counters
[acl-loader] Not to crash upon invalid rule (sonic-net#232)
Show FDB type in fdbshow/show mac (sonic-net#231)
[show] add 'show runningconfiguration all' subcommand (sonic-net#230)
[reboot scripts] remove -t option in docker exec commands (sonic-net#228)
[reboot] reduce stop service to only stop syncd (sonic-net#223)
[crm]: Fix failures in CLI show commands (sonic-net#221)
[Fast-reboot]: Gracefully shutdown syncd in fast-reboot (sonic-net#212)
add fast-reboot support for nephos platform by stop kernel modules (sonic-net#220)
[config bgp] Convert user input ipv6 addr to lower case before comparing (sonic-net#218)
[PFCWD]: set default configuration when enabled by default (sonic-net#213)
Add fast-reboot support for Aboot based images (sonic-net#214)
sonic-utilities: Format show vlan config output (sonic-net#210)
[AAA] Support login(ascii) authentication type (sonic-net#217)
[sfputil] Adapt new way of getting PLATFORM(sonic-net#216)
[Fast-Reboot]: Adapt fast-reboot-dump script for SAIv1.2 (sonic-net#211)
Refactor fast-reboot script. Generate fast-reboot-dumps into configurable directory (sonic-net#208)
Find correct opennsl module name before stopping it (sonic-net#207)
[crm]: Add utility for CRM configuration (sonic-net#187)
[reboot] update reboot script to retrieve platform with new format (sonic-net#206)
Adapt to config engine change to load platform info properly (sonic-net#205)
[config] Add qos clear and qos reload support (sonic-net#204)
Dump default routes from APPL_DB table before fast-reboot (sonic-net#203)
[acl_loader] Fix a crash issue when appdb is not consistent with cfgdb (sonic-net#202)
[pfcwd]: add command to set pfcwd polling interval (sonic-net#192)
[acl-loader] Prevent from hanging if run by non-root user (sonic-net#199)
[config] Store ConfigDB init indicator boolean value as 1/0 in Redis to be language-agnostic (sonic-net#197)
Get Vlan Id from SAI Vlan Object if bvid present (sonic-net#196)
[TACACS+]: Fix aaa show error without configuration (sonic-net#191)
'config bgp [shutdown|startup] neighbor <hostname>' now affects all sessions for neighbor (sonic-net#195)
[sonic-clear] add a clear fdb command (sonic-net#186)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sihui Han sihan@microsoft.com
- What I did
Add command to set pfcwd polling interval
- How I did it
Add set poll interval command
- How to verify it
Test on DUT
- Previous command output (if the output of a command-line utility has changed)
- New command output (if the output of a command-line utility has changed)
-->